Revert "Shift drag to add to selection (#350)" (#352)

This reverts commit ce467f7b65.
This commit is contained in:
Christopher Chedeau 2020-01-12 12:08:18 -08:00 committed by GitHub
parent ce467f7b65
commit f91b708abb
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 12 additions and 23 deletions

View file

@ -15,7 +15,7 @@ import {
import {
clearSelection,
deleteSelectedElements,
getElementsWithinSelection,
setSelection,
isOverScrollBars,
restoreFromLocalStorage,
saveToLocalStorage,
@ -746,24 +746,13 @@ export class App extends React.Component<{}, AppState> {
this.state.scrollY;
draggingElement.width = width;
// Make a perfect square or circle when shift is enabled
draggingElement.height =
// Shift key on selection must add items to selection
e.shiftKey && this.state.elementType !== "selection"
? Math.abs(width) * Math.sign(height)
: height;
draggingElement.height = e.shiftKey
? Math.abs(width) * Math.sign(height)
: height;
draggingElement.shape = null;
if (this.state.elementType === "selection") {
const elementsWithinSelection = getElementsWithinSelection(
elements,
draggingElement
);
if (!e.shiftKey) {
elements = clearSelection(elements);
}
elementsWithinSelection.forEach(
element => (element.isSelected = true)
);
elements = setSelection(elements, draggingElement);
}
// We don't want to save history when moving an element
history.skipRecording();