smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: text content with tab characters act different in view/edit (#8336)

Browse source 
Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
This commit is contained in:
Clarence Chan 2024-08-09 16:20:36 -04:00 • committed by GitHub
parent 7b2bee9746
commit f7b3befd0a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 12 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/excalidraw/components/App.tsx
View file

@ -332,6 +332,7 @@ import {
isMeasureTextSupported, isMeasureTextSupported,
isValidTextContainer, isValidTextContainer,
measureText, measureText,
normalizeText,
wrapText, wrapText,
} from "../element/textElement"; } from "../element/textElement";
import { import {
@ -3412,7 +3413,7 @@ class App extends React.Component<AppProps, AppState> {
const lines = isPlainPaste ? [text] : text.split("\n"); const lines = isPlainPaste ? [text] : text.split("\n");
const textElements = lines.reduce( const textElements = lines.reduce(
(acc: ExcalidrawTextElement[], line, idx) => { (acc: ExcalidrawTextElement[], line, idx) => {
const originalText = line.trim(); const originalText = normalizeText(line).trim();
if (originalText.length) { if (originalText.length) {
const topLayerFrame = this.getTopLayerFrameAtSceneCoords({ const topLayerFrame = this.getTopLayerFrameAtSceneCoords({
x, x,

11
packages/excalidraw/element/textWysiwyg.tsx
View file

@ -357,7 +357,16 @@ export const textWysiwyg = ({
}; };
editable.oninput = () => { editable.oninput = () => {
onChange(normalizeText(editable.value)); const normalized = normalizeText(editable.value);
if (editable.value !== normalized) {
const selectionStart = editable.selectionStart;
editable.value = normalized;
// put the cursor at some position close to where it was before
// normalization (otherwise it'll end up at the end of the text)
editable.selectionStart = selectionStart;
editable.selectionEnd = selectionStart;
}
onChange(editable.value);
}; };
} }