smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix group element removing (#1676)

Browse source
This commit is contained in:
David Luzar 2020-05-30 22:48:57 +02:00 • committed by GitHub
parent 17e9cc4506
commit f413bab3de
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
11 changed files with 478 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/element/mutateElement.ts
View file

@ -34,7 +34,7 @@ export const mutateElement = <TElement extends Mutable<ExcalidrawElement>>(
if (
(element as any)[key] === value &&
// if object, always update in case its deep prop was mutated
(typeof value !== "object" || value === null)
(typeof value !== "object" || value === null || key === "groupIds")
) {
continue;
}

3
src/element/newElement.ts
View file

@ -12,6 +12,7 @@ import { measureText, getFontString } from "../utils";
import { randomInteger, randomId } from "../random";
import { newElementWith } from "./mutateElement";
import { getNewGroupIdsForDuplication } from "../groups";
import { AppState } from "../types";
type ElementConstructorOpts = {
x: ExcalidrawGenericElement["x"];
@ -169,7 +170,7 @@ export const deepCopyElement = (val: any, depth: number = 0) => {
* @param overrides Any element properties to override
*/
export const duplicateElement = <TElement extends Mutable<ExcalidrawElement>>(
editingGroupId: GroupId | null,
editingGroupId: AppState["editingGroupId"],
groupIdMapForOperation: Map<GroupId, GroupId>,
element: TElement,
overrides?: Partial<TElement>,

2
src/element/types.ts
View file

@ -21,7 +21,7 @@ type _ExcalidrawElementBase = Readonly<{
version: number;
versionNonce: number;
isDeleted: boolean;
groupIds: GroupId[];
groupIds: readonly GroupId[];
}>;
export type ExcalidrawSelectionElement = _ExcalidrawElementBase & {