smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix conflicts

Browse source
This commit is contained in:
Marcel Mraz 2025-04-30 12:32:53 +02:00
parent becdbcb2d7
commit e8898b4429
No known key found for this signature in database
GPG key ID: 4EBD6E62DC830CD2
1 changed files with 76 additions and 679 deletions
Download patch file Download diff file Expand all files Collapse all files

755
packages/excalidraw/tests/__snapshots__/history.test.tsx.snap
View file

@ -199,7 +199,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"frameId": null, "frameId": null,
"groupIds": [], "groupIds": [],
"height": "102.45605", "height": "102.45605",
"id": "id172", "id": "id689",
"index": "a2", "index": "a2",
"isDeleted": false, "isDeleted": false,
"lastCommittedPoint": null, "lastCommittedPoint": null,
@ -271,321 +271,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
} }
`; `;
exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and the arrow got bound to a different element in the meantime > [end of test] history 1`] = `
History {
"onHistoryChangedEmitter": Emitter {
"subscribers": [
[Function],
[Function],
],
},
"redoStack": [
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {},
"inserted": {},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {},
"updated": Map {
"id171" => Delta {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id172",
"type": "arrow",
},
],
},
},
"id172" => Delta {
"deleted": {
"endBinding": {
"elementId": "id175",
"fixedPoint": [
"0.50000",
1,
],
"focus": 0,
"gap": 1,
},
"height": "70.45017",
"points": [
[
0,
0,
],
[
"100.70774",
"70.45017",
],
],
"startBinding": {
"elementId": "id170",
"focus": "0.02970",
"gap": 1,
},
},
"inserted": {
"endBinding": {
"elementId": "id171",
"focus": "-0.02000",
"gap": 1,
},
"height": "0.09250",
"points": [
[
0,
0,
],
[
"98.58579",
"0.09250",
],
],
"startBinding": {
"elementId": "id170",
"focus": "0.02000",
"gap": 1,
},
},
},
"id175" => Delta {
"deleted": {
"boundElements": [
{
"id": "id172",
"type": "arrow",
},
],
},
"inserted": {
"boundElements": [],
},
},
},
},
},
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {},
"inserted": {},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {},
"updated": Map {
"id170" => Delta {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id172",
"type": "arrow",
},
],
},
},
"id172" => Delta {
"deleted": {
"height": "102.45584",
"points": [
[
0,
0,
],
[
"102.79971",
"102.45584",
],
],
"startBinding": null,
"y": 0,
},
"inserted": {
"height": "70.33521",
"points": [
[
0,
0,
],
[
"100.78887",
"70.33521",
],
],
"startBinding": {
"elementId": "id170",
"focus": "0.02970",
"gap": 1,
},
"y": "35.20327",
},
},
},
},
},
],
"undoStack": [
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {},
"inserted": {},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {
"id170" => Delta {
"deleted": {
"angle": 0,
"backgroundColor": "transparent",
"boundElements": null,
"customData": undefined,
"fillStyle": "solid",
"frameId": null,
"groupIds": [],
"height": 100,
"index": "a0",
"isDeleted": false,
"link": null,
"locked": false,
"opacity": 100,
"roughness": 1,
"roundness": {
"type": 3,
},
"strokeColor": "#1e1e1e",
"strokeStyle": "solid",
"strokeWidth": 2,
"type": "rectangle",
"width": 100,
"x": -100,
"y": -50,
},
"inserted": {
"isDeleted": true,
},
},
"id171" => Delta {
"deleted": {
"angle": 0,
"backgroundColor": "transparent",
"boundElements": null,
"customData": undefined,
"fillStyle": "solid",
"frameId": null,
"groupIds": [],
"height": 100,
"index": "a1",
"isDeleted": false,
"link": null,
"locked": false,
"opacity": 100,
"roughness": 1,
"roundness": {
"type": 3,
},
"strokeColor": "#1e1e1e",
"strokeStyle": "solid",
"strokeWidth": 2,
"type": "rectangle",
"width": 100,
"x": 100,
"y": -50,
},
"inserted": {
"isDeleted": true,
},
},
},
"updated": Map {},
},
},
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {
"selectedElementIds": {
"id172": true,
},
"selectedLinearElementId": "id172",
},
"inserted": {
"selectedElementIds": {},
"selectedLinearElementId": null,
},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {
"id172" => Delta {
"deleted": {
"angle": 0,
"backgroundColor": "transparent",
"boundElements": null,
"customData": undefined,
"elbowed": false,
"endArrowhead": "arrow",
"endBinding": null,
"fillStyle": "solid",
"frameId": null,
"groupIds": [],
"height": 0,
"index": "a2",
"isDeleted": false,
"lastCommittedPoint": null,
"link": null,
"locked": false,
"opacity": 100,
"points": [
[
0,
0,
],
[
100,
0,
],
],
"roughness": 1,
"roundness": {
"type": 2,
},
"startArrowhead": null,
"startBinding": null,
"strokeColor": "#1e1e1e",
"strokeStyle": "solid",
"strokeWidth": 2,
"type": "arrow",
"width": 100,
"x": 0,
"y": 0,
},
"inserted": {
"isDeleted": true,
},
},
},
"updated": Map {},
},
},
],
}
`;
exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and the arrow got bound to a different element in the meantime > [end of test] number of elements 1`] = `4`; exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and the arrow got bound to a different element in the meantime > [end of test] number of elements 1`] = `4`;
exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and the arrow got bound to a different element in the meantime > [end of test] number of renders 1`] = `21`; exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and the arrow got bound to a different element in the meantime > [end of test] number of renders 1`] = `21`;
@ -603,22 +288,39 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"added": {}, "added": {},
"removed": {}, "removed": {},
"updated": { "updated": {
"id686": {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id689",
"type": "arrow",
},
],
},
},
"id689": { "id689": {
"deleted": { "deleted": {
"endBinding": { "endBinding": {
"elementId": "id686", "elementId": "id700",
"focus": "0.00990", "fixedPoint": [
"0.50000",
1,
],
"focus": 0,
"gap": 1, "gap": 1,
}, },
"height": "0.98586", "height": "70.45017",
"points": [ "points": [
[ [
0, 0,
0, 0,
], ],
[ [
"98.58579", "100.70774",
"-0.98586", "70.45017",
], ],
], ],
"startBinding": { "startBinding": {
@ -633,7 +335,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"focus": "-0.02000", "focus": "-0.02000",
"gap": 1, "gap": 1,
}, },
"height": "0.00000", "height": "0.09250",
"points": [ "points": [
[ [
0, 0,
@ -641,7 +343,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
], ],
[ [
"98.58579", "98.58579",
"0.00000", "0.09250",
], ],
], ],
"startBinding": { "startBinding": {
@ -651,6 +353,19 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
}, },
}, },
}, },
"id700": {
"deleted": {
"boundElements": [
{
"id": "id689",
"type": "arrow",
},
],
},
"inserted": {
"boundElements": [],
},
},
}, },
}, },
"id": "id707", "id": "id707",
@ -679,59 +394,32 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
], ],
}, },
}, },
"id686": {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id689",
"type": "arrow",
},
],
},
},
"id689": { "id689": {
"deleted": { "deleted": {
"endBinding": { "height": "102.45584",
"elementId": "id700",
"fixedPoint": [
"0.50000",
1,
],
"focus": 0,
"gap": 1,
},
"height": "102.35417",
"points": [ "points": [
[ [
0, 0,
0, 0,
], ],
[ [
"101.77517", "102.79971",
"102.35417", "102.45584",
], ],
], ],
"startBinding": null, "startBinding": null,
"y": 0, "y": 0,
}, },
"inserted": { "inserted": {
"endBinding": { "height": "70.33521",
"elementId": "id686",
"focus": "0.00990",
"gap": 1,
},
"height": "0.98586",
"points": [ "points": [
[ [
0, 0,
0, 0,
], ],
[ [
"98.58579", "100.78887",
"-0.98586", "70.33521",
], ],
], ],
"startBinding": { "startBinding": {
@ -739,20 +427,7 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"focus": "0.02970", "focus": "0.02970",
"gap": 1, "gap": 1,
}, },
"y": "0.99364", "y": "35.20327",
},
},
"id700": {
"deleted": {
"boundElements": [
{
"id": "id689",
"type": "arrow",
},
],
},
"inserted": {
"boundElements": [],
}, },
}, },
}, },
@ -1140,284 +815,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
} }
`; `;
exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and there are no conflicting updates in the meantime > [end of test] history 1`] = `
History {
"onHistoryChangedEmitter": Emitter {
"subscribers": [
[Function],
[Function],
],
},
"redoStack": [
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {},
"inserted": {},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {},
"updated": Map {
"id166" => Delta {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id167",
"type": "arrow",
},
],
},
},
"id167" => Delta {
"deleted": {
"endBinding": null,
"points": [
[
0,
0,
],
[
100,
0,
],
],
},
"inserted": {
"endBinding": {
"elementId": "id166",
"focus": -0,
"gap": 1,
},
"points": [
[
0,
0,
],
[
0,
0,
],
],
},
},
},
},
},
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {},
"inserted": {},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {},
"updated": Map {
"id165" => Delta {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id167",
"type": "arrow",
},
],
},
},
"id167" => Delta {
"deleted": {
"points": [
[
0,
0,
],
[
100,
0,
],
],
"startBinding": null,
},
"inserted": {
"points": [
[
0,
0,
],
[
100,
0,
],
],
"startBinding": {
"elementId": "id165",
"focus": 0,
"gap": 1,
},
},
},
},
},
},
],
"undoStack": [
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {},
"inserted": {},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {
"id165" => Delta {
"deleted": {
"angle": 0,
"backgroundColor": "transparent",
"boundElements": null,
"customData": undefined,
"fillStyle": "solid",
"frameId": null,
"groupIds": [],
"height": 100,
"index": "a0",
"isDeleted": false,
"link": null,
"locked": false,
"opacity": 100,
"roughness": 1,
"roundness": {
"type": 3,
},
"strokeColor": "#1e1e1e",
"strokeStyle": "solid",
"strokeWidth": 2,
"type": "rectangle",
"width": 100,
"x": -100,
"y": -50,
},
"inserted": {
"isDeleted": true,
},
},
"id166" => Delta {
"deleted": {
"angle": 0,
"backgroundColor": "transparent",
"boundElements": null,
"customData": undefined,
"fillStyle": "solid",
"frameId": null,
"groupIds": [],
"height": 100,
"index": "a1",
"isDeleted": false,
"link": null,
"locked": false,
"opacity": 100,
"roughness": 1,
"roundness": {
"type": 3,
},
"strokeColor": "#1e1e1e",
"strokeStyle": "solid",
"strokeWidth": 2,
"type": "rectangle",
"width": 100,
"x": 100,
"y": -50,
},
"inserted": {
"isDeleted": true,
},
},
},
"updated": Map {},
},
},
HistoryEntry {
"appStateChange": AppStateChange {
"delta": Delta {
"deleted": {
"selectedElementIds": {
"id167": true,
},
"selectedLinearElementId": "id167",
},
"inserted": {
"selectedElementIds": {},
"selectedLinearElementId": null,
},
},
},
"elementsChange": ElementsChange {
"added": Map {},
"removed": Map {
"id167" => Delta {
"deleted": {
"angle": 0,
"backgroundColor": "transparent",
"boundElements": null,
"customData": undefined,
"elbowed": false,
"endArrowhead": "arrow",
"endBinding": null,
"fillStyle": "solid",
"frameId": null,
"groupIds": [],
"height": 0,
"index": "a2",
"isDeleted": false,
"lastCommittedPoint": null,
"link": null,
"locked": false,
"opacity": 100,
"points": [
[
0,
0,
],
[
100,
0,
],
],
"roughness": 1,
"roundness": {
"type": 2,
},
"startArrowhead": null,
"startBinding": null,
"strokeColor": "#1e1e1e",
"strokeStyle": "solid",
"strokeWidth": 2,
"type": "arrow",
"width": 100,
"x": 0,
"y": 0,
},
"inserted": {
"isDeleted": true,
},
},
},
"updated": Map {},
},
},
],
}
`;
exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and there are no conflicting updates in the meantime > [end of test] number of elements 1`] = `3`; exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and there are no conflicting updates in the meantime > [end of test] number of elements 1`] = `3`;
exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and there are no conflicting updates in the meantime > [end of test] number of renders 1`] = `23`; exports[`history > multiplayer undo/redo > conflicts in arrows and their bindable elements > should rebind bindings when both are updated through the history and there are no conflicting updates in the meantime > [end of test] number of renders 1`] = `23`;
@ -1435,20 +832,22 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"added": {}, "added": {},
"removed": {}, "removed": {},
"updated": { "updated": {
"id666": { "id663": {
"deleted": { "deleted": {
"points": [ "boundElements": [],
[
0,
0,
],
[
0,
0,
],
],
}, },
"inserted": { "inserted": {
"boundElements": [
{
"id": "id666",
"type": "arrow",
},
],
},
},
"id666": {
"deleted": {
"endBinding": null,
"points": [ "points": [
[ [
0, 0,
@ -1460,6 +859,23 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
], ],
], ],
}, },
"inserted": {
"endBinding": {
"elementId": "id663",
"focus": -0,
"gap": 1,
},
"points": [
[
0,
0,
],
[
0,
0,
],
],
},
}, },
}, },
}, },
@ -1489,22 +905,8 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
], ],
}, },
}, },
"id663": {
"deleted": {
"boundElements": [],
},
"inserted": {
"boundElements": [
{
"id": "id666",
"type": "arrow",
},
],
},
},
"id666": { "id666": {
"deleted": { "deleted": {
"endBinding": null,
"points": [ "points": [
[ [
0, 0,
@ -1518,18 +920,13 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"startBinding": null, "startBinding": null,
}, },
"inserted": { "inserted": {
"endBinding": {
"elementId": "id663",
"focus": -0,
"gap": 1,
},
"points": [ "points": [
[ [
0, 0,
0, 0,
], ],
[ [
0, 100,
0, 0,
], ],
], ],