From df79ceae4eda9a304decd5bcdbff0de21a210aa8 Mon Sep 17 00:00:00 2001
From: Marcel Mraz <marcel@excalidraw.com>
Date: Wed, 30 Apr 2025 13:51:30 +0200
Subject: [PATCH] Review fixes

---
 packages/element/src/store.ts          | 4 ++--
 packages/excalidraw/components/App.tsx | 1 -
 packages/excalidraw/history.ts         | 4 +---
 packages/excalidraw/types.ts           | 1 -
 4 files changed, 3 insertions(+), 7 deletions(-)

diff --git a/packages/element/src/store.ts b/packages/element/src/store.ts
index c1c818a6b4..ffe9089715 100644
--- a/packages/element/src/store.ts
+++ b/packages/element/src/store.ts
@@ -529,11 +529,11 @@ export class StoreDelta {
     delta: StoreDelta,
     elements: SceneElementsMap,
     appState: AppState,
-    snapshot: StoreSnapshot = StoreSnapshot.empty(),
+    prevSnapshot: StoreSnapshot = StoreSnapshot.empty(),
   ): [SceneElementsMap, AppState, boolean] {
     const [nextElements, elementsContainVisibleChange] = delta.elements.applyTo(
       elements,
-      snapshot.elements,
+      prevSnapshot.elements,
     );
 
     const [nextAppState, appStateContainsVisibleChange] =
diff --git a/packages/excalidraw/components/App.tsx b/packages/excalidraw/components/App.tsx
index 05339072d6..9dc8b71082 100644
--- a/packages/excalidraw/components/App.tsx
+++ b/packages/excalidraw/components/App.tsx
@@ -778,7 +778,6 @@ class App extends React.Component<AppProps, AppState> {
         addFiles: this.addFiles,
         resetScene: this.resetScene,
         getSceneElementsIncludingDeleted: this.getSceneElementsIncludingDeleted,
-        store: this.store,
         history: {
           clear: this.resetHistory,
         },
diff --git a/packages/excalidraw/history.ts b/packages/excalidraw/history.ts
index f559602860..7e8f5628a4 100644
--- a/packages/excalidraw/history.ts
+++ b/packages/excalidraw/history.ts
@@ -106,7 +106,6 @@ export class History {
       // iterate through the history entries in case they result in no visible changes
       while (historyEntry) {
         try {
-          // creating iteration-scoped variables, so that we can use them in the unstable_scheduleCallback
           [nextElements, nextAppState, containsVisibleChange] =
             StoreDelta.applyTo(
               historyEntry,
@@ -120,8 +119,7 @@ export class History {
             CaptureUpdateAction.IMMEDIATELY,
             nextElements,
             nextAppState,
-            // create a new instance of the history entry, so that it's not mutated in the meantime
-            HistoryEntry.restore(historyEntry),
+            historyEntry,
           );
         } finally {
           // make sure to always push, even if the delta is corrupted
diff --git a/packages/excalidraw/types.ts b/packages/excalidraw/types.ts
index 5a2e2d483f..146906d503 100644
--- a/packages/excalidraw/types.ts
+++ b/packages/excalidraw/types.ts
@@ -800,7 +800,6 @@ export interface ExcalidrawImperativeAPI {
   history: {
     clear: InstanceType<typeof App>["resetHistory"];
   };
-  store: InstanceType<typeof App>["store"];
   getSceneElements: InstanceType<typeof App>["getSceneElements"];
   getAppState: () => InstanceType<typeof App>["state"];
   getFiles: () => InstanceType<typeof App>["files"];