smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add NonDeleted<ExcalidrawElement> (#1068)

Browse source 
* add NonDeleted

* make test:all script run tests without prompt

* rename helper

* replace with helper

* make element contructors return nonDeleted elements

* cache filtered elements where appliacable for better perf

* rename manager element getter

* remove unnecessary assertion

* fix test

* make element types in resizeElement into nonDeleted

Co-authored-by: dwelle <luzar.david@gmail.com>
This commit is contained in:
Pete Hunt 2020-04-08 09:49:52 -07:00 • committed by GitHub
parent c714c778ab
commit df0613d8ac
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
29 changed files with 260 additions and 189 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/actions/actionDeleteSelected.tsx
View file

@ -5,6 +5,7 @@ import React from "react";
import { trash } from "../components/icons";
import { t } from "../i18n";
import { register } from "./register";
import { getNonDeletedElements } from "../element";
export const actionDeleteSelected = register({
name: "deleteSelectedElements",
@ -20,7 +21,10 @@ export const actionDeleteSelected = register({
elementType: "selection",
multiElement: null,
},
commitToHistory: isSomeElementSelected(elements, appState),
commitToHistory: isSomeElementSelected(
getNonDeletedElements(elements),
appState,
),
};
},
contextItemLabel: "labels.delete",
@ -33,7 +37,7 @@ export const actionDeleteSelected = register({
title={t("labels.delete")}
aria-label={t("labels.delete")}
onClick={() => updateData(null)}
visible={isSomeElementSelected(elements, appState)}
visible={isSomeElementSelected(getNonDeletedElements(elements), appState)}
/>
),
});