smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: make canvas compos memoize appState on props they declare (#6897)

Browse source
This commit is contained in:
David Luzar 2023-08-17 13:39:15 +02:00 • committed by GitHub
parent 1bd416002c
commit d140d1b8b3
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
12 changed files with 133 additions and 130 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/components/canvases/InteractiveCanvas.tsx
View file

@ -166,7 +166,7 @@ const InteractiveCanvas = (props: InteractiveCanvasProps) => {
const getRelevantAppStateProps = (
appState: AppState,
): Omit<InteractiveCanvasAppState, "editingElement"> => ({
): InteractiveCanvasAppState => ({
zoom: appState.zoom,
scrollX: appState.scrollX,
scrollY: appState.scrollY,

11
src/components/canvases/StaticCanvas.tsx
View file

@ -61,13 +61,7 @@ const StaticCanvas = (props: StaticCanvasProps) => {
const getRelevantAppStateProps = (
appState: AppState,
): Omit<
StaticCanvasAppState,
| "editingElement"
| "selectedElementIds"
| "editingGroupId"
| "frameToHighlight"
> => ({
): StaticCanvasAppState => ({
zoom: appState.zoom,
scrollX: appState.scrollX,
scrollY: appState.scrollY,
@ -84,6 +78,9 @@ const getRelevantAppStateProps = (
selectedElementsAreBeingDragged: appState.selectedElementsAreBeingDragged,
gridSize: appState.gridSize,
frameRendering: appState.frameRendering,
selectedElementIds: appState.selectedElementIds,
frameToHighlight: appState.frameToHighlight,
editingGroupId: appState.editingGroupId,
});
const areEqual = (