smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: select instead of focus search input (#8483)

Browse source
This commit is contained in:
David Luzar 2024-09-09 19:57:22 +02:00 • committed by GitHub
parent 6959a363f0
commit d107215564
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 17 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

7
packages/excalidraw/tests/helpers/api.ts
View file

@ -76,11 +76,12 @@ export class API {
});
};
static updateElement = (
...[element, updates]: Parameters<typeof mutateElement>
// eslint-disable-next-line prettier/prettier
static updateElement = <T extends ExcalidrawElement>(
...args: Parameters<typeof mutateElement<T>>
) => {
act(() => {
mutateElement(element, updates);
mutateElement<T>(...args);
});
};

12
packages/excalidraw/tests/search.test.tsx
View file

@ -1,6 +1,6 @@
import React from "react";
import { render, waitFor } from "./test-utils";
import { Excalidraw, mutateElement } from "../index";
import { act, render, waitFor } from "./test-utils";
import { Excalidraw } from "../index";
import { CLASSES, SEARCH_SIDEBAR } from "../constants";
import { Keyboard } from "./helpers/ui";
import { KEYS } from "../keys";
@ -22,7 +22,7 @@ const querySearchInput = async () => {
describe("search", () => {
beforeEach(async () => {
await render(<Excalidraw handleKeyboardGlobally />);
h.setState({
API.setAppState({
openSidebar: null,
});
});
@ -50,7 +50,9 @@ describe("search", () => {
`.${CLASSES.SEARCH_MENU_INPUT_WRAPPER} input`,
);
searchInput?.blur();
act(() => {
searchInput?.blur();
});
expect(h.app.state.openSidebar).not.toBeNull();
expect(searchInput?.matches(":focus")).toBe(false);
@ -109,7 +111,7 @@ describe("search", () => {
}),
]);
mutateElement(h.elements[0] as ExcalidrawTextElement, {
API.updateElement(h.elements[0] as ExcalidrawTextElement, {
text: "t\ne\ns\nt \nt\ne\nx\nt \ns\np\nli\nt \ni\nn\nt\no\nm\nu\nlt\ni\np\nl\ne \nli\nn\ne\ns",
originalText: "test text split into multiple lines",
});