smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: Calculate width/height of canvas based on container dimensions (".excalidraw" selector) & remove props width & height (#3379)

Browse source 
* Remove width/height from the ".excalidraw" container so it will sized automatically.
* updated all ref calculation to ".excalidraw" instead of parent since now ".excalidraw" will get resized
* Remove props width/height as its not needed anymore.
* Resize handler is also not needed anymore.
* Position absolute canvas due to #3379 (comment)

* move css to style and remove one extra rerendering

* factor out mock logic for test

* set height, width so as to avoid unnecessary updates of regression snap

* better mock

* better type checking and omit width,height from getDefaultAppState and also restore

* revert

* default to window dimensions in constructor

* update docs

* update

* update

* tweaks
This commit is contained in:
Aakansha Doshi 2021-04-04 15:05:16 +05:30 • committed by GitHub
parent 3b976613ba
commit c54a099010
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
24 changed files with 243 additions and 258 deletions
Download patch file Download diff file Expand all files Collapse all files

20
src/tests/__snapshots__/selection.test.tsx.snap
View file

@ -36,8 +36,8 @@ Object {
"version": 3,
"versionNonce": 449462985,
"width": 30,
"x": 30,
"y": 20,
"x": 10,
"y": 10,
}
`;
@ -77,8 +77,8 @@ Object {
"version": 3,
"versionNonce": 449462985,
"width": 30,
"x": 30,
"y": 20,
"x": 10,
"y": 10,
}
`;
@ -103,8 +103,8 @@ Object {
"version": 2,
"versionNonce": 1278240551,
"width": 30,
"x": 30,
"y": 20,
"x": 10,
"y": 10,
}
`;
@ -129,8 +129,8 @@ Object {
"version": 2,
"versionNonce": 1278240551,
"width": 30,
"x": 30,
"y": 20,
"x": 10,
"y": 10,
}
`;
@ -155,7 +155,7 @@ Object {
"version": 2,
"versionNonce": 1278240551,
"width": 30,
"x": 30,
"y": 20,
"x": 10,
"y": 10,
}
`;