smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: Incorrect point offsetting in LinearElementEditor.movePoints() (#8145)

Browse source 
The LinearElementEditor.movePoints() function incorrectly calculates the offset for local linear element points when multiple targetPoints are provided, one of those target points is index === 0 AND the other points are moved in the negative direction, and ending up with negative local coordinates.

Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
This commit is contained in:
Márk Tolmács 2024-06-28 12:23:10 +02:00 • committed by GitHub
parent 744b3e5d09
commit ba8c09d529
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 37 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

7
packages/excalidraw/element/linearElementEditor.ts
View file

@ -1165,7 +1165,7 @@ export class LinearElementEditor {
const nextPoints = points.map((point, idx) => {
const selectedPointData = targetPoints.find((p) => p.index === idx);
if (selectedPointData) {
if (selectedOriginPoint) {
if (selectedPointData.index === 0) {
return point;
}
@ -1174,7 +1174,10 @@ export class LinearElementEditor {
const deltaY =
selectedPointData.point[1] - points[selectedPointData.index][1];
return [point[0] + deltaX, point[1] + deltaY] as const;
return [
point[0] + deltaX - offsetX,
point[1] + deltaY - offsetY,
] as const;
}
return offsetX || offsetY
? ([point[0] - offsetX, point[1] - offsetY] as const)