smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

add a tiny threshold for checks

Browse source
This commit is contained in:
Ryan Di 2025-02-28 15:41:35 +11:00
parent 0d5091555c
commit ba7e3439f4
2 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

3
packages/excalidraw/lasso/worker.ts
View file

@ -166,7 +166,8 @@ const intersectionTest = (
return lassoSegments.some((lassoSegment) => return lassoSegments.some((lassoSegment) =>
elementSegments.some( elementSegments.some(
(elementSegment) => (elementSegment) =>
lineSegmentIntersectionPoints(lassoSegment, elementSegment) !== null, // introduce a bit of tolerance to account for roughness and simplification of paths
lineSegmentIntersectionPoints(lassoSegment, elementSegment, 1) !== null,
), ),
); );
}; };

10
packages/math/segment.ts
View file

@ -159,13 +159,17 @@ export const distanceToLineSegment = <Point extends LocalPoint | GlobalPoint>(
*/ */
export function lineSegmentIntersectionPoints< export function lineSegmentIntersectionPoints<
Point extends GlobalPoint | LocalPoint, Point extends GlobalPoint | LocalPoint,
>(l: LineSegment<Point>, s: LineSegment<Point>): Point | null { >(
l: LineSegment<Point>,
s: LineSegment<Point>,
threshold?: number,
): Point | null {
const candidate = linesIntersectAt(line(l[0], l[1]), line(s[0], s[1])); const candidate = linesIntersectAt(line(l[0], l[1]), line(s[0], s[1]));
if ( if (
!candidate || !candidate ||
!pointOnLineSegment(candidate, s) || !pointOnLineSegment(candidate, s, threshold) ||
!pointOnLineSegment(candidate, l) !pointOnLineSegment(candidate, l, threshold)
) { ) {
return null; return null;
} }