smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: addFiles clears the whole image cache when each file is added - regression from #8471 (#8490)

Browse source 
Update App.tsx
This commit is contained in:
zsviczian 2024-09-11 07:57:41 +02:00 • committed by GitHub
parent 72b7c937b1
commit b46ca0192b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
packages/excalidraw/components/App.tsx
View file

@ -2367,9 +2367,10 @@ class App extends React.Component<AppProps, AppState> {
return false; return false;
}; };
private clearImageShapeCache() { private clearImageShapeCache(filesMap?: BinaryFiles) {
const files = filesMap ?? this.files;
this.scene.getNonDeletedElements().forEach((element) => { this.scene.getNonDeletedElements().forEach((element) => {
if (isInitializedImageElement(element) && this.files[element.fileId]) { if (isInitializedImageElement(element) && files[element.fileId]) {
this.imageCache.delete(element.fileId); this.imageCache.delete(element.fileId);
ShapeCache.delete(element); ShapeCache.delete(element);
} }
@ -3690,7 +3691,7 @@ class App extends React.Component<AppProps, AppState> {
this.files = { ...this.files, ...Object.fromEntries(filesMap) }; this.files = { ...this.files, ...Object.fromEntries(filesMap) };
this.clearImageShapeCache(); this.clearImageShapeCache(Object.fromEntries(filesMap));
this.scene.triggerUpdate(); this.scene.triggerUpdate();
this.addNewImagesToImageCache(); this.addNewImagesToImageCache();