smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Duplication text binding fixes

Browse source
This commit is contained in:
Mark Tolmacs 2025-03-14 17:22:08 +01:00
parent 430a5d80bb
commit a624787244
2 changed files with 17 additions and 98 deletions
Download patch file Download diff file Expand all files Collapse all files

103
packages/excalidraw/actions/actionDuplicateSelection.tsx
View file

@ -105,7 +105,17 @@ export const actionDuplicateSelection = register({
}
nextElements = syncMovedIndices(nextElements, arrayToMap(clonedElements));
// clonedElements
// .filter((e) => e.type === "text")
// .forEach((e) => {
// console.log(JSON.stringify(e.boundElements));
// });
// console.log("----");
// nextElements
// .filter((e) => e.type === "text")
// .forEach((e) => {
// console.log(JSON.stringify(e.boundElements));
// });
const nextElementsToSelect =
excludeElementsInFramesFromSelection(clonedElements);
@ -373,97 +383,6 @@ const _duplicateElements = (
// oldIdToDuplicatedId,
// );
// newElements
// .map((element) => {
// oldElements.includes(element) && console.error("oldElements", element);
// if (isArrowElement(element)) {
// const updates: Mutable<ElementUpdate<ExcalidrawArrowElement>> = {};
// if (element.startBinding) {
// const startCloneElementId = oldIdToDuplicatedId.get(
// element.startBinding.elementId,
// );
// if (startCloneElementId) {
// // The connected element was duplicated, so we need to update the binding
// updates.startBinding = {
// ...element.startBinding,
// elementId: startCloneElementId,
// };
// } else {
// // The connected element was not duplicated, so we need to remove the binding
// updates.startBinding = null;
// }
// }
// if (element.endBinding) {
// const endCloneElementId = oldIdToDuplicatedId.get(
// element.endBinding.elementId,
// );
// if (endCloneElementId) {
// // The connected element was duplicated, so we need to update the binding
// updates.endBinding = {
// ...element.endBinding,
// elementId: endCloneElementId,
// };
// } else {
// // The connected element was not duplicated, so we need to remove the binding
// updates.endBinding = null;
// }
// }
// if (Object.keys(updates).length > 0) {
// // Only update the element if there are updates to apply
// return {
// element,
// updates,
// };
// }
// } else if (isBindableElement(element)) {
// if (element.boundElements?.length) {
// const clonedBoundElements = element.boundElements
// ?.map((definition) => {
// const clonedBoundElementId = oldIdToDuplicatedId.get(
// definition.id,
// );
// if (clonedBoundElementId) {
// // The connected element was duplicated, so we need to update the binding
// return {
// ...definition,
// id: clonedBoundElementId,
// };
// }
// // The connected element was not duplicated, so we need to remove the binding
// return null;
// })
// .filter(
// (definition): definition is BoundElement => definition !== null,
// );
// if (clonedBoundElements?.length) {
// return {
// element,
// updates: {
// boundElements: clonedBoundElements,
// },
// };
// }
// }
// }
// return null;
// })
// .forEach((change) => {
// if (!change) {
// return;
// }
// mutateElement(change.element, change.updates);
// });
bindElementsToFramesAfterDuplication(
elementsWithClones,
oldElements,

12
packages/excalidraw/element/duplicate.ts
View file

@ -314,12 +314,6 @@ export const duplicateElements = (
// ---------------------------------------------------------------------------
bindTextToShapeAfterDuplication(
elementsWithClones,
oldElements,
oldIdToDuplicatedId,
);
const fixBindingsAfterDuplication = (
newElements: Mutable<ExcalidrawElement>[],
oldIdToDuplicatedId: Map<ExcalidrawElement["id"], ExcalidrawElement["id"]>,
@ -385,6 +379,12 @@ export const duplicateElements = (
duplicatedElementsMap as NonDeletedSceneElementsMap,
);
bindTextToShapeAfterDuplication(
elementsWithClones,
oldElements,
oldIdToDuplicatedId,
);
bindElementsToFramesAfterDuplication(
elementsWithClones,
oldElements,