remove appState.renderScrollbars

This commit is contained in:
dwelle 2025-04-19 23:44:21 +02:00
parent dbc20cd690
commit a316bd606a
8 changed files with 7 additions and 146 deletions

View file

@ -81,7 +81,6 @@ export const getDefaultAppState = (): Omit<
openDialog: null,
pasteDialog: { shown: false, data: null },
previousSelectedElementIds: {},
renderScrollbars: false,
resizingElement: null,
scrolledOutside: false,
scrollX: 0,
@ -209,7 +208,6 @@ const APP_STATE_STORAGE_CONF = (<
openDialog: { browser: false, export: false, server: false },
pasteDialog: { browser: false, export: false, server: false },
previousSelectedElementIds: { browser: true, export: false, server: false },
renderScrollbars: { browser: true, export: false, server: false },
resizingElement: { browser: false, export: false, server: false },
scrolledOutside: { browser: true, export: false, server: false },
scrollX: { browser: true, export: false, server: false },

View file

@ -733,7 +733,6 @@ class App extends React.Component<AppProps, AppState> {
...this.getCanvasOffsets(),
viewModeEnabled,
zenModeEnabled,
renderScrollbars,
objectsSnapModeEnabled,
gridModeEnabled: gridModeEnabled ?? defaultAppState.gridModeEnabled,
name,
@ -1832,6 +1831,9 @@ class App extends React.Component<AppProps, AppState> {
}
scale={window.devicePixelRatio}
appState={this.state}
renderScrollbars={
this.props.renderScrollbars === true
}
device={this.device}
renderInteractiveSceneCallback={
this.renderInteractiveSceneCallback
@ -2209,7 +2211,6 @@ class App extends React.Component<AppProps, AppState> {
if (actionResult.appState || editingTextElement || this.state.contextMenu) {
let viewModeEnabled = actionResult?.appState?.viewModeEnabled || false;
let zenModeEnabled = actionResult?.appState?.zenModeEnabled || false;
let renderScrollbars = actionResult?.appState?.renderScrollbars || false;
const theme =
actionResult?.appState?.theme || this.props.theme || THEME.LIGHT;
const name = actionResult?.appState?.name ?? this.state.name;
@ -2223,10 +2224,6 @@ class App extends React.Component<AppProps, AppState> {
zenModeEnabled = this.props.zenModeEnabled;
}
if (typeof this.props.renderScrollbars !== "undefined") {
renderScrollbars = this.props.renderScrollbars;
}
editingTextElement = actionResult.appState?.editingTextElement || null;
// make sure editingTextElement points to latest element reference
@ -2260,7 +2257,6 @@ class App extends React.Component<AppProps, AppState> {
editingTextElement,
viewModeEnabled,
zenModeEnabled,
renderScrollbars,
theme,
name,
errorMessage,
@ -2872,10 +2868,6 @@ class App extends React.Component<AppProps, AppState> {
this.setState({ theme: this.props.theme });
}
if (prevProps.renderScrollbars !== this.props.renderScrollbars) {
this.setState({ renderScrollbars: !!this.props.renderScrollbars });
}
this.excalidrawContainerRef.current?.classList.toggle(
"theme--dark",
this.state.theme === THEME.DARK,

View file

@ -34,6 +34,7 @@ type InteractiveCanvasProps = {
selectionNonce: number | undefined;
scale: number;
appState: InteractiveCanvasAppState;
renderScrollbars: boolean;
device: Device;
renderInteractiveSceneCallback: (
data: RenderInteractiveSceneCallback,
@ -143,7 +144,7 @@ const InteractiveCanvas = (props: InteractiveCanvasProps) => {
remotePointerUsernames,
remotePointerUserStates,
selectionColor,
renderScrollbars: props.appState.renderScrollbars,
renderScrollbars: props.renderScrollbars,
},
device: props.device,
callback: props.renderInteractiveSceneCallback,
@ -214,7 +215,6 @@ const getRelevantAppStateProps = (
isCropping: appState.isCropping,
croppingElementId: appState.croppingElementId,
searchMatches: appState.searchMatches,
renderScrollbars: appState.renderScrollbars,
});
const areEqual = (
@ -231,7 +231,8 @@ const areEqual = (
// on appState)
prevProps.elementsMap !== nextProps.elementsMap ||
prevProps.visibleElements !== nextProps.visibleElements ||
prevProps.selectedElements !== nextProps.selectedElements
prevProps.selectedElements !== nextProps.selectedElements ||
prevProps.renderScrollbars !== nextProps.renderScrollbars
) {
return false;
}

View file

@ -957,7 +957,6 @@ exports[`contextMenu element > right-clicking on a group should select whole gro
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1165,7 +1164,6 @@ exports[`contextMenu element > selecting 'Add to library' in context menu adds e
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1386,7 +1384,6 @@ exports[`contextMenu element > selecting 'Bring forward' in context menu brings
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1722,7 +1719,6 @@ exports[`contextMenu element > selecting 'Bring to front' in context menu brings
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2058,7 +2054,6 @@ exports[`contextMenu element > selecting 'Copy styles' in context menu copies st
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2279,7 +2274,6 @@ exports[`contextMenu element > selecting 'Delete' in context menu deletes elemen
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2524,7 +2518,6 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2832,7 +2825,6 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group
"previousSelectedElementIds": {
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3204,7 +3196,6 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3684,7 +3675,6 @@ exports[`contextMenu element > selecting 'Send backward' in context menu sends e
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4012,7 +4002,6 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4342,7 +4331,6 @@ exports[`contextMenu element > selecting 'Ungroup selection' in context menu ung
"previousSelectedElementIds": {
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5624,7 +5612,6 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -6847,7 +6834,6 @@ exports[`contextMenu element > shows 'Ungroup selection' in context menu for gro
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7784,7 +7770,6 @@ exports[`contextMenu element > shows context menu for canvas > [end of test] app
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8789,7 +8774,6 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9782,7 +9766,6 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,

View file

@ -81,7 +81,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"previousSelectedElementIds": {
"id172": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -682,7 +681,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"previousSelectedElementIds": {
"id167": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1192,7 +1190,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1565,7 +1562,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1939,7 +1935,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2208,7 +2203,6 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2652,7 +2646,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2956,7 +2949,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3245,7 +3237,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3544,7 +3535,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3835,7 +3825,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4075,7 +4064,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4339,7 +4327,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4617,7 +4604,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4853,7 +4839,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5089,7 +5074,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5323,7 +5307,6 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5557,7 +5540,6 @@ exports[`history > multiplayer undo/redo > conflicts in frames and their childre
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5820,7 +5802,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"previousSelectedElementIds": {
"id116": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -6156,7 +6137,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"previousSelectedElementIds": {
"id103": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -6586,7 +6566,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"previousSelectedElementIds": {
"id106": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -6970,7 +6949,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7291,7 +7269,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7594,7 +7571,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7828,7 +7804,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8188,7 +8163,6 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8551,7 +8525,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
"id133": true,
"id134": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8957,7 +8930,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9249,7 +9221,6 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9519,7 +9490,6 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9788,7 +9758,6 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10027,7 +9996,6 @@ exports[`history > multiplayer undo/redo > should override remotely added groups
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10330,7 +10298,6 @@ exports[`history > multiplayer undo/redo > should override remotely added points
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10675,7 +10642,6 @@ exports[`history > multiplayer undo/redo > should redistribute deltas when eleme
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10918,7 +10884,6 @@ exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end o
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -11369,7 +11334,6 @@ exports[`history > multiplayer undo/redo > should update history entries after r
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -11628,7 +11592,6 @@ exports[`history > singleplayer undo/redo > remounting undo/redo buttons should
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -11872,7 +11835,6 @@ exports[`history > singleplayer undo/redo > should clear the redo stack on eleme
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -12118,7 +12080,6 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -12527,7 +12488,6 @@ exports[`history > singleplayer undo/redo > should create new history entry on s
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": -50,
"scrollY": -50,
@ -12776,7 +12736,6 @@ exports[`history > singleplayer undo/redo > should disable undo/redo buttons whe
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -13022,7 +12981,6 @@ exports[`history > singleplayer undo/redo > should end up with no history entry
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -13270,7 +13228,6 @@ exports[`history > singleplayer undo/redo > should iterate through the history w
"previousSelectedElementIds": {
"id15": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -13520,7 +13477,6 @@ exports[`history > singleplayer undo/redo > should not clear the redo stack on s
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -13860,7 +13816,6 @@ exports[`history > singleplayer undo/redo > should not collapse when applying co
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14034,7 +13989,6 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14330,7 +14284,6 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14601,7 +14554,6 @@ exports[`history > singleplayer undo/redo > should not override appstate changes
"previousSelectedElementIds": {
"id11": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14882,7 +14834,6 @@ exports[`history > singleplayer undo/redo > should support appstate name or view
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -15047,7 +14998,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"previousSelectedElementIds": {
"id56": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -15746,7 +15696,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"previousSelectedElementIds": {
"id50": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -16367,7 +16316,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"previousSelectedElementIds": {
"id62": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -16986,7 +16934,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -17700,7 +17647,6 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"previousSelectedElementIds": {
"id75": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -18449,7 +18395,6 @@ exports[`history > singleplayer undo/redo > should support changes in elements'
"previousSelectedElementIds": {
"id45": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -18928,7 +18873,6 @@ exports[`history > singleplayer undo/redo > should support duplication of groups
"previousSelectedElementIds": {
"id36": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -19455,7 +19399,6 @@ exports[`history > singleplayer undo/redo > should support element creation, del
"previousSelectedElementIds": {
"id23": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -19916,7 +19859,6 @@ exports[`history > singleplayer undo/redo > should support linear element creati
"previousSelectedElementIds": {
"id27": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,

View file

@ -84,7 +84,6 @@ exports[`given element A and group of elements B and given both are selected whe
"id1": true,
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -501,7 +500,6 @@ exports[`given element A and group of elements B and given both are selected whe
"id1": true,
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -905,7 +903,6 @@ exports[`regression tests > Cmd/Ctrl-click exclusively select element under poin
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1452,7 +1449,6 @@ exports[`regression tests > Drags selected element when hitting only bounding bo
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -1660,7 +1656,6 @@ exports[`regression tests > adjusts z order when grouping > [end of test] appSta
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2037,7 +2032,6 @@ exports[`regression tests > alt-drag duplicates an element > [end of test] appSt
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2272,7 +2266,6 @@ exports[`regression tests > arrow keys > [end of test] appState 1`] = `
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2456,7 +2449,6 @@ exports[`regression tests > can drag element that covers another element, while
"previousSelectedElementIds": {
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -2776,7 +2768,6 @@ exports[`regression tests > change the properties of a shape > [end of test] app
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3026,7 +3017,6 @@ exports[`regression tests > click on an element and drag it > [dragged] appState
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3271,7 +3261,6 @@ exports[`regression tests > click on an element and drag it > [end of test] appS
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3503,7 +3492,6 @@ exports[`regression tests > click to select a shape > [end of test] appState 1`]
"previousSelectedElementIds": {
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -3761,7 +3749,6 @@ exports[`regression tests > click-drag to select a group > [end of test] appStat
"previousSelectedElementIds": {
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4072,7 +4059,6 @@ exports[`regression tests > deleting last but one element in editing group shoul
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4499,7 +4485,6 @@ exports[`regression tests > deselects group of selected elements on pointer down
"id0": true,
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -4784,7 +4769,6 @@ exports[`regression tests > deselects group of selected elements on pointer up w
"id0": true,
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5038,7 +5022,6 @@ exports[`regression tests > deselects selected element on pointer down when poin
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5250,7 +5233,6 @@ exports[`regression tests > deselects selected element, on pointer up, when clic
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5449,7 +5431,6 @@ exports[`regression tests > double click to edit a group > [end of test] appStat
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -5836,7 +5817,6 @@ exports[`regression tests > drags selected elements from point inside common bou
"id0": true,
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -6125,7 +6105,6 @@ exports[`regression tests > draw every type of shape > [end of test] appState 1`
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -6938,7 +6917,6 @@ exports[`regression tests > given a group of selected elements with an element t
"id0": true,
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7269,7 +7247,6 @@ exports[`regression tests > given a selected element A and a not selected elemen
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7547,7 +7524,6 @@ exports[`regression tests > given selected element A with lower z-index than uns
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -7783,7 +7759,6 @@ exports[`regression tests > given selected element A with lower z-index than uns
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8020,7 +7995,6 @@ exports[`regression tests > key 2 selects rectangle tool > [end of test] appStat
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8202,7 +8176,6 @@ exports[`regression tests > key 3 selects diamond tool > [end of test] appState
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8384,7 +8357,6 @@ exports[`regression tests > key 4 selects ellipse tool > [end of test] appState
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8566,7 +8538,6 @@ exports[`regression tests > key 5 selects arrow tool > [end of test] appState 1`
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -8791,7 +8762,6 @@ exports[`regression tests > key 6 selects line tool > [end of test] appState 1`]
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9015,7 +8985,6 @@ exports[`regression tests > key 7 selects freedraw tool > [end of test] appState
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9211,7 +9180,6 @@ exports[`regression tests > key a selects arrow tool > [end of test] appState 1`
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9436,7 +9404,6 @@ exports[`regression tests > key d selects diamond tool > [end of test] appState
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9618,7 +9585,6 @@ exports[`regression tests > key l selects line tool > [end of test] appState 1`]
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -9842,7 +9808,6 @@ exports[`regression tests > key o selects ellipse tool > [end of test] appState
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10024,7 +9989,6 @@ exports[`regression tests > key p selects freedraw tool > [end of test] appState
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10220,7 +10184,6 @@ exports[`regression tests > key r selects rectangle tool > [end of test] appStat
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10406,7 +10369,6 @@ exports[`regression tests > make a group and duplicate it > [end of test] appSta
"id1": true,
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -10901,7 +10863,6 @@ exports[`regression tests > noop interaction after undo shouldn't create history
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -11178,7 +11139,6 @@ exports[`regression tests > pinch-to-zoom works > [end of test] appState 1`] = `
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": "-6.25000",
"scrollY": 0,
@ -11308,7 +11268,6 @@ exports[`regression tests > shift click on selected element should deselect it o
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -11510,7 +11469,6 @@ exports[`regression tests > shift-click to multiselect, then drag > [end of test
"id0": true,
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -11824,7 +11782,6 @@ exports[`regression tests > should group elements and ungroup them > [end of tes
"id1": true,
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -12239,7 +12196,6 @@ exports[`regression tests > single-clicking on a subgroup of a selected group sh
"id5": true,
"id6": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -12852,7 +12808,6 @@ exports[`regression tests > spacebar + drag scrolls the canvas > [end of test] a
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 60,
"scrollY": 60,
@ -12982,7 +12937,6 @@ exports[`regression tests > supports nested groups > [end of test] appState 1`]
"previousSelectedElementIds": {
"id0": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -13569,7 +13523,6 @@ exports[`regression tests > switches from group of selected elements to another
"id1": true,
"id2": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -13908,7 +13861,6 @@ exports[`regression tests > switches selected element on pointer down > [end of
"previousSelectedElementIds": {
"id1": true,
},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14173,7 +14125,6 @@ exports[`regression tests > two-finger scroll works > [end of test] appState 1`]
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 20,
"scrollY": "-18.53553",
@ -14301,7 +14252,6 @@ exports[`regression tests > undo/redo drawing an element > [end of test] appStat
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14682,7 +14632,6 @@ exports[`regression tests > updates fontSize & fontFamily appState > [end of tes
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,
@ -14813,7 +14762,6 @@ exports[`regression tests > zoom hotkeys > [end of test] appState 1`] = `
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,

View file

@ -230,7 +230,6 @@ export type InteractiveCanvasAppState = Readonly<
croppingElementId: AppState["croppingElementId"];
// Search matches
searchMatches: AppState["searchMatches"];
renderScrollbars: AppState["renderScrollbars"];
}
>;
@ -429,7 +428,6 @@ export interface AppState {
croppingElementId: ExcalidrawElement["id"] | null;
searchMatches: readonly SearchMatch[];
renderScrollbars: boolean;
}
type SearchMatch = {

View file

@ -81,7 +81,6 @@ exports[`exportToSvg > with default arguments 1`] = `
"penMode": false,
"pendingImageElementId": null,
"previousSelectedElementIds": {},
"renderScrollbars": false,
"resizingElement": null,
"scrollX": 0,
"scrollY": 0,