From 9a6330bad976c80946431feeda69a99f389e89e8 Mon Sep 17 00:00:00 2001 From: Ryan Di Date: Mon, 7 Apr 2025 23:49:37 +1000 Subject: [PATCH] fix incorrect closing of path --- packages/excalidraw/lasso/utils.ts | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/packages/excalidraw/lasso/utils.ts b/packages/excalidraw/lasso/utils.ts index b04e66db9..7f9d18996 100644 --- a/packages/excalidraw/lasso/utils.ts +++ b/packages/excalidraw/lasso/utils.ts @@ -35,8 +35,6 @@ export const getLassoSelectedElementIds = (input: { if (simplifyDistance) { path = simplify(lassoPath, simplifyDistance) as GlobalPoint[]; } - // close the path to form a polygon for enclosure check - const closedPath = polygonFromPoints(path); // as the path might not enclose a shape anymore, clear before checking enclosedElements.clear(); for (const element of elements) { @@ -44,15 +42,11 @@ export const getLassoSelectedElementIds = (input: { !intersectedElements.has(element.id) && !enclosedElements.has(element.id) ) { - const enclosed = enclosureTest(closedPath, element, elementsSegments); + const enclosed = enclosureTest(path, element, elementsSegments); if (enclosed) { enclosedElements.add(element.id); } else { - const intersects = intersectionTest( - closedPath, - element, - elementsSegments, - ); + const intersects = intersectionTest(path, element, elementsSegments); if (intersects) { intersectedElements.add(element.id); }