From 8e76ba8237b6126c5d3beeb152540afd7bbea89a Mon Sep 17 00:00:00 2001 From: Clarence Chan Date: Wed, 14 Aug 2024 16:47:20 -0400 Subject: [PATCH] fix: cross-group selection incorrectly allowed in specific cases --- packages/excalidraw/components/App.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/excalidraw/components/App.tsx b/packages/excalidraw/components/App.tsx index 4cbac0888..58e2447b7 100644 --- a/packages/excalidraw/components/App.tsx +++ b/packages/excalidraw/components/App.tsx @@ -6845,8 +6845,9 @@ class App extends React.Component { // With shift-selection, we want to make sure that frames and their containing // elements are not selected at the same time. if ( - !someHitElementIsSelected && - !pointerDownState.hit.hasHitCommonBoundingBoxOfSelectedElements + event.shiftKey || + (!someHitElementIsSelected && + !pointerDownState.hit.hasHitCommonBoundingBoxOfSelectedElements) ) { this.setState((prevState) => { const nextSelectedElementIds: { [id: string]: true } = {