smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: Revert aspect ratio fix with element size limits and chk (#9131)

Browse source
This commit is contained in:
Márk Tolmács 2025-02-12 15:02:35 +01:00 • committed by GitHub
parent 26f02bebea
commit 77dc055d81
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
5 changed files with 161 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

38
packages/excalidraw/data/restore.ts
View file

@ -206,6 +206,25 @@ const restoreElementWithProperties = <
"customData" in extra ? extra.customData : element.customData;
}
// NOTE (mtolmacs): This is a temporary check to detect extremely large
// element position or sizing
if (
element.x < -1e6 ||
element.x > 1e6 ||
element.y < -1e6 ||
element.y > 1e6 ||
element.width < -1e6 ||
element.width > 1e6 ||
element.height < -1e6 ||
element.height > 1e6
) {
console.error(
`Restore element with properties size or position is too large ${JSON.stringify(
element,
)}`,
);
}
return {
// spread the original element properties to not lose unknown ones
// for forward-compatibility
@ -220,6 +239,25 @@ const restoreElementWithProperties = <
const restoreElement = (
element: Exclude<ExcalidrawElement, ExcalidrawSelectionElement>,
): typeof element | null => {
// NOTE (mtolmacs): This is a temporary check to detect extremely large
// element position or sizing
if (
element.x < -1e6 ||
element.x > 1e6 ||
element.y < -1e6 ||
element.y > 1e6 ||
element.width < -1e6 ||
element.width > 1e6 ||
element.height < -1e6 ||
element.height > 1e6
) {
console.error(
`Restore element size or position is too large ${JSON.stringify(
element,
)}`,
);
}
switch (element.type) {
case "text":
let fontSize = element.fontSize;