smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-04-14 16:40:58 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: don't bundle react-dom when importing from transformHandles (#7634)

Browse source 
* fix: don't bundle react when importing from transfromHandles

* rename to DEFAULT_TRANSFORM_HANDLE_SPACING
This commit is contained in:
Aakansha Doshi 2024-01-31 16:50:35 +05:30 • committed by GitHub
parent e0fefa8025
commit 63b50b3586
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 14 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
packages/excalidraw/constants.ts
View file

@ -142,6 +142,7 @@ export const DEFAULT_FONT_FAMILY: FontFamilyValues = FONT_FAMILY.Virgil;
export const DEFAULT_TEXT_ALIGN = "left"; export const DEFAULT_TEXT_ALIGN = "left";
export const DEFAULT_VERTICAL_ALIGN = "top"; export const DEFAULT_VERTICAL_ALIGN = "top";
export const DEFAULT_VERSION = "{version}"; export const DEFAULT_VERSION = "{version}";
export const DEFAULT_TRANSFORM_HANDLE_SPACING = 2;
export const CANVAS_ONLY_ACTIONS = ["selectAll"]; export const CANVAS_ONLY_ACTIONS = ["selectAll"];

9
packages/excalidraw/element/transformHandles.ts
View file

@ -9,7 +9,7 @@ import { rotate } from "../math";
import { InteractiveCanvasAppState, Zoom } from "../types"; import { InteractiveCanvasAppState, Zoom } from "../types";
import { isTextElement } from "."; import { isTextElement } from ".";
import { isFrameLikeElement, isLinearElement } from "./typeChecks"; import { isFrameLikeElement, isLinearElement } from "./typeChecks";
import { DEFAULT_SPACING } from "../renderer/renderScene"; import { DEFAULT_TRANSFORM_HANDLE_SPACING } from "../constants";
export type TransformHandleDirection = export type TransformHandleDirection =
| "n" | "n"
@ -106,7 +106,8 @@ export const getTransformHandlesFromCoords = (
const width = x2 - x1; const width = x2 - x1;
const height = y2 - y1; const height = y2 - y1;
const dashedLineMargin = margin / zoom.value; const dashedLineMargin = margin / zoom.value;
const centeringOffset = (size - DEFAULT_SPACING * 2) / (2 * zoom.value); const centeringOffset =
(size - DEFAULT_TRANSFORM_HANDLE_SPACING * 2) / (2 * zoom.value);
const transformHandles: TransformHandles = { const transformHandles: TransformHandles = {
nw: omitSides.nw nw: omitSides.nw
@ -263,8 +264,8 @@ export const getTransformHandles = (
}; };
} }
const dashedLineMargin = isLinearElement(element) const dashedLineMargin = isLinearElement(element)
? DEFAULT_SPACING + 8 ? DEFAULT_TRANSFORM_HANDLE_SPACING + 8
: DEFAULT_SPACING; : DEFAULT_TRANSFORM_HANDLE_SPACING;
return getTransformHandlesFromCoords( return getTransformHandlesFromCoords(
getElementAbsoluteCoords(element, true), getElementAbsoluteCoords(element, true),
element.angle, element.angle,

13
packages/excalidraw/renderer/renderScene.ts
View file

@ -64,7 +64,11 @@ import {
} from "../element/transformHandles"; } from "../element/transformHandles";
import { arrayToMap, throttleRAF } from "../utils"; import { arrayToMap, throttleRAF } from "../utils";
import { UserIdleState } from "../types"; import { UserIdleState } from "../types";
import { FRAME_STYLE, THEME_FILTER } from "../constants"; import {
DEFAULT_TRANSFORM_HANDLE_SPACING,
FRAME_STYLE,
THEME_FILTER,
} from "../constants";
import { import {
EXTERNAL_LINK_IMG, EXTERNAL_LINK_IMG,
getLinkHandleFromCoords, getLinkHandleFromCoords,
@ -83,8 +87,6 @@ import {
isElementInFrame, isElementInFrame,
} from "../frame"; } from "../frame";
export const DEFAULT_SPACING = 2;
const strokeRectWithRotation = ( const strokeRectWithRotation = (
context: CanvasRenderingContext2D, context: CanvasRenderingContext2D,
x: number, x: number,
@ -676,7 +678,8 @@ const _renderInteractiveScene = ({
); );
} }
} else if (selectedElements.length > 1 && !appState.isRotating) { } else if (selectedElements.length > 1 && !appState.isRotating) {
const dashedLinePadding = (DEFAULT_SPACING * 2) / appState.zoom.value; const dashedLinePadding =
(DEFAULT_TRANSFORM_HANDLE_SPACING * 2) / appState.zoom.value;
context.fillStyle = oc.white; context.fillStyle = oc.white;
const [x1, y1, x2, y2] = getCommonBounds(selectedElements); const [x1, y1, x2, y2] = getCommonBounds(selectedElements);
const initialLineDash = context.getLineDash(); const initialLineDash = context.getLineDash();
@ -1191,7 +1194,7 @@ const renderSelectionBorder = (
cy: number; cy: number;
activeEmbeddable: boolean; activeEmbeddable: boolean;
}, },
padding = DEFAULT_SPACING * 2, padding = DEFAULT_TRANSFORM_HANDLE_SPACING * 2,
) => { ) => {
const { const {
angle, angle,