Modify action buttons visibility for desktop (#1156)

This commit is contained in:
Sanghyeon Lee 2020-04-02 16:52:24 +09:00 committed by GitHub
parent ffec3af635
commit 634410ad48
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 15 additions and 8 deletions

View file

@ -1,7 +1,8 @@
import React from "react";
import { AppState } from "../types";
import { ExcalidrawElement } from "../element/types";
import { ActionManager } from "../actions/manager";
import { hasBackground, hasStroke, hasText } from "../scene";
import { hasBackground, hasStroke, hasText, getTargetElement } from "../scene";
import { t } from "../i18n";
import { SHAPES } from "../shapes";
import { ToolButton } from "./ToolButton";
@ -11,14 +12,18 @@ import Stack from "./Stack";
import useIsMobile from "../is-mobile";
export function SelectedShapeActions({
targetElements,
appState,
elements,
renderAction,
elementType,
}: {
targetElements: readonly ExcalidrawElement[];
appState: AppState;
elements: readonly ExcalidrawElement[];
renderAction: ActionManager["renderAction"];
elementType: ExcalidrawElement["type"];
}) {
const targetElements = getTargetElement(elements, appState);
const isEditing = Boolean(appState.editingElement);
const isMobile = useIsMobile();
return (
@ -62,7 +67,7 @@ export function SelectedShapeActions({
{renderAction("bringForward")}
</div>
</fieldset>
{!isMobile && (
{!isMobile && !isEditing && targetElements.length > 0 && (
<fieldset>
<legend>{t("labels.actions")}</legend>
<div className="buttonList">