From 5facc0d6da5e4d388dffcb11029349e5be3d8900 Mon Sep 17 00:00:00 2001 From: David Luzar <5153846+dwelle@users.noreply.github.com> Date: Mon, 26 Aug 2024 15:57:28 +0200 Subject: [PATCH] fix: perf regression in `getCommonBounds` (#8429) --- packages/excalidraw/element/bounds.ts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/packages/excalidraw/element/bounds.ts b/packages/excalidraw/element/bounds.ts index d494e59b78..588e24eb0b 100644 --- a/packages/excalidraw/element/bounds.ts +++ b/packages/excalidraw/element/bounds.ts @@ -749,11 +749,10 @@ export const getCommonBounds = ( let minY = Infinity; let maxY = -Infinity; + const _elementsMap = elementsMap || arrayToMap(elements); + elements.forEach((element) => { - const [x1, y1, x2, y2] = getElementBounds( - element, - elementsMap || arrayToMap(elements), - ); + const [x1, y1, x2, y2] = getElementBounds(element, _elementsMap); minX = Math.min(minX, x1); minY = Math.min(minY, y1); maxX = Math.max(maxX, x2);