smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

revert: fix linear elements drifting away after multiple flips

Browse source 
This reverts commit bffc33dd3f.
This commit is contained in:
Alex Kim 2023-02-24 20:03:04 +03:00
parent bffc33dd3f
commit 5931bf01b2
No known key found for this signature in database
GPG key ID: CEE74CFA44D238D7
1 changed files with 1 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

30
src/actions/actionFlip.ts
View file

@ -7,13 +7,7 @@ import { AppState, PointerDownState } from "../types";
import { updateBoundElements } from "../element/binding";
import { arrayToMap } from "../utils";
import { KEYS } from "../keys";
import {
getCommonBoundingBox,
getElementPointsCoords,
} from "../element/bounds";
import { isLinearElement } from "../element/typeChecks";
import { type ExcalidrawLinearElement } from "../element/types";
import { mutateElement } from "../element/mutateElement";
import { getCommonBoundingBox } from "../element/bounds";
const enableActionFlipHorizontal = (
elements: readonly ExcalidrawElement[],
@ -92,15 +86,6 @@ const flipElements = (
): ExcalidrawElement[] => {
const { minX, minY, maxX, maxY } = getCommonBoundingBox(elements);
const linearElements = elements
.filter((element): element is ExcalidrawLinearElement =>
isLinearElement(element),
)
.map((element) => {
const origCoords = getElementPointsCoords(element, element.points);
return [element, origCoords] as const;
});
resizeMultipleElements(
{ originalElements: arrayToMap(elements) } as PointerDownState,
elements,
@ -110,19 +95,6 @@ const flipElements = (
flipDirection === "horizontal" ? minY : maxY,
);
linearElements.forEach(([element, origCoords]) => {
const latestCoords = getElementPointsCoords(element, element.points);
const coordsDiffX =
origCoords[0] - latestCoords[0] + origCoords[2] - latestCoords[2];
const coordsDiffY =
origCoords[1] - latestCoords[1] + origCoords[3] - latestCoords[3];
mutateElement(element, {
x: element.x + coordsDiffX * 0.5,
y: element.y + coordsDiffY * 0.5,
});
});
elements.forEach((element) => updateBoundElements(element));
return elements;