smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Passing in elementsMap in updatePoints, refactor to ElementsMap types

Browse source
This commit is contained in:
Marcel Mraz 2025-04-15 14:02:50 +02:00
parent 94c773a990
commit 567c9f51e4
No known key found for this signature in database
GPG key ID: 4EBD6E62DC830CD2
11 changed files with 86 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

15
packages/excalidraw/actions/actionProperties.tsx
View file

@ -58,6 +58,7 @@ import type { LocalPoint } from "@excalidraw/math";
import type {
Arrowhead,
ElementsMap,
ExcalidrawBindableElement,
ExcalidrawElement,
ExcalidrawLinearElement,
@ -774,7 +775,7 @@ type ChangeFontFamilyData = Partial<
>
> & {
/** cache of selected & editing elements populated on opened popup */
cachedElements?: Map<string, ExcalidrawElement>;
cachedElements?: ElementsMap;
/** flag to reset all elements to their cached versions */
resetAll?: true;
/** flag to reset all containers to their cached versions */
@ -983,7 +984,7 @@ export const actionChangeFontFamily = register({
return result;
},
PanelComponent: ({ elements, appState, app, updateData }) => {
const cachedElementsRef = useRef<Map<string, ExcalidrawElement>>(new Map());
const cachedElementsRef = useRef<ElementsMap>(new Map());
const prevSelectedFontFamilyRef = useRef<number | null>(null);
// relying on state batching as multiple `FontPicker` handlers could be called in rapid succession and we want to combine them
const [batchedData, setBatchedData] = useState<ChangeFontFamilyData>({});
@ -992,7 +993,7 @@ export const actionChangeFontFamily = register({
const selectedFontFamily = useMemo(() => {
const getFontFamily = (
elementsArray: readonly ExcalidrawElement[],
elementsMap: Map<string, ExcalidrawElement>,
elementsMap: ElementsMap,
) =>
getFormValue(
elementsArray,
@ -1668,7 +1669,7 @@ export const actionChangeArrowType = register({
newElement,
startHoveredElement,
"start",
app.scene.getNonDeletedElementsMap(),
elementsMap,
(...args) => app.scene.mutate(...args),
);
endHoveredElement &&
@ -1676,7 +1677,7 @@ export const actionChangeArrowType = register({
newElement,
endHoveredElement,
"end",
app.scene.getNonDeletedElementsMap(),
elementsMap,
(...args) => app.scene.mutate(...args),
);
@ -1736,7 +1737,7 @@ export const actionChangeArrowType = register({
newElement,
startElement,
"start",
app.scene.getNonDeletedElementsMap(),
elementsMap,
(...args) => app.scene.mutate(...args),
);
}
@ -1750,7 +1751,7 @@ export const actionChangeArrowType = register({
newElement,
endElement,
"end",
app.scene.getNonDeletedElementsMap(),
elementsMap,
(...args) => app.scene.mutate(...args),
);
}