smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: free draw flip not scaling correctly (#5752)

Browse source
This commit is contained in:
Antonio Della Fortuna 2022-10-19 00:03:58 +02:00 • committed by GitHub
parent 941b2d7042
commit 55110bf1b8
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 145 additions and 47 deletions
Download patch file Download diff file Expand all files Collapse all files

106
src/tests/flip.test.tsx
View file

@ -79,6 +79,8 @@ const createAndReturnOneDraw = (angle: number = 0) => {
});
};
const FLIP_PRECISION_DECIMALS = 7;
// Rectangle element
it("flips an unrotated rectangle horizontally correctly", () => {
@ -408,9 +410,15 @@ it("flips an unrotated arrow horizontally correctly", () => {
h.app.actionManager.executeAction(actionFlipHorizontal);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
});
it("flips an unrotated arrow vertically correctly", () => {
@ -422,9 +430,15 @@ it("flips an unrotated arrow vertically correctly", () => {
h.app.actionManager.executeAction(actionFlipVertical);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
});
//@TODO fix the tests with rotation
@ -439,10 +453,15 @@ it.skip("flips a rotated arrow horizontally correctly", () => {
h.app.actionManager.executeAction(actionFlipHorizontal);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
// Check angle
expect(API.getSelectedElements()[0].angle).toBeCloseTo(expectedAngle);
});
@ -458,9 +477,15 @@ it.skip("flips a rotated arrow vertically correctly", () => {
h.app.actionManager.executeAction(actionFlipVertical);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
// Check angle
expect(API.getSelectedElements()[0].angle).toBeCloseTo(expectedAngle);
@ -477,9 +502,15 @@ it("flips an unrotated line horizontally correctly", () => {
h.app.actionManager.executeAction(actionFlipHorizontal);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
});
it("flips an unrotated line vertically correctly", () => {
@ -491,9 +522,15 @@ it("flips an unrotated line vertically correctly", () => {
h.app.actionManager.executeAction(actionFlipVertical);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
});
it.skip("flips a rotated line horizontally correctly", () => {
@ -508,9 +545,15 @@ it.skip("flips a rotated line horizontally correctly", () => {
h.app.actionManager.executeAction(actionFlipHorizontal);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
// Check angle
expect(API.getSelectedElements()[0].angle).toBeCloseTo(expectedAngle);
@ -528,9 +571,15 @@ it.skip("flips a rotated line vertically correctly", () => {
h.app.actionManager.executeAction(actionFlipVertical);
// Check if width and height did not change
expect(API.getSelectedElements()[0].width).toEqual(originalWidth);
expect(API.getSelectedElements()[0].width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElements()[0].height).toEqual(originalHeight);
expect(API.getSelectedElements()[0].height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
// Check angle
expect(API.getSelectedElements()[0].angle).toBeCloseTo(expectedAngle);
@ -549,9 +598,9 @@ it("flips an unrotated drawing horizontally correctly", () => {
h.app.actionManager.executeAction(actionFlipHorizontal);
// Check if width and height did not change
expect(draw.width).toEqual(originalWidth);
expect(draw.width).toBeCloseTo(originalWidth, FLIP_PRECISION_DECIMALS);
expect(draw.height).toEqual(originalHeight);
expect(draw.height).toBeCloseTo(originalHeight, FLIP_PRECISION_DECIMALS);
});
it("flips an unrotated drawing vertically correctly", () => {
@ -565,9 +614,9 @@ it("flips an unrotated drawing vertically correctly", () => {
h.app.actionManager.executeAction(actionFlipVertical);
// Check if width and height did not change
expect(draw.width).toEqual(originalWidth);
expect(draw.width).toBeCloseTo(originalWidth, FLIP_PRECISION_DECIMALS);
expect(draw.height).toEqual(originalHeight);
expect(draw.height).toBeCloseTo(originalHeight, FLIP_PRECISION_DECIMALS);
});
it("flips a rotated drawing horizontally correctly", () => {
@ -584,9 +633,9 @@ it("flips a rotated drawing horizontally correctly", () => {
h.app.actionManager.executeAction(actionFlipHorizontal);
// Check if width and height did not change
expect(draw.width).toEqual(originalWidth);
expect(draw.width).toBeCloseTo(originalWidth, FLIP_PRECISION_DECIMALS);
expect(draw.height).toEqual(originalHeight);
expect(draw.height).toBeCloseTo(originalHeight, FLIP_PRECISION_DECIMALS);
// Check angle
expect(draw.angle).toBeCloseTo(expectedAngle);
@ -606,9 +655,16 @@ it("flips a rotated drawing vertically correctly", () => {
h.app.actionManager.executeAction(actionFlipVertical);
// Check if width and height did not change
expect(API.getSelectedElement().width).toEqual(originalWidth);
expect(API.getSelectedElement().height).toEqual(originalHeight);
expect(API.getSelectedElement().width).toBeCloseTo(
originalWidth,
FLIP_PRECISION_DECIMALS,
);
expect(API.getSelectedElement().height).toBeCloseTo(
originalHeight,
FLIP_PRECISION_DECIMALS,
);
// Check angle
expect(API.getSelectedElement().angle).toBeCloseTo(expectedAngle);