Add more ESLint rules and change the formatting scripts (#626)

* Add curly rule in ESLint for consistency

* Fix rules

* More rules

* REturn

* Push

* no else return

* prefer const

* destructing
This commit is contained in:
Lipis 2020-02-02 20:04:35 +02:00 committed by GitHub
parent 814299321e
commit 53994e71e5
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
21 changed files with 201 additions and 77 deletions

View file

@ -49,7 +49,7 @@ export function serializeAsJSON(
export function calculateScrollCenter(
elements: readonly ExcalidrawElement[],
): { scrollX: number; scrollY: number } {
let [x1, y1, x2, y2] = getCommonBounds(elements);
const [x1, y1, x2, y2] = getCommonBounds(elements);
const centerX = (x1 + x2) / 2;
const centerY = (y1 + y2) / 2;
@ -149,7 +149,6 @@ export async function exportToBackend(
}
} catch (e) {
window.alert(t("alerts.couldNotCreateShareableLink"));
return;
}
}
@ -194,8 +193,9 @@ export async function exportCanvas(
scale?: number;
},
) {
if (!elements.length)
if (!elements.length) {
return window.alert(t("alerts.cannotExportEmptyCanvas"));
}
// calculate smallest area to fit the contents in
if (type === "svg") {
@ -252,7 +252,9 @@ export async function exportCanvas(
}
// clean up the DOM
if (tempCanvas !== canvas) tempCanvas.remove();
if (tempCanvas !== canvas) {
tempCanvas.remove();
}
}
function restore(