smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

skip element mutation on noop updates (#1667)

Browse source
This commit is contained in:
David Luzar 2020-05-28 09:50:56 +02:00 • committed by GitHub
parent 7edcea9a93
commit 4f3bf79708
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 19 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/element/mutateElement.ts
View file

@ -17,22 +17,36 @@ export const mutateElement = <TElement extends Mutable<ExcalidrawElement>>(
element: TElement,
updates: ElementUpdate<TElement>,
) => {
let didChange = false;
// casting to any because can't use `in` operator
// (see https://github.com/microsoft/TypeScript/issues/21732)
const { points } = updates as any;
if (typeof points !== "undefined") {
didChange = true;
updates = { ...getSizeFromPoints(points), ...updates };
}
for (const key in updates) {
const value = (updates as any)[key];
if (typeof value !== "undefined") {
// @ts-ignore
element[key] = value;
if (
(element as any)[key] === value &&
// if object, always update in case its deep prop was mutated
(typeof value !== "object" || value === null)
) {
continue;
}
(element as any)[key] = value;
didChange = true;
}
}
if (!didChange) {
return;
}
if (
typeof updates.height !== "undefined" ||
typeof updates.width !== "undefined" ||