smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

chore: Correct Typos in Code Comments (#8268)

Browse source 
chore: correct typos

Co-authored-by: wuzhiqing <wuzhiqing@linklogis.com>
This commit is contained in:
DDDDD12138 2024-07-23 16:56:55 +08:00 • committed by GitHub
parent bd7b778f41
commit 4c5408263c
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
excalidraw-app/app-language/language-detector.ts
View file

@ -17,7 +17,7 @@ export const getPreferredLanguage = () => {
const initialLanguage = const initialLanguage =
(detectedLanguage (detectedLanguage
? // region code may not be defined if user uses generic preferred language ? // region code may not be defined if user uses generic preferred language
// (e.g. chinese vs instead of chienese-simplified) // (e.g. chinese vs instead of chinese-simplified)
languages.find((lang) => lang.code.startsWith(detectedLanguage))?.code languages.find((lang) => lang.code.startsWith(detectedLanguage))?.code
: null) || defaultLang.code; : null) || defaultLang.code;

6
packages/excalidraw/fractionalIndex.ts
View file

@ -11,15 +11,15 @@ import { InvalidFractionalIndexError } from "./errors";
* Envisioned relation between array order and fractional indices: * Envisioned relation between array order and fractional indices:
* *
* 1) Array (or array-like ordered data structure) should be used as a cache of elements order, hiding the internal fractional indices implementation. * 1) Array (or array-like ordered data structure) should be used as a cache of elements order, hiding the internal fractional indices implementation.
* - it's undesirable to to perform reorder for each related operation, thefeore it's necessary to cache the order defined by fractional indices into an ordered data structure * - it's undesirable to perform reorder for each related operation, therefore it's necessary to cache the order defined by fractional indices into an ordered data structure
* - it's easy enough to define the order of the elements from the outside (boundaries), without worrying about the underlying structure of fractional indices (especially for the host apps) * - it's easy enough to define the order of the elements from the outside (boundaries), without worrying about the underlying structure of fractional indices (especially for the host apps)
* - it's necessary to always keep the array support for backwards compatibility (restore) - old scenes, old libraries, supporting multiple excalidraw versions etc. * - it's necessary to always keep the array support for backwards compatibility (restore) - old scenes, old libraries, supporting multiple excalidraw versions etc.
* - it's necessary to always keep the fractional indices in sync with the array order * - it's necessary to always keep the fractional indices in sync with the array order
* - elements with invalid indices should be detected and synced, without altering the already valid indices * - elements with invalid indices should be detected and synced, without altering the already valid indices
* *
* 2) Fractional indices should be used to reorder the elements, whenever the cached order is expected to be invalidated. * 2) Fractional indices should be used to reorder the elements, whenever the cached order is expected to be invalidated.
* - as the fractional indices are encoded as part of the elements, it opens up possibilties for incremental-like APIs * - as the fractional indices are encoded as part of the elements, it opens up possibilities for incremental-like APIs
* - re-order based on fractional indices should be part of (multiplayer) operations such as reconcillitation & undo/redo * - re-order based on fractional indices should be part of (multiplayer) operations such as reconciliation & undo/redo
* - technically all the z-index actions could perform also re-order based on fractional indices,but in current state it would not bring much benefits, * - technically all the z-index actions could perform also re-order based on fractional indices,but in current state it would not bring much benefits,
* as it's faster & more efficient to perform re-order based on array manipulation and later synchronisation of moved indices with the array order * as it's faster & more efficient to perform re-order based on array manipulation and later synchronisation of moved indices with the array order
*/ */