smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

improvement: do not reset to selection for draw tool (#2721)

Browse source 
Co-authored-by: Lipis <lipiridis@gmail.com>
Co-authored-by: dwelle <luzar.david@gmail.com>
This commit is contained in:
Jaiwanth 2021-01-05 18:34:06 +05:30 • committed by GitHub
parent ade2565f49
commit 4acdc47ef0
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 36 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/tests/__snapshots__/regressionTests.test.tsx.snap
View file

@ -6364,7 +6364,7 @@ Object {
"editingGroupId": null,
"editingLinearElement": null,
"elementLocked": false,
"elementType": "selection",
"elementType": "draw",
"errorMessage": null,
"exportBackground": true,
"exportEmbedScene": false,
@ -6392,7 +6392,7 @@ Object {
"scrollY": 0,
"scrolledOutside": false,
"selectedElementIds": Object {
"id7": true,
"id7": false,
},
"selectedGroupIds": Object {},
"selectionElement": null,
@ -8082,7 +8082,7 @@ Object {
"editingLinearElement": null,
"name": "Untitled-201933152653",
"selectedElementIds": Object {
"id7": true,
"id7": false,
},
"viewBackgroundColor": "#ffffff",
},
@ -10433,7 +10433,7 @@ Object {
"editingGroupId": null,
"editingLinearElement": null,
"elementLocked": false,
"elementType": "selection",
"elementType": "draw",
"errorMessage": null,
"exportBackground": true,
"exportEmbedScene": false,
@ -10461,7 +10461,7 @@ Object {
"scrollY": 0,
"scrolledOutside": false,
"selectedElementIds": Object {
"id0": true,
"id0": false,
},
"selectedGroupIds": Object {},
"selectionElement": null,
@ -10546,7 +10546,7 @@ Object {
"editingLinearElement": null,
"name": "Untitled-201933152653",
"selectedElementIds": Object {
"id0": true,
"id0": false,
},
"viewBackgroundColor": "#ffffff",
},
@ -11489,7 +11489,7 @@ Object {
"editingGroupId": null,
"editingLinearElement": null,
"elementLocked": false,
"elementType": "selection",
"elementType": "draw",
"errorMessage": null,
"exportBackground": true,
"exportEmbedScene": false,
@ -11517,7 +11517,7 @@ Object {
"scrollY": 0,
"scrolledOutside": false,
"selectedElementIds": Object {
"id0": true,
"id0": false,
},
"selectedGroupIds": Object {},
"selectionElement": null,
@ -11602,7 +11602,7 @@ Object {
"editingLinearElement": null,
"name": "Untitled-201933152653",
"selectedElementIds": Object {
"id0": true,
"id0": false,
},
"viewBackgroundColor": "#ffffff",
},

22
src/tests/regressionTests.test.tsx
View file

@ -150,22 +150,26 @@ describe("regression tests", () => {
expect(API.getSelectedElement().id).not.toEqual(prevSelectedId);
});
for (const [keys, shape] of [
[`2${KEYS.R}`, "rectangle"],
[`3${KEYS.D}`, "diamond"],
[`4${KEYS.E}`, "ellipse"],
[`5${KEYS.A}`, "arrow"],
[`6${KEYS.L}`, "line"],
[`7${KEYS.X}`, "draw"],
] as [string, ExcalidrawElement["type"]][]) {
for (const [keys, shape, shouldSelect] of [
[`2${KEYS.R}`, "rectangle", true],
[`3${KEYS.D}`, "diamond", true],
[`4${KEYS.E}`, "ellipse", true],
[`5${KEYS.A}`, "arrow", true],
[`6${KEYS.L}`, "line", true],
[`7${KEYS.X}`, "draw", false],
] as [string, ExcalidrawElement["type"], boolean][]) {
for (const key of keys) {
it(`key ${key} selects ${shape} tool`, () => {
Keyboard.keyPress(key);
expect(h.state.elementType).toBe(shape);
mouse.down(10, 10);
mouse.up(10, 10);
expect(API.getSelectedElement().type).toBe(shape);
if (shouldSelect) {
expect(API.getSelectedElement().type).toBe(shape);
}
});
}
}