refactor: separate elements logic into a standalone package (#9285)
Some checks failed
Auto release excalidraw next / Auto-release-excalidraw-next (push) Failing after 2m36s
Build Docker image / build-docker (push) Failing after 6s
Cancel previous runs / cancel (push) Failing after 1s
Publish Docker / publish-docker (push) Failing after 31s
New Sentry production release / sentry (push) Failing after 2m3s

This commit is contained in:
Marcel Mraz 2025-03-26 15:24:59 +01:00 committed by GitHub
parent a18f059188
commit 432a46ef9e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
372 changed files with 3466 additions and 2466 deletions

View file

@ -22,13 +22,6 @@ import {
THEME, THEME,
TITLE_TIMEOUT, TITLE_TIMEOUT,
VERSION_TIMEOUT, VERSION_TIMEOUT,
} from "@excalidraw/excalidraw/constants";
import polyfill from "@excalidraw/excalidraw/polyfill";
import { useCallback, useEffect, useRef, useState } from "react";
import { loadFromBlob } from "@excalidraw/excalidraw/data/blob";
import { useCallbackRefState } from "@excalidraw/excalidraw/hooks/useCallbackRefState";
import { t } from "@excalidraw/excalidraw/i18n";
import {
debounce, debounce,
getVersion, getVersion,
getFrame, getFrame,
@ -37,7 +30,13 @@ import {
resolvablePromise, resolvablePromise,
isRunningInIframe, isRunningInIframe,
isDevEnv, isDevEnv,
} from "@excalidraw/excalidraw/utils"; } from "@excalidraw/common";
import polyfill from "@excalidraw/excalidraw/polyfill";
import { useCallback, useEffect, useRef, useState } from "react";
import { loadFromBlob } from "@excalidraw/excalidraw/data/blob";
import { useCallbackRefState } from "@excalidraw/excalidraw/hooks/useCallbackRefState";
import { t } from "@excalidraw/excalidraw/i18n";
import { import {
GithubIcon, GithubIcon,
XBrandIcon, XBrandIcon,
@ -48,10 +47,10 @@ import {
share, share,
youtubeIcon, youtubeIcon,
} from "@excalidraw/excalidraw/components/icons"; } from "@excalidraw/excalidraw/components/icons";
import { isElementLink } from "@excalidraw/excalidraw/element/elementLink"; import { isElementLink } from "@excalidraw/element/elementLink";
import { restore, restoreAppState } from "@excalidraw/excalidraw/data/restore"; import { restore, restoreAppState } from "@excalidraw/excalidraw/data/restore";
import { newElementWith } from "@excalidraw/excalidraw/element/mutateElement"; import { newElementWith } from "@excalidraw/element/mutateElement";
import { isInitializedImageElement } from "@excalidraw/excalidraw/element/typeChecks"; import { isInitializedImageElement } from "@excalidraw/element/typeChecks";
import clsx from "clsx"; import clsx from "clsx";
import { import {
parseLibraryTokensFromUrl, parseLibraryTokensFromUrl,
@ -64,7 +63,7 @@ import type {
FileId, FileId,
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
OrderedExcalidrawElement, OrderedExcalidrawElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { import type {
AppState, AppState,
ExcalidrawImperativeAPI, ExcalidrawImperativeAPI,
@ -72,8 +71,8 @@ import type {
ExcalidrawInitialDataState, ExcalidrawInitialDataState,
UIAppState, UIAppState,
} from "@excalidraw/excalidraw/types"; } from "@excalidraw/excalidraw/types";
import type { ResolutionType } from "@excalidraw/excalidraw/utility-types"; import type { ResolutionType } from "@excalidraw/common/utility-types";
import type { ResolvablePromise } from "@excalidraw/excalidraw/utils"; import type { ResolvablePromise } from "@excalidraw/common/utils";
import CustomStats from "./CustomStats"; import CustomStats from "./CustomStats";
import { import {

View file

@ -1,11 +1,15 @@
import { Stats } from "@excalidraw/excalidraw"; import { Stats } from "@excalidraw/excalidraw";
import { copyTextToSystemClipboard } from "@excalidraw/excalidraw/clipboard"; import { copyTextToSystemClipboard } from "@excalidraw/excalidraw/clipboard";
import { DEFAULT_VERSION } from "@excalidraw/excalidraw/constants"; import {
DEFAULT_VERSION,
debounce,
getVersion,
nFormatter,
} from "@excalidraw/common";
import { t } from "@excalidraw/excalidraw/i18n"; import { t } from "@excalidraw/excalidraw/i18n";
import { debounce, getVersion, nFormatter } from "@excalidraw/excalidraw/utils";
import { useEffect, useState } from "react"; import { useEffect, useState } from "react";
import type { NonDeletedExcalidrawElement } from "@excalidraw/excalidraw/element/types"; import type { NonDeletedExcalidrawElement } from "@excalidraw/element/types";
import type { UIAppState } from "@excalidraw/excalidraw/types"; import type { UIAppState } from "@excalidraw/excalidraw/types";
import { import {

View file

@ -5,7 +5,7 @@ import { useLayoutEffect, useRef } from "react";
import type { import type {
FileId, FileId,
OrderedExcalidrawElement, OrderedExcalidrawElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { AppState, BinaryFileData } from "@excalidraw/excalidraw/types"; import type { AppState, BinaryFileData } from "@excalidraw/excalidraw/types";
import { STORAGE_KEYS } from "./app_constants"; import { STORAGE_KEYS } from "./app_constants";

View file

@ -6,30 +6,29 @@ import {
reconcileElements, reconcileElements,
} from "@excalidraw/excalidraw"; } from "@excalidraw/excalidraw";
import { ErrorDialog } from "@excalidraw/excalidraw/components/ErrorDialog"; import { ErrorDialog } from "@excalidraw/excalidraw/components/ErrorDialog";
import { APP_NAME, EVENT } from "@excalidraw/excalidraw/constants"; import { APP_NAME, EVENT } from "@excalidraw/common";
import { import {
IDLE_THRESHOLD, IDLE_THRESHOLD,
ACTIVE_THRESHOLD, ACTIVE_THRESHOLD,
UserIdleState, UserIdleState,
} from "@excalidraw/excalidraw/constants";
import { decryptData } from "@excalidraw/excalidraw/data/encryption";
import { getVisibleSceneBounds } from "@excalidraw/excalidraw/element/bounds";
import { newElementWith } from "@excalidraw/excalidraw/element/mutateElement";
import {
isImageElement,
isInitializedImageElement,
} from "@excalidraw/excalidraw/element/typeChecks";
import { AbortError } from "@excalidraw/excalidraw/errors";
import { t } from "@excalidraw/excalidraw/i18n";
import { withBatchedUpdates } from "@excalidraw/excalidraw/reactUtils";
import {
assertNever, assertNever,
isDevEnv, isDevEnv,
isTestEnv, isTestEnv,
preventUnload, preventUnload,
resolvablePromise, resolvablePromise,
throttleRAF, throttleRAF,
} from "@excalidraw/excalidraw/utils"; } from "@excalidraw/common";
import { decryptData } from "@excalidraw/excalidraw/data/encryption";
import { getVisibleSceneBounds } from "@excalidraw/element/bounds";
import { newElementWith } from "@excalidraw/element/mutateElement";
import {
isImageElement,
isInitializedImageElement,
} from "@excalidraw/element/typeChecks";
import { AbortError } from "@excalidraw/excalidraw/errors";
import { t } from "@excalidraw/excalidraw/i18n";
import { withBatchedUpdates } from "@excalidraw/excalidraw/reactUtils";
import throttle from "lodash.throttle"; import throttle from "lodash.throttle";
import { PureComponent } from "react"; import { PureComponent } from "react";
@ -43,7 +42,7 @@ import type {
FileId, FileId,
InitializedExcalidrawImageElement, InitializedExcalidrawImageElement,
OrderedExcalidrawElement, OrderedExcalidrawElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { import type {
BinaryFileData, BinaryFileData,
ExcalidrawImperativeAPI, ExcalidrawImperativeAPI,
@ -51,7 +50,7 @@ import type {
Collaborator, Collaborator,
Gesture, Gesture,
} from "@excalidraw/excalidraw/types"; } from "@excalidraw/excalidraw/types";
import type { Mutable, ValueOf } from "@excalidraw/excalidraw/utility-types"; import type { Mutable, ValueOf } from "@excalidraw/common/utility-types";
import { appJotaiStore, atom } from "../app-jotai"; import { appJotaiStore, atom } from "../app-jotai";
import { import {

View file

@ -1,11 +1,11 @@
import { CaptureUpdateAction } from "@excalidraw/excalidraw"; import { CaptureUpdateAction } from "@excalidraw/excalidraw";
import { trackEvent } from "@excalidraw/excalidraw/analytics"; import { trackEvent } from "@excalidraw/excalidraw/analytics";
import { encryptData } from "@excalidraw/excalidraw/data/encryption"; import { encryptData } from "@excalidraw/excalidraw/data/encryption";
import { newElementWith } from "@excalidraw/excalidraw/element/mutateElement"; import { newElementWith } from "@excalidraw/element/mutateElement";
import throttle from "lodash.throttle"; import throttle from "lodash.throttle";
import type { UserIdleState } from "@excalidraw/excalidraw/constants"; import type { UserIdleState } from "@excalidraw/common";
import type { OrderedExcalidrawElement } from "@excalidraw/excalidraw/element/types"; import type { OrderedExcalidrawElement } from "@excalidraw/element/types";
import type { import type {
OnUserFollowedPayload, OnUserFollowedPayload,
SocketId, SocketId,

View file

@ -6,7 +6,7 @@ import {
TTDDialog, TTDDialog,
} from "@excalidraw/excalidraw"; } from "@excalidraw/excalidraw";
import { getDataURL } from "@excalidraw/excalidraw/data/blob"; import { getDataURL } from "@excalidraw/excalidraw/data/blob";
import { safelyParseJSON } from "@excalidraw/excalidraw/utils"; import { safelyParseJSON } from "@excalidraw/common";
import type { ExcalidrawImperativeAPI } from "@excalidraw/excalidraw/types"; import type { ExcalidrawImperativeAPI } from "@excalidraw/excalidraw/types";

View file

@ -6,9 +6,9 @@ import {
import { MainMenu } from "@excalidraw/excalidraw/index"; import { MainMenu } from "@excalidraw/excalidraw/index";
import React from "react"; import React from "react";
import { isDevEnv } from "@excalidraw/excalidraw/utils"; import { isDevEnv } from "@excalidraw/common";
import type { Theme } from "@excalidraw/excalidraw/element/types"; import type { Theme } from "@excalidraw/element/types";
import { LanguageList } from "../app-language/LanguageList"; import { LanguageList } from "../app-language/LanguageList";
import { isExcalidrawPlusSignedUser } from "../app_constants"; import { isExcalidrawPlusSignedUser } from "../app_constants";

View file

@ -1,5 +1,5 @@
import { loginIcon } from "@excalidraw/excalidraw/components/icons"; import { loginIcon } from "@excalidraw/excalidraw/components/icons";
import { POINTER_EVENTS } from "@excalidraw/excalidraw/constants"; import { POINTER_EVENTS } from "@excalidraw/common";
import { useI18n } from "@excalidraw/excalidraw/i18n"; import { useI18n } from "@excalidraw/excalidraw/i18n";
import { WelcomeScreen } from "@excalidraw/excalidraw/index"; import { WelcomeScreen } from "@excalidraw/excalidraw/index";
import React from "react"; import React from "react";

View file

@ -8,20 +8,21 @@ import {
getNormalizedCanvasDimensions, getNormalizedCanvasDimensions,
} from "@excalidraw/excalidraw/renderer/helpers"; } from "@excalidraw/excalidraw/renderer/helpers";
import { type AppState } from "@excalidraw/excalidraw/types"; import { type AppState } from "@excalidraw/excalidraw/types";
import { throttleRAF } from "@excalidraw/excalidraw/utils"; import { throttleRAF } from "@excalidraw/common";
import { useCallback, useImperativeHandle, useRef } from "react"; import { useCallback, useImperativeHandle, useRef } from "react";
import type { DebugElement } from "@excalidraw/excalidraw/visualdebug";
import { import {
isLineSegment, isLineSegment,
type GlobalPoint, type GlobalPoint,
type LineSegment, type LineSegment,
} from "../../packages/math"; } from "@excalidraw/math";
import { isCurve } from "../../packages/math/curve"; import { isCurve } from "@excalidraw/math/curve";
import { STORAGE_KEYS } from "../app_constants";
import type { Curve } from "../../packages/math"; import type { DebugElement } from "@excalidraw/excalidraw/visualdebug";
import type { Curve } from "@excalidraw/math";
import { STORAGE_KEYS } from "../app_constants";
const renderLine = ( const renderLine = (
context: CanvasRenderingContext2D, context: CanvasRenderingContext2D,

View file

@ -1,24 +1,24 @@
import React from "react";
import { uploadBytes, ref } from "firebase/storage";
import { nanoid } from "nanoid";
import { trackEvent } from "@excalidraw/excalidraw/analytics"; import { trackEvent } from "@excalidraw/excalidraw/analytics";
import { Card } from "@excalidraw/excalidraw/components/Card"; import { Card } from "@excalidraw/excalidraw/components/Card";
import { ExcalidrawLogo } from "@excalidraw/excalidraw/components/ExcalidrawLogo"; import { ExcalidrawLogo } from "@excalidraw/excalidraw/components/ExcalidrawLogo";
import { ToolButton } from "@excalidraw/excalidraw/components/ToolButton"; import { ToolButton } from "@excalidraw/excalidraw/components/ToolButton";
import { MIME_TYPES } from "@excalidraw/excalidraw/constants"; import { MIME_TYPES, getFrame } from "@excalidraw/common";
import { import {
encryptData, encryptData,
generateEncryptionKey, generateEncryptionKey,
} from "@excalidraw/excalidraw/data/encryption"; } from "@excalidraw/excalidraw/data/encryption";
import { serializeAsJSON } from "@excalidraw/excalidraw/data/json"; import { serializeAsJSON } from "@excalidraw/excalidraw/data/json";
import { isInitializedImageElement } from "@excalidraw/excalidraw/element/typeChecks"; import { isInitializedImageElement } from "@excalidraw/element/typeChecks";
import { useI18n } from "@excalidraw/excalidraw/i18n"; import { useI18n } from "@excalidraw/excalidraw/i18n";
import { getFrame } from "@excalidraw/excalidraw/utils";
import { uploadBytes, ref } from "firebase/storage";
import { nanoid } from "nanoid";
import React from "react";
import type { import type {
FileId, FileId,
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { import type {
AppState, AppState,
BinaryFileData, BinaryFileData,

View file

@ -1,8 +1,8 @@
import { THEME } from "@excalidraw/excalidraw/constants"; import { THEME } from "@excalidraw/common";
import oc from "open-color"; import oc from "open-color";
import React from "react"; import React from "react";
import type { Theme } from "@excalidraw/excalidraw/element/types"; import type { Theme } from "@excalidraw/element/types";
// https://github.com/tholman/github-corners // https://github.com/tholman/github-corners
export const GitHubCorner = React.memo( export const GitHubCorner = React.memo(

View file

@ -1,7 +1,7 @@
import { CaptureUpdateAction } from "@excalidraw/excalidraw"; import { CaptureUpdateAction } from "@excalidraw/excalidraw";
import { compressData } from "@excalidraw/excalidraw/data/encode"; import { compressData } from "@excalidraw/excalidraw/data/encode";
import { newElementWith } from "@excalidraw/excalidraw/element/mutateElement"; import { newElementWith } from "@excalidraw/element/mutateElement";
import { isInitializedImageElement } from "@excalidraw/excalidraw/element/typeChecks"; import { isInitializedImageElement } from "@excalidraw/element/typeChecks";
import { t } from "@excalidraw/excalidraw/i18n"; import { t } from "@excalidraw/excalidraw/i18n";
import type { import type {
@ -9,7 +9,7 @@ import type {
ExcalidrawImageElement, ExcalidrawImageElement,
FileId, FileId,
InitializedExcalidrawImageElement, InitializedExcalidrawImageElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { import type {
BinaryFileData, BinaryFileData,
BinaryFileMetadata, BinaryFileMetadata,

View file

@ -14,9 +14,9 @@ import { clearAppStateForLocalStorage } from "@excalidraw/excalidraw/appState";
import { import {
CANVAS_SEARCH_TAB, CANVAS_SEARCH_TAB,
DEFAULT_SIDEBAR, DEFAULT_SIDEBAR,
} from "@excalidraw/excalidraw/constants"; debounce,
import { clearElementsForLocalStorage } from "@excalidraw/excalidraw/element"; } from "@excalidraw/common";
import { debounce } from "@excalidraw/excalidraw/utils"; import { clearElementsForLocalStorage } from "@excalidraw/element";
import { import {
createStore, createStore,
entries, entries,
@ -29,16 +29,13 @@ import {
import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library"; import type { LibraryPersistedData } from "@excalidraw/excalidraw/data/library";
import type { ImportedDataState } from "@excalidraw/excalidraw/data/types"; import type { ImportedDataState } from "@excalidraw/excalidraw/data/types";
import type { import type { ExcalidrawElement, FileId } from "@excalidraw/element/types";
ExcalidrawElement,
FileId,
} from "@excalidraw/excalidraw/element/types";
import type { import type {
AppState, AppState,
BinaryFileData, BinaryFileData,
BinaryFiles, BinaryFiles,
} from "@excalidraw/excalidraw/types"; } from "@excalidraw/excalidraw/types";
import type { MaybePromise } from "@excalidraw/excalidraw/utility-types"; import type { MaybePromise } from "@excalidraw/common/utility-types";
import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants"; import { SAVE_TO_LOCAL_STORAGE_TIMEOUT, STORAGE_KEYS } from "../app_constants";

View file

@ -1,12 +1,12 @@
import { reconcileElements } from "@excalidraw/excalidraw"; import { reconcileElements } from "@excalidraw/excalidraw";
import { MIME_TYPES } from "@excalidraw/excalidraw/constants"; import { MIME_TYPES } from "@excalidraw/common";
import { decompressData } from "@excalidraw/excalidraw/data/encode"; import { decompressData } from "@excalidraw/excalidraw/data/encode";
import { import {
encryptData, encryptData,
decryptData, decryptData,
} from "@excalidraw/excalidraw/data/encryption"; } from "@excalidraw/excalidraw/data/encryption";
import { restoreElements } from "@excalidraw/excalidraw/data/restore"; import { restoreElements } from "@excalidraw/excalidraw/data/restore";
import { getSceneVersion } from "@excalidraw/excalidraw/element"; import { getSceneVersion } from "@excalidraw/element";
import { initializeApp } from "firebase/app"; import { initializeApp } from "firebase/app";
import { import {
getFirestore, getFirestore,
@ -22,7 +22,7 @@ import type {
ExcalidrawElement, ExcalidrawElement,
FileId, FileId,
OrderedExcalidrawElement, OrderedExcalidrawElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { import type {
AppState, AppState,
BinaryFileData, BinaryFileData,

View file

@ -9,26 +9,26 @@ import {
} from "@excalidraw/excalidraw/data/encryption"; } from "@excalidraw/excalidraw/data/encryption";
import { serializeAsJSON } from "@excalidraw/excalidraw/data/json"; import { serializeAsJSON } from "@excalidraw/excalidraw/data/json";
import { restore } from "@excalidraw/excalidraw/data/restore"; import { restore } from "@excalidraw/excalidraw/data/restore";
import { isInvisiblySmallElement } from "@excalidraw/excalidraw/element/sizeHelpers"; import { isInvisiblySmallElement } from "@excalidraw/element/sizeHelpers";
import { isInitializedImageElement } from "@excalidraw/excalidraw/element/typeChecks"; import { isInitializedImageElement } from "@excalidraw/element/typeChecks";
import { t } from "@excalidraw/excalidraw/i18n"; import { t } from "@excalidraw/excalidraw/i18n";
import { bytesToHexString } from "@excalidraw/excalidraw/utils"; import { bytesToHexString } from "@excalidraw/common";
import type { UserIdleState } from "@excalidraw/excalidraw/constants"; import type { UserIdleState } from "@excalidraw/common";
import type { ImportedDataState } from "@excalidraw/excalidraw/data/types"; import type { ImportedDataState } from "@excalidraw/excalidraw/data/types";
import type { SceneBounds } from "@excalidraw/excalidraw/element/bounds"; import type { SceneBounds } from "@excalidraw/element/bounds";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
FileId, FileId,
OrderedExcalidrawElement, OrderedExcalidrawElement,
} from "@excalidraw/excalidraw/element/types"; } from "@excalidraw/element/types";
import type { import type {
AppState, AppState,
BinaryFileData, BinaryFileData,
BinaryFiles, BinaryFiles,
SocketId, SocketId,
} from "@excalidraw/excalidraw/types"; } from "@excalidraw/excalidraw/types";
import type { MakeBrand } from "@excalidraw/excalidraw/utility-types"; import type { MakeBrand } from "@excalidraw/common/utility-types";
import { import {
DELETED_ELEMENT_TIMEOUT, DELETED_ELEMENT_TIMEOUT,

View file

@ -2,9 +2,9 @@ import {
clearAppStateForLocalStorage, clearAppStateForLocalStorage,
getDefaultAppState, getDefaultAppState,
} from "@excalidraw/excalidraw/appState"; } from "@excalidraw/excalidraw/appState";
import { clearElementsForLocalStorage } from "@excalidraw/excalidraw/element"; import { clearElementsForLocalStorage } from "@excalidraw/element";
import type { ExcalidrawElement } from "@excalidraw/excalidraw/element/types"; import type { ExcalidrawElement } from "@excalidraw/element/types";
import type { AppState } from "@excalidraw/excalidraw/types"; import type { AppState } from "@excalidraw/excalidraw/types";
import { STORAGE_KEYS } from "../app_constants"; import { STORAGE_KEYS } from "../app_constants";

View file

@ -15,8 +15,7 @@ import {
import { useUIAppState } from "@excalidraw/excalidraw/context/ui-appState"; import { useUIAppState } from "@excalidraw/excalidraw/context/ui-appState";
import { useCopyStatus } from "@excalidraw/excalidraw/hooks/useCopiedIndicator"; import { useCopyStatus } from "@excalidraw/excalidraw/hooks/useCopiedIndicator";
import { useI18n } from "@excalidraw/excalidraw/i18n"; import { useI18n } from "@excalidraw/excalidraw/i18n";
import { KEYS } from "@excalidraw/excalidraw/keys"; import { KEYS, getFrame } from "@excalidraw/common";
import { getFrame } from "@excalidraw/excalidraw/utils";
import { useEffect, useRef, useState } from "react"; import { useEffect, useRef, useState } from "react";
import { atom, useAtom, useAtomValue } from "../app-jotai"; import { atom, useAtom, useAtomValue } from "../app-jotai";

View file

@ -3,7 +3,7 @@ import {
createRedoAction, createRedoAction,
createUndoAction, createUndoAction,
} from "@excalidraw/excalidraw/actions/actionHistory"; } from "@excalidraw/excalidraw/actions/actionHistory";
import { syncInvalidIndices } from "@excalidraw/excalidraw/fractionalIndex"; import { syncInvalidIndices } from "@excalidraw/element/fractionalIndex";
import { API } from "@excalidraw/excalidraw/tests/helpers/api"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { act, render, waitFor } from "@excalidraw/excalidraw/tests/test-utils"; import { act, render, waitFor } from "@excalidraw/excalidraw/tests/test-utils";
import { vi } from "vitest"; import { vi } from "vitest";

View file

@ -1,9 +1,8 @@
import { THEME } from "@excalidraw/excalidraw"; import { THEME } from "@excalidraw/excalidraw";
import { EVENT } from "@excalidraw/excalidraw/constants"; import { EVENT, CODES, KEYS } from "@excalidraw/common";
import { CODES, KEYS } from "@excalidraw/excalidraw/keys";
import { useEffect, useLayoutEffect, useState } from "react"; import { useEffect, useLayoutEffect, useState } from "react";
import type { Theme } from "@excalidraw/excalidraw/element/types"; import type { Theme } from "@excalidraw/element/types";
import { STORAGE_KEYS } from "./app_constants"; import { STORAGE_KEYS } from "./app_constants";

View file

@ -23,6 +23,22 @@ export default defineConfig(({ mode }) => {
envDir: "../", envDir: "../",
resolve: { resolve: {
alias: [ alias: [
{
find: /^@excalidraw\/common$/,
replacement: path.resolve(__dirname, "../packages/common/src/index.ts"),
},
{
find: /^@excalidraw\/common\/(.*?)/,
replacement: path.resolve(__dirname, "../packages/common/src/$1"),
},
{
find: /^@excalidraw\/element$/,
replacement: path.resolve(__dirname, "../packages/element/src/index.ts"),
},
{
find: /^@excalidraw\/element\/(.*?)/,
replacement: path.resolve(__dirname, "../packages/element/src/$1"),
},
{ {
find: /^@excalidraw\/excalidraw$/, find: /^@excalidraw\/excalidraw$/,
replacement: path.resolve(__dirname, "../packages/excalidraw/index.tsx"), replacement: path.resolve(__dirname, "../packages/excalidraw/index.tsx"),
@ -31,21 +47,21 @@ export default defineConfig(({ mode }) => {
find: /^@excalidraw\/excalidraw\/(.*?)/, find: /^@excalidraw\/excalidraw\/(.*?)/,
replacement: path.resolve(__dirname, "../packages/excalidraw/$1"), replacement: path.resolve(__dirname, "../packages/excalidraw/$1"),
}, },
{
find: /^@excalidraw\/utils$/,
replacement: path.resolve(__dirname, "../packages/utils/index.ts"),
},
{
find: /^@excalidraw\/utils\/(.*?)/,
replacement: path.resolve(__dirname, "../packages/utils/$1"),
},
{ {
find: /^@excalidraw\/math$/, find: /^@excalidraw\/math$/,
replacement: path.resolve(__dirname, "../packages/math/index.ts"), replacement: path.resolve(__dirname, "../packages/math/src/index.ts"),
}, },
{ {
find: /^@excalidraw\/math\/(.*?)/, find: /^@excalidraw\/math\/(.*?)/,
replacement: path.resolve(__dirname, "../packages/math/$1"), replacement: path.resolve(__dirname, "../packages/math/src/$1"),
},
{
find: /^@excalidraw\/utils$/,
replacement: path.resolve(__dirname, "../packages/utils/src/index.ts"),
},
{
find: /^@excalidraw\/utils\/(.*?)/,
replacement: path.resolve(__dirname, "../packages/utils/src/$1"),
}, },
], ],
}, },

View file

@ -4,9 +4,7 @@
"packageManager": "yarn@1.22.22", "packageManager": "yarn@1.22.22",
"workspaces": [ "workspaces": [
"excalidraw-app", "excalidraw-app",
"packages/excalidraw", "packages/*",
"packages/utils",
"packages/math",
"examples/*" "examples/*"
], ],
"devDependencies": { "devDependencies": {

View file

@ -0,0 +1,3 @@
{
"extends": ["../eslintrc.base.json"]
}

19
packages/common/README.md Normal file
View file

@ -0,0 +1,19 @@
# @excalidraw/common
## Install
```bash
npm install @excalidraw/common
```
If you prefer Yarn over npm, use this command to install the Excalidraw utils package:
```bash
yarn add @excalidraw/common
```
With PNPM, similarly install the package with this command:
```bash
pnpm add @excalidraw/common
```

3
packages/common/global.d.ts vendored Normal file
View file

@ -0,0 +1,3 @@
/// <reference types="vite/client" />
import "@excalidraw/excalidraw/global";
import "@excalidraw/excalidraw/css";

View file

@ -0,0 +1,65 @@
{
"name": "@excalidraw/common",
"version": "0.1.0",
"type": "module",
"types": "./dist/types/common/index.d.ts",
"main": "./dist/prod/index.js",
"module": "./dist/prod/index.js",
"exports": {
".": {
"types": "./dist/types/common/index.d.ts",
"development": "./dist/dev/index.js",
"production": "./dist/prod/index.js",
"default": "./dist/prod/index.js"
},
"./*": {
"types": "./../common/dist/types/common/*"
}
},
"files": [
"dist/*"
],
"description": "Excalidraw common functions, constants, etc.",
"publishConfig": {
"access": "public"
},
"license": "MIT",
"keywords": [
"excalidraw",
"excalidraw-utils"
],
"browserslist": {
"production": [
">0.2%",
"not dead",
"not ie <= 11",
"not op_mini all",
"not safari < 12",
"not kaios <= 2.5",
"not edge < 79",
"not chrome < 70",
"not and_uc < 13",
"not samsung < 10"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
},
"dependencies": {
"es6-promise-pool": "2.5.0",
"nanoid": "3.3.3",
"open-color": "1.9.1",
"roughjs": "4.6.4"
},
"devDependencies": {
"typescript": "4.9.4"
},
"bugs": "https://github.com/excalidraw/excalidraw/issues",
"repository": "https://github.com/excalidraw/excalidraw",
"scripts": {
"gen:types": "rm -rf types && tsc",
"build:esm": "rm -rf dist && node ../../scripts/buildBase.js && yarn gen:types"
}
}

View file

@ -1,4 +1,4 @@
export default class BinaryHeap<T> { export class BinaryHeap<T> {
private content: T[] = []; private content: T[] = [];
constructor(private scoreFunction: (node: T) => number) {} constructor(private scoreFunction: (node: T) => number) {}

View file

@ -1,7 +1,10 @@
import { COLOR_PALETTE } from "./colors"; import type {
ExcalidrawElement,
FontFamilyValues,
} from "@excalidraw/element/types";
import type { AppProps, AppState } from "@excalidraw/excalidraw/types";
import type { ExcalidrawElement, FontFamilyValues } from "./element/types"; import { COLOR_PALETTE } from "./colors";
import type { AppProps, AppState } from "./types";
export const isDarwin = /Mac|iPod|iPhone|iPad/.test(navigator.platform); export const isDarwin = /Mac|iPod|iPhone|iPad/.test(navigator.platform);
export const isWindows = /^Win/.test(navigator.platform); export const isWindows = /^Win/.test(navigator.platform);

View file

@ -1,12 +1,9 @@
import { import type {
FreedrawIcon, ExcalidrawTextElement,
FontFamilyNormalIcon, FontFamilyValues,
FontFamilyHeadingIcon, } from "@excalidraw/element/types";
FontFamilyCodeIcon,
} from "../components/icons";
import { FONT_FAMILY, FONT_FAMILY_FALLBACKS } from "../constants";
import type { JSX } from "react"; import { FONT_FAMILY, FONT_FAMILY_FALLBACKS } from "./constants";
/** /**
* Encapsulates font metrics with additional font metadata. * Encapsulates font metrics with additional font metadata.
@ -23,8 +20,6 @@ export interface FontMetadata {
/** harcoded unitless line-height, https://github.com/excalidraw/excalidraw/pull/6360#issuecomment-1477635971 */ /** harcoded unitless line-height, https://github.com/excalidraw/excalidraw/pull/6360#issuecomment-1477635971 */
lineHeight: number; lineHeight: number;
}; };
/** element to be displayed as an icon */
icon?: JSX.Element;
/** flag to indicate a deprecated font */ /** flag to indicate a deprecated font */
deprecated?: true; deprecated?: true;
/** flag to indicate a server-side only font */ /** flag to indicate a server-side only font */
@ -43,7 +38,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -374, descender: -374,
lineHeight: 1.25, lineHeight: 1.25,
}, },
icon: FreedrawIcon,
}, },
[FONT_FAMILY.Nunito]: { [FONT_FAMILY.Nunito]: {
metrics: { metrics: {
@ -52,7 +46,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -353, descender: -353,
lineHeight: 1.35, lineHeight: 1.35,
}, },
icon: FontFamilyNormalIcon,
}, },
[FONT_FAMILY["Lilita One"]]: { [FONT_FAMILY["Lilita One"]]: {
metrics: { metrics: {
@ -61,7 +54,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -220, descender: -220,
lineHeight: 1.15, lineHeight: 1.15,
}, },
icon: FontFamilyHeadingIcon,
}, },
[FONT_FAMILY["Comic Shanns"]]: { [FONT_FAMILY["Comic Shanns"]]: {
metrics: { metrics: {
@ -70,7 +62,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -250, descender: -250,
lineHeight: 1.25, lineHeight: 1.25,
}, },
icon: FontFamilyCodeIcon,
}, },
[FONT_FAMILY.Virgil]: { [FONT_FAMILY.Virgil]: {
metrics: { metrics: {
@ -79,7 +70,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -374, descender: -374,
lineHeight: 1.25, lineHeight: 1.25,
}, },
icon: FreedrawIcon,
deprecated: true, deprecated: true,
}, },
[FONT_FAMILY.Helvetica]: { [FONT_FAMILY.Helvetica]: {
@ -89,7 +79,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -471, descender: -471,
lineHeight: 1.15, lineHeight: 1.15,
}, },
icon: FontFamilyNormalIcon,
deprecated: true, deprecated: true,
local: true, local: true,
}, },
@ -100,7 +89,6 @@ export const FONT_METADATA: Record<number, FontMetadata> = {
descender: -480, descender: -480,
lineHeight: 1.2, lineHeight: 1.2,
}, },
icon: FontFamilyCodeIcon,
deprecated: true, deprecated: true,
}, },
[FONT_FAMILY["Liberation Sans"]]: { [FONT_FAMILY["Liberation Sans"]]: {
@ -149,3 +137,34 @@ export const GOOGLE_FONTS_RANGES = {
/** local protocol to skip the local font from registering or inlining */ /** local protocol to skip the local font from registering or inlining */
export const LOCAL_FONT_PROTOCOL = "local:"; export const LOCAL_FONT_PROTOCOL = "local:";
/**
* Calculates vertical offset for a text with alphabetic baseline.
*/
export const getVerticalOffset = (
fontFamily: ExcalidrawTextElement["fontFamily"],
fontSize: ExcalidrawTextElement["fontSize"],
lineHeightPx: number,
) => {
const { unitsPerEm, ascender, descender } =
FONT_METADATA[fontFamily]?.metrics ||
FONT_METADATA[FONT_FAMILY.Excalifont].metrics;
const fontSizeEm = fontSize / unitsPerEm;
const lineGap =
(lineHeightPx - fontSizeEm * ascender + fontSizeEm * descender) / 2;
const verticalOffset = fontSizeEm * ascender + lineGap;
return verticalOffset;
};
/**
* Gets line height for a selected family.
*/
export const getLineHeight = (fontFamily: FontFamilyValues) => {
const { lineHeight } =
FONT_METADATA[fontFamily]?.metrics ||
FONT_METADATA[FONT_FAMILY.Excalifont].metrics;
return lineHeight as ExcalidrawTextElement["lineHeight"];
};

View file

@ -0,0 +1,11 @@
export * from "./binary-heap";
export * from "./colors";
export * from "./constants";
export * from "./font-metadata";
export * from "./queue";
export * from "./keys";
export * from "./points";
export * from "./promise-pool";
export * from "./random";
export * from "./url";
export * from "./utils";

View file

@ -4,6 +4,8 @@ import {
type LocalPoint, type LocalPoint,
} from "@excalidraw/math"; } from "@excalidraw/math";
import type { NullableGridSize } from "@excalidraw/excalidraw/types";
export const getSizeFromPoints = ( export const getSizeFromPoints = (
points: readonly (GlobalPoint | LocalPoint)[], points: readonly (GlobalPoint | LocalPoint)[],
) => { ) => {
@ -61,3 +63,18 @@ export const rescalePoints = <Point extends GlobalPoint | LocalPoint>(
return nextPoints; return nextPoints;
}; };
// TODO: Rounding this point causes some shake when free drawing
export const getGridPoint = (
x: number,
y: number,
gridSize: NullableGridSize,
): [number, number] => {
if (gridSize) {
return [
Math.round(x / gridSize) * gridSize,
Math.round(y / gridSize) * gridSize,
];
}
return [x, y];
};

View file

@ -0,0 +1,50 @@
import Pool from "es6-promise-pool";
// extending the missing types
// relying on the [Index, T] to keep a correct order
type TPromisePool<T, Index = number> = Pool<[Index, T][]> & {
addEventListener: (
type: "fulfilled",
listener: (event: { data: { result: [Index, T] } }) => void,
) => (event: { data: { result: [Index, T] } }) => void;
removeEventListener: (
type: "fulfilled",
listener: (event: { data: { result: [Index, T] } }) => void,
) => void;
};
export class PromisePool<T> {
private readonly pool: TPromisePool<T>;
private readonly entries: Record<number, T> = {};
constructor(
source: IterableIterator<Promise<void | readonly [number, T]>>,
concurrency: number,
) {
this.pool = new Pool(
source as unknown as () => void | PromiseLike<[number, T][]>,
concurrency,
) as TPromisePool<T>;
}
public all() {
const listener = (event: { data: { result: void | [number, T] } }) => {
if (event.data.result) {
// by default pool does not return the results, so we are gathering them manually
// with the correct call order (represented by the index in the tuple)
const [index, value] = event.data.result;
this.entries[index] = value;
}
};
this.pool.addEventListener("fulfilled", listener);
return this.pool.start().then(() => {
setTimeout(() => {
this.pool.removeEventListener("fulfilled", listener);
});
return Object.values(this.entries);
});
}
}

View file

@ -1,7 +1,8 @@
import { promiseTry, resolvablePromise } from "./utils"; import { promiseTry, resolvablePromise } from ".";
import type { ResolvablePromise } from ".";
import type { MaybePromise } from "./utility-types"; import type { MaybePromise } from "./utility-types";
import type { ResolvablePromise } from "./utils";
type Job<T, TArgs extends unknown[]> = (...args: TArgs) => MaybePromise<T>; type Job<T, TArgs extends unknown[]> = (...args: TArgs) => MaybePromise<T>;

View file

@ -1,6 +1,6 @@
import { sanitizeUrl } from "@braintree/sanitize-url"; import { sanitizeUrl } from "@braintree/sanitize-url";
import { escapeDoubleQuotes } from "../utils"; import { escapeDoubleQuotes } from "./utils";
export const normalizeLink = (link: string) => { export const normalizeLink = (link: string) => {
link = link.trim(); link = link.trim();

View file

@ -1,30 +1,33 @@
import { average } from "@excalidraw/math"; import { average } from "@excalidraw/math";
import Pool from "es6-promise-pool";
import { COLOR_PALETTE } from "./colors";
import {
DEFAULT_VERSION,
FONT_FAMILY,
getFontFamilyFallbacks,
isDarwin,
WINDOWS_EMOJI_FALLBACK_FONT,
} from "./constants";
import type { EVENT } from "./constants";
import type { import type {
ExcalidrawBindableElement, ExcalidrawBindableElement,
FontFamilyValues, FontFamilyValues,
FontString, FontString,
} from "./element/types"; } from "@excalidraw/element/types";
import type { import type {
ActiveTool, ActiveTool,
AppState, AppState,
ToolType, ToolType,
UnsubscribeCallback, UnsubscribeCallback,
Zoom, Zoom,
} from "./types"; } from "@excalidraw/excalidraw/types";
import { COLOR_PALETTE } from "./colors";
import {
DEFAULT_VERSION,
ENV,
FONT_FAMILY,
getFontFamilyFallbacks,
isDarwin,
WINDOWS_EMOJI_FALLBACK_FONT,
} from "./constants";
import type { MaybePromise, ResolutionType } from "./utility-types"; import type { MaybePromise, ResolutionType } from "./utility-types";
import type { EVENT } from "./constants";
let mockDateTime: string | null = null; let mockDateTime: string | null = null;
export const setDateTimeForTests = (dateTime: string) => { export const setDateTimeForTests = (dateTime: string) => {
@ -730,9 +733,9 @@ export const arrayToList = <T>(array: readonly T[]): Node<T>[] =>
return acc; return acc;
}, [] as Node<T>[]); }, [] as Node<T>[]);
export const isTestEnv = () => import.meta.env.MODE === "test"; export const isTestEnv = () => import.meta.env.MODE === ENV.TEST;
export const isDevEnv = () => import.meta.env.MODE === "development"; export const isDevEnv = () => import.meta.env.MODE === ENV.DEVELOPMENT;
export const isServerEnv = () => export const isServerEnv = () =>
typeof process !== "undefined" && !!process?.env?.NODE_ENV; typeof process !== "undefined" && !!process?.env?.NODE_ENV;
@ -1186,54 +1189,6 @@ export const safelyParseJSON = (json: string): Record<string, any> | null => {
return null; return null;
} }
}; };
// extending the missing types
// relying on the [Index, T] to keep a correct order
type TPromisePool<T, Index = number> = Pool<[Index, T][]> & {
addEventListener: (
type: "fulfilled",
listener: (event: { data: { result: [Index, T] } }) => void,
) => (event: { data: { result: [Index, T] } }) => void;
removeEventListener: (
type: "fulfilled",
listener: (event: { data: { result: [Index, T] } }) => void,
) => void;
};
export class PromisePool<T> {
private readonly pool: TPromisePool<T>;
private readonly entries: Record<number, T> = {};
constructor(
source: IterableIterator<Promise<void | readonly [number, T]>>,
concurrency: number,
) {
this.pool = new Pool(
source as unknown as () => void | PromiseLike<[number, T][]>,
concurrency,
) as TPromisePool<T>;
}
public all() {
const listener = (event: { data: { result: void | [number, T] } }) => {
if (event.data.result) {
// by default pool does not return the results, so we are gathering them manually
// with the correct call order (represented by the index in the tuple)
const [index, value] = event.data.result;
this.entries[index] = value;
}
};
this.pool.addEventListener("fulfilled", listener);
return this.pool.start().then(() => {
setTimeout(() => {
this.pool.removeEventListener("fulfilled", listener);
});
return Object.values(this.entries);
});
}
}
/** /**
* use when you need to render unsafe string as HTML attribute, but MAKE SURE * use when you need to render unsafe string as HTML attribute, but MAKE SURE

View file

@ -1,4 +1,4 @@
import { KEYS, matchKey } from "./keys"; import { KEYS, matchKey } from "../src/keys";
describe("key matcher", async () => { describe("key matcher", async () => {
it("should not match unexpected key", async () => { it("should not match unexpected key", async () => {

View file

@ -1,4 +1,4 @@
import { Queue } from "./queue"; import { Queue } from "../src/queue";
describe("Queue", () => { describe("Queue", () => {
const calls: any[] = []; const calls: any[] = [];

View file

@ -1,4 +1,4 @@
import { normalizeLink } from "./url"; import { normalizeLink } from "../src/url";
describe("normalizeLink", () => { describe("normalizeLink", () => {
// NOTE not an extensive XSS test suite, just to check if we're not // NOTE not an extensive XSS test suite, just to check if we're not

View file

@ -0,0 +1,6 @@
{
"extends": "../tsconfig.base.json",
"compilerOptions": {
"outDir": "./dist/types"
}
}

View file

@ -0,0 +1,3 @@
{
"extends": ["../eslintrc.base.json"]
}

View file

@ -0,0 +1,19 @@
# @excalidraw/element
## Install
```bash
npm install @excalidraw/element
```
If you prefer Yarn over npm, use this command to install the Excalidraw utils package:
```bash
yarn add @excalidraw/element
```
With PNPM, similarly install the package with this command:
```bash
pnpm add @excalidraw/element
```

3
packages/element/global.d.ts vendored Normal file
View file

@ -0,0 +1,3 @@
/// <reference types="vite/client" />
import "@excalidraw/excalidraw/global";
import "@excalidraw/excalidraw/css";

View file

@ -0,0 +1,63 @@
{
"name": "@excalidraw/element",
"version": "0.1.0",
"type": "module",
"types": "./dist/types/element/index.d.ts",
"main": "./dist/prod/index.js",
"module": "./dist/prod/index.js",
"exports": {
".": {
"types": "./dist/types/element/index.d.ts",
"development": "./dist/dev/index.js",
"production": "./dist/prod/index.js",
"default": "./dist/prod/index.js"
},
"./*": {
"types": "./../element/dist/types/element/*"
}
},
"files": [
"dist/*"
],
"description": "Excalidraw elements-related logic",
"publishConfig": {
"access": "public"
},
"license": "MIT",
"keywords": [
"excalidraw",
"excalidraw-utils"
],
"browserslist": {
"production": [
">0.2%",
"not dead",
"not ie <= 11",
"not op_mini all",
"not safari < 12",
"not kaios <= 2.5",
"not edge < 79",
"not chrome < 70",
"not and_uc < 13",
"not samsung < 10"
],
"development": [
"last 1 chrome version",
"last 1 firefox version",
"last 1 safari version"
]
},
"dependencies": {
"fractional-indexing": "3.2.0",
"perfect-freehand": "1.2.0",
"points-on-curve": "1.0.1",
"roughjs": "4.6.4"
},
"devDependencies": {},
"bugs": "https://github.com/excalidraw/excalidraw/issues",
"repository": "https://github.com/excalidraw/excalidraw",
"scripts": {
"gen:types": "rm -rf types && tsc",
"build:esm": "rm -rf dist && node ../../scripts/buildBase.js && yarn gen:types"
}
}

View file

@ -1,21 +1,26 @@
import { pointFrom, pointDistance, type LocalPoint } from "@excalidraw/math";
import { simplify } from "points-on-curve"; import { simplify } from "points-on-curve";
import { ROUGHNESS } from "../constants"; import { pointFrom, pointDistance, type LocalPoint } from "@excalidraw/math";
import { getDiamondPoints, getArrowheadPoints } from "../element"; import { ROUGHNESS, isTransparent, assertNever } from "@excalidraw/common";
import { headingForPointIsHorizontal } from "../element/heading";
import type { Mutable } from "@excalidraw/common/utility-types";
import type { EmbedsValidationStatus } from "@excalidraw/excalidraw/types";
import type { ElementShapes } from "@excalidraw/excalidraw/scene/types";
import { import {
isElbowArrow, isElbowArrow,
isEmbeddableElement, isEmbeddableElement,
isIframeElement, isIframeElement,
isIframeLikeElement, isIframeLikeElement,
isLinearElement, isLinearElement,
} from "../element/typeChecks"; } from "./typeChecks";
import { generateFreeDrawShape } from "../renderer/renderElement"; import { getCornerRadius, isPathALoop } from "./shapes";
import { getCornerRadius, isPathALoop } from "../shapes"; import { headingForPointIsHorizontal } from "./heading";
import { isTransparent, assertNever } from "../utils";
import { canChangeRoundness } from "./comparisons"; import { canChangeRoundness } from "./comparisons";
import { generateFreeDrawShape } from "./renderElement";
import { getArrowheadPoints, getDiamondPoints } from "./bounds";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
@ -23,9 +28,8 @@ import type {
ExcalidrawSelectionElement, ExcalidrawSelectionElement,
ExcalidrawLinearElement, ExcalidrawLinearElement,
Arrowhead, Arrowhead,
} from "../element/types"; } from "./types";
import type { EmbedsValidationStatus } from "../types";
import type { ElementShapes } from "./types";
import type { Drawable, Options } from "roughjs/bin/core"; import type { Drawable, Options } from "roughjs/bin/core";
import type { RoughGenerator } from "roughjs/bin/generator"; import type { RoughGenerator } from "roughjs/bin/generator";
import type { Point as RoughPoint } from "roughjs/bin/geometry"; import type { Point as RoughPoint } from "roughjs/bin/geometry";
@ -511,7 +515,10 @@ export const _generateElementShape = (
if (isPathALoop(element.points)) { if (isPathALoop(element.points)) {
// generate rough polygon to fill freedraw shape // generate rough polygon to fill freedraw shape
const simplifiedPoints = simplify(element.points, 0.75); const simplifiedPoints = simplify(
element.points as Mutable<LocalPoint[]>,
0.75,
);
shape = generator.curve(simplifiedPoints as [number, number][], { shape = generator.curve(simplifiedPoints as [number, number][], {
...generateRoughOptions(element), ...generateRoughOptions(element),
stroke: "none", stroke: "none",

View file

@ -1,16 +1,22 @@
import { RoughGenerator } from "roughjs/bin/generator"; import { RoughGenerator } from "roughjs/bin/generator";
import { COLOR_PALETTE } from "../colors"; import { COLOR_PALETTE } from "@excalidraw/common";
import { elementWithCanvasCache } from "../renderer/renderElement";
import type {
AppState,
EmbedsValidationStatus,
} from "@excalidraw/excalidraw/types";
import type {
ElementShape,
ElementShapes,
} from "@excalidraw/excalidraw/scene/types";
import { _generateElementShape } from "./Shape"; import { _generateElementShape } from "./Shape";
import type { import { elementWithCanvasCache } from "./renderElement";
ExcalidrawElement,
ExcalidrawSelectionElement, import type { ExcalidrawElement, ExcalidrawSelectionElement } from "./types";
} from "../element/types";
import type { AppState, EmbedsValidationStatus } from "../types";
import type { ElementShape, ElementShapes } from "./types";
import type { Drawable } from "roughjs/bin/core"; import type { Drawable } from "roughjs/bin/core";
export class ShapeCache { export class ShapeCache {

View file

@ -1,11 +1,12 @@
import { updateBoundElements } from "./element/binding"; import type Scene from "@excalidraw/excalidraw/scene/Scene";
import { getCommonBoundingBox } from "./element/bounds";
import { mutateElement } from "./element/mutateElement"; import { updateBoundElements } from "./binding";
import { getCommonBoundingBox } from "./bounds";
import { mutateElement } from "./mutateElement";
import { getMaximumGroups } from "./groups"; import { getMaximumGroups } from "./groups";
import type { BoundingBox } from "./element/bounds"; import type { BoundingBox } from "./bounds";
import type { ElementsMap, ExcalidrawElement } from "./element/types"; import type { ElementsMap, ExcalidrawElement } from "./types";
import type Scene from "./scene/Scene";
export interface Alignment { export interface Alignment {
position: "start" | "center" | "end"; position: "start" | "center" | "end";

View file

@ -1,3 +1,13 @@
import {
KEYS,
arrayToMap,
isBindingFallthroughEnabled,
tupleToCoors,
invariant,
isDevEnv,
isTestEnv,
} from "@excalidraw/common";
import { import {
lineSegment, lineSegment,
pointFrom, pointFrom,
@ -15,20 +25,16 @@ import {
lineSegmentIntersectionPoints, lineSegmentIntersectionPoints,
PRECISION, PRECISION,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { isPointOnShape } from "@excalidraw/utils/collision"; import { isPointOnShape } from "@excalidraw/utils/collision";
import type { LocalPoint, Radians } from "@excalidraw/math"; import type { LocalPoint, Radians } from "@excalidraw/math";
import { KEYS } from "../keys"; import type Scene from "@excalidraw/excalidraw/scene/Scene";
import { aabbForElement, getElementShape, pointInsideBounds } from "../shapes";
import { import type { AppState } from "@excalidraw/excalidraw/types";
arrayToMap,
invariant, import type { Mutable } from "@excalidraw/common/utility-types";
isBindingFallthroughEnabled,
isDevEnv,
isTestEnv,
tupleToCoors,
} from "../utils";
import { import {
getCenterForBounds, getCenterForBounds,
@ -58,10 +64,9 @@ import {
isTextElement, isTextElement,
} from "./typeChecks"; } from "./typeChecks";
import { aabbForElement, getElementShape, pointInsideBounds } from "./shapes";
import { updateElbowArrowPoints } from "./elbowArrow"; import { updateElbowArrowPoints } from "./elbowArrow";
import type { Mutable } from "../utility-types";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { ElementUpdate } from "./mutateElement"; import type { ElementUpdate } from "./mutateElement";
import type { import type {
@ -81,8 +86,6 @@ import type {
SceneElementsMap, SceneElementsMap,
FixedPointBinding, FixedPointBinding,
} from "./types"; } from "./types";
import type Scene from "../scene/Scene";
import type { AppState } from "../types";
export type SuggestedBinding = export type SuggestedBinding =
| NonDeleted<ExcalidrawBindableElement> | NonDeleted<ExcalidrawBindableElement>

View file

@ -1,3 +1,7 @@
import rough from "roughjs/bin/rough";
import { rescalePoints, arrayToMap, invariant } from "@excalidraw/common";
import { import {
degreesToRadians, degreesToRadians,
lineSegment, lineSegment,
@ -6,8 +10,8 @@ import {
pointFromArray, pointFromArray,
pointRotateRads, pointRotateRads,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { getCurvePathOps } from "@excalidraw/utils/geometry/shape";
import rough from "roughjs/bin/rough"; import { getCurvePathOps } from "@excalidraw/utils/shape";
import type { import type {
Degrees, Degrees,
@ -17,11 +21,12 @@ import type {
Radians, Radians,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { rescalePoints } from "../points"; import type { AppState } from "@excalidraw/excalidraw/types";
import { generateRoughOptions } from "../scene/Shape";
import { ShapeCache } from "../scene/ShapeCache";
import { arrayToMap, invariant } from "../utils";
import type { Mutable } from "@excalidraw/common/utility-types";
import { ShapeCache } from "./ShapeCache";
import { generateRoughOptions } from "./Shape";
import { LinearElementEditor } from "./linearElementEditor"; import { LinearElementEditor } from "./linearElementEditor";
import { getBoundTextElement, getContainerElement } from "./textElement"; import { getBoundTextElement, getContainerElement } from "./textElement";
import { import {
@ -32,8 +37,6 @@ import {
isTextElement, isTextElement,
} from "./typeChecks"; } from "./typeChecks";
import type { AppState } from "../types";
import type { Mutable } from "../utility-types";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
ExcalidrawLinearElement, ExcalidrawLinearElement,

View file

@ -1,3 +1,4 @@
import { isTransparent } from "@excalidraw/common";
import { import {
curveIntersectLineSegment, curveIntersectLineSegment,
isPointWithinBounds, isPointWithinBounds,
@ -8,12 +9,14 @@ import {
pointRotateRads, pointRotateRads,
pointsEqual, pointsEqual,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { import {
ellipse, ellipse,
ellipseLineIntersectionPoints, ellipseLineIntersectionPoints,
} from "@excalidraw/math/ellipse"; } from "@excalidraw/math/ellipse";
import { isPointInShape, isPointOnShape } from "@excalidraw/utils/collision"; import { isPointInShape, isPointOnShape } from "@excalidraw/utils/collision";
import { getPolygonShape } from "@excalidraw/utils/geometry/shape"; import { getPolygonShape } from "@excalidraw/utils/shape";
import type { import type {
GlobalPoint, GlobalPoint,
@ -22,11 +25,12 @@ import type {
Polygon, Polygon,
Radians, Radians,
} from "@excalidraw/math"; } from "@excalidraw/math";
import type { GeometricShape } from "@excalidraw/utils/geometry/shape";
import { getBoundTextShape, isPathALoop } from "../shapes"; import type { GeometricShape } from "@excalidraw/utils/shape";
import { isTransparent } from "../utils";
import type { FrameNameBounds } from "@excalidraw/excalidraw/types";
import { getBoundTextShape, isPathALoop } from "./shapes";
import { getElementBounds } from "./bounds"; import { getElementBounds } from "./bounds";
import { import {
hasBoundTextElement, hasBoundTextElement,
@ -47,7 +51,6 @@ import type {
ExcalidrawRectangleElement, ExcalidrawRectangleElement,
ExcalidrawRectanguloidElement, ExcalidrawRectanguloidElement,
} from "./types"; } from "./types";
import type { FrameNameBounds } from "../types";
export const shouldTestInside = (element: ExcalidrawElement) => { export const shouldTestInside = (element: ExcalidrawElement) => {
if (element.type === "arrow") { if (element.type === "arrow") {

View file

@ -1,4 +1,4 @@
import type { ElementOrToolType } from "../types"; import type { ElementOrToolType } from "@excalidraw/excalidraw/types";
export const hasBackground = (type: ElementOrToolType) => export const hasBackground = (type: ElementOrToolType) =>
type === "rectangle" || type === "rectangle" ||

View file

@ -4,6 +4,7 @@ import {
pointFrom, pointFrom,
pointRotateRads, pointRotateRads,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { ellipse, ellipseDistanceFromPoint } from "@excalidraw/math/ellipse"; import { ellipse, ellipseDistanceFromPoint } from "@excalidraw/math/ellipse";
import type { GlobalPoint, Radians } from "@excalidraw/math"; import type { GlobalPoint, Radians } from "@excalidraw/math";

View file

@ -1,8 +1,9 @@
import { getCommonBoundingBox } from "./element/bounds"; import { getCommonBoundingBox } from "./bounds";
import { newElementWith } from "./element/mutateElement"; import { newElementWith } from "./mutateElement";
import { getMaximumGroups } from "./groups"; import { getMaximumGroups } from "./groups";
import type { ElementsMap, ExcalidrawElement } from "./element/types"; import type { ElementsMap, ExcalidrawElement } from "./types";
export interface Distribution { export interface Distribution {
space: "between"; space: "between";

View file

@ -1,6 +1,19 @@
import { TEXT_AUTOWRAP_THRESHOLD } from "../constants"; import {
import { getGridPoint } from "../snapping"; TEXT_AUTOWRAP_THRESHOLD,
import { getFontString } from "../utils"; getGridPoint,
getFontString,
} from "@excalidraw/common";
import type {
AppState,
NormalizedZoomValue,
NullableGridSize,
PointerDownState,
} from "@excalidraw/excalidraw/types";
import type Scene from "@excalidraw/excalidraw/scene/Scene";
import type { NonDeletedExcalidrawElement } from "@excalidraw/element/types";
import { updateBoundElements } from "./binding"; import { updateBoundElements } from "./binding";
import { getCommonBounds } from "./bounds"; import { getCommonBounds } from "./bounds";
@ -17,14 +30,7 @@ import {
} from "./typeChecks"; } from "./typeChecks";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { ExcalidrawElement, NonDeletedExcalidrawElement } from "./types"; import type { ExcalidrawElement } from "./types";
import type Scene from "../scene/Scene";
import type {
AppState,
NormalizedZoomValue,
NullableGridSize,
PointerDownState,
} from "../types";
export const dragSelectedElements = ( export const dragSelectedElements = (
pointerDownState: PointerDownState, pointerDownState: PointerDownState,

View file

@ -1,24 +1,28 @@
import { ORIG_ID } from "../constants";
import {
getElementsInGroup,
getNewGroupIdsForDuplication,
getSelectedGroupForElement,
} from "../groups";
import { randomId, randomInteger } from "../random";
import { import {
ORIG_ID,
randomId,
randomInteger,
arrayToMap, arrayToMap,
castArray, castArray,
findLastIndex, findLastIndex,
getUpdatedTimestamp, getUpdatedTimestamp,
isTestEnv, isTestEnv,
} from "../utils"; } from "@excalidraw/common";
import type { Mutable } from "@excalidraw/common/utility-types";
import type { AppState } from "@excalidraw/excalidraw/types";
import {
getElementsInGroup,
getNewGroupIdsForDuplication,
getSelectedGroupForElement,
} from "./groups";
import { import {
bindElementsToFramesAfterDuplication, bindElementsToFramesAfterDuplication,
getFrameChildren, getFrameChildren,
} from "../frame"; } from "./frame";
import { normalizeElementOrder } from "./sortElements"; import { normalizeElementOrder } from "./sortElements";
@ -34,9 +38,6 @@ import { getBoundTextElement, getContainerElement } from "./textElement";
import { fixBindingsAfterDuplication } from "./binding"; import { fixBindingsAfterDuplication } from "./binding";
import type { AppState } from "../types";
import type { Mutable } from "../utility-types";
import type { import type {
ElementsMap, ElementsMap,
ExcalidrawElement, ExcalidrawElement,

View file

@ -13,10 +13,16 @@ import {
type LocalPoint, type LocalPoint,
} from "@excalidraw/math"; } from "@excalidraw/math";
import BinaryHeap from "../binaryheap"; import {
import { getSizeFromPoints } from "../points"; BinaryHeap,
import { aabbForElement, pointInsideBounds } from "../shapes"; invariant,
import { invariant, isAnyTrue, isDevEnv, tupleToCoors } from "../utils"; isAnyTrue,
tupleToCoors,
getSizeFromPoints,
isDevEnv,
} from "@excalidraw/common";
import type { AppState } from "@excalidraw/excalidraw/types";
import { import {
bindPointToSnapToElementOutline, bindPointToSnapToElementOutline,
@ -47,6 +53,8 @@ import {
type SceneElementsMap, type SceneElementsMap,
} from "./types"; } from "./types";
import { aabbForElement, pointInsideBounds } from "./shapes";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { Heading } from "./heading"; import type { Heading } from "./heading";
import type { import type {
@ -57,7 +65,6 @@ import type {
FixedSegment, FixedSegment,
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
} from "./types"; } from "./types";
import type { AppState } from "../types";
type GridAddress = [number, number] & { _brand: "gridaddress" }; type GridAddress = [number, number] & { _brand: "gridaddress" };

View file

@ -2,11 +2,12 @@
* Create and link between shapes. * Create and link between shapes.
*/ */
import { ELEMENT_LINK_KEY } from "../constants"; import { ELEMENT_LINK_KEY, normalizeLink } from "@excalidraw/common";
import { normalizeLink } from "../data/url";
import { elementsAreInSameGroup } from "../groups"; import type { AppProps, AppState } from "@excalidraw/excalidraw/types";
import { elementsAreInSameGroup } from "./groups";
import type { AppProps, AppState } from "../types";
import type { ExcalidrawElement } from "./types"; import type { ExcalidrawElement } from "./types";
export const defaultGetElementLinkFromSelection: Exclude< export const defaultGetElementLinkFromSelection: Exclude<

View file

@ -1,15 +1,17 @@
import { register } from "../actions/register"; import {
import { FONT_FAMILY, VERTICAL_ALIGN } from "../constants"; FONT_FAMILY,
import { setCursorForShape } from "../cursor"; VERTICAL_ALIGN,
import { CaptureUpdateAction } from "../store"; escapeDoubleQuotes,
import { escapeDoubleQuotes, getFontString, updateActiveTool } from "../utils"; getFontString,
} from "@excalidraw/common";
import type { ExcalidrawProps } from "@excalidraw/excalidraw/types";
import type { MarkRequired } from "@excalidraw/common/utility-types";
import { newTextElement } from "./newElement"; import { newTextElement } from "./newElement";
import { wrapText } from "./textWrapping"; import { wrapText } from "./textWrapping";
import { isIframeElement } from "./typeChecks"; import { isIframeElement } from "./typeChecks";
import type { ExcalidrawProps } from "../types";
import type { MarkRequired } from "../utility-types";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
ExcalidrawIframeLikeElement, ExcalidrawIframeLikeElement,
@ -319,34 +321,6 @@ export const createPlaceholderEmbeddableLabel = (
}); });
}; };
export const actionSetEmbeddableAsActiveTool = register({
name: "setEmbeddableAsActiveTool",
trackEvent: { category: "toolbar" },
target: "Tool",
label: "toolBar.embeddable",
perform: (elements, appState, _, app) => {
const nextActiveTool = updateActiveTool(appState, {
type: "embeddable",
});
setCursorForShape(app.canvas, {
...appState,
activeTool: nextActiveTool,
});
return {
elements,
appState: {
...appState,
activeTool: updateActiveTool(appState, {
type: "embeddable",
}),
},
captureUpdate: CaptureUpdateAction.EVENTUALLY,
};
},
});
const matchHostname = ( const matchHostname = (
url: string, url: string,
/** using a Set assumes it already contains normalized bare domains */ /** using a Set assumes it already contains normalized bare domains */

View file

@ -1,9 +1,11 @@
import { KEYS, invariant, toBrandedType } from "@excalidraw/common";
import { type GlobalPoint, pointFrom, type LocalPoint } from "@excalidraw/math"; import { type GlobalPoint, pointFrom, type LocalPoint } from "@excalidraw/math";
import { elementOverlapsWithFrame, elementsAreInFrameBounds } from "../frame"; import type {
import { KEYS } from "../keys"; AppState,
import { aabbForElement } from "../shapes"; PendingExcalidrawElements,
import { invariant, toBrandedType } from "../utils"; } from "@excalidraw/excalidraw/types";
import { bindLinearElement } from "./binding"; import { bindLinearElement } from "./binding";
import { updateElbowArrowPoints } from "./elbowArrow"; import { updateElbowArrowPoints } from "./elbowArrow";
@ -19,6 +21,8 @@ import {
import { LinearElementEditor } from "./linearElementEditor"; import { LinearElementEditor } from "./linearElementEditor";
import { mutateElement } from "./mutateElement"; import { mutateElement } from "./mutateElement";
import { newArrowElement, newElement } from "./newElement"; import { newArrowElement, newElement } from "./newElement";
import { aabbForElement } from "./shapes";
import { elementsAreInFrameBounds, elementOverlapsWithFrame } from "./frame";
import { import {
isBindableElement, isBindableElement,
isElbowArrow, isElbowArrow,
@ -35,8 +39,6 @@ import {
type OrderedExcalidrawElement, type OrderedExcalidrawElement,
} from "./types"; } from "./types";
import type { AppState, PendingExcalidrawElements } from "../types";
type LinkDirection = "up" | "right" | "down" | "left"; type LinkDirection = "up" | "right" | "down" | "left";
const VERTICAL_OFFSET = 100; const VERTICAL_OFFSET = 100;

View file

@ -1,16 +1,20 @@
import { generateNKeysBetween } from "fractional-indexing"; import { generateNKeysBetween } from "fractional-indexing";
import { mutateElement } from "./element/mutateElement"; import { arrayToMap } from "@excalidraw/common";
import { getBoundTextElement } from "./element/textElement";
import { hasBoundTextElement } from "./element/typeChecks"; import { mutateElement } from "./mutateElement";
import { InvalidFractionalIndexError } from "./errors"; import { getBoundTextElement } from "./textElement";
import { arrayToMap } from "./utils"; import { hasBoundTextElement } from "./typeChecks";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
FractionalIndex, FractionalIndex,
OrderedExcalidrawElement, OrderedExcalidrawElement,
} from "./element/types"; } from "./types";
export class InvalidFractionalIndexError extends Error {
public code = "ELEMENT_HAS_INVALID_INDEX" as const;
}
/** /**
* Envisioned relation between array order and fractional indices: * Envisioned relation between array order and fractional indices:

View file

@ -1,24 +1,33 @@
import { arrayToMap } from "@excalidraw/common";
import { isPointWithinBounds, pointFrom } from "@excalidraw/math"; import { isPointWithinBounds, pointFrom } from "@excalidraw/math";
import { import { doLineSegmentsIntersect } from "@excalidraw/utils/bbox";
doLineSegmentsIntersect, import { elementsOverlappingBBox } from "@excalidraw/utils/withinBounds";
elementsOverlappingBBox,
} from "@excalidraw/utils"; import type { ExcalidrawElementsIncludingDeleted } from "@excalidraw/excalidraw/scene/Scene";
import type {
AppClassProperties,
AppState,
StaticCanvasAppState,
} from "@excalidraw/excalidraw/types";
import type { ReadonlySetLike } from "@excalidraw/common/utility-types";
import { getElementsWithinSelection, getSelectedElements } from "./selection";
import { getElementsInGroup, selectGroupsFromGivenElements } from "./groups";
import { import {
getElementLineSegments,
getCommonBounds, getCommonBounds,
getElementAbsoluteCoords, getElementAbsoluteCoords,
isTextElement, } from "./bounds";
} from "./element"; import { mutateElement } from "./mutateElement";
import { getElementLineSegments } from "./element/bounds"; import { getBoundTextElement, getContainerElement } from "./textElement";
import { mutateElement } from "./element/mutateElement";
import { import {
getBoundTextElement, isFrameElement,
getContainerElement, isFrameLikeElement,
} from "./element/textElement"; isTextElement,
import { isFrameElement, isFrameLikeElement } from "./element/typeChecks"; } from "./typeChecks";
import { getElementsInGroup, selectGroupsFromGivenElements } from "./groups";
import { getElementsWithinSelection, getSelectedElements } from "./scene";
import { arrayToMap } from "./utils";
import type { import type {
ElementsMap, ElementsMap,
@ -27,14 +36,7 @@ import type {
ExcalidrawFrameLikeElement, ExcalidrawFrameLikeElement,
NonDeleted, NonDeleted,
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
} from "./element/types";
import type { ExcalidrawElementsIncludingDeleted } from "./scene/Scene";
import type {
AppClassProperties,
AppState,
StaticCanvasAppState,
} from "./types"; } from "./types";
import type { ReadonlySetLike } from "./utility-types";
// --------------------------- Frame State ------------------------------------ // --------------------------- Frame State ------------------------------------
export const bindElementsToFramesAfterDuplication = ( export const bindElementsToFramesAfterDuplication = (

View file

@ -1,6 +1,13 @@
import { getBoundTextElement } from "./element/textElement"; import type {
import { getSelectedElements } from "./scene"; AppClassProperties,
import { makeNextSelectedElementIds } from "./scene/selection"; AppState,
InteractiveCanvasAppState,
} from "@excalidraw/excalidraw/types";
import type { Mutable } from "@excalidraw/common/utility-types";
import { getBoundTextElement } from "./textElement";
import { makeNextSelectedElementIds, getSelectedElements } from "./selection";
import type { import type {
GroupId, GroupId,
@ -9,13 +16,7 @@ import type {
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
ElementsMapOrArray, ElementsMapOrArray,
ElementsMap, ElementsMap,
} from "./element/types";
import type {
AppClassProperties,
AppState,
InteractiveCanvasAppState,
} from "./types"; } from "./types";
import type { Mutable } from "./utility-types";
export const selectGroup = ( export const selectGroup = (
groupId: GroupId, groupId: GroupId,
@ -297,24 +298,6 @@ export const getSelectedGroupIdForElement = (
selectedGroupIds: { [groupId: string]: boolean }, selectedGroupIds: { [groupId: string]: boolean },
) => element.groupIds.find((groupId) => selectedGroupIds[groupId]); ) => element.groupIds.find((groupId) => selectedGroupIds[groupId]);
export const getNewGroupIdsForDuplication = (
groupIds: ExcalidrawElement["groupIds"],
editingGroupId: AppState["editingGroupId"],
mapper: (groupId: GroupId) => GroupId,
) => {
const copy = [...groupIds];
const positionOfEditingGroupId = editingGroupId
? groupIds.indexOf(editingGroupId)
: -1;
const endIndex =
positionOfEditingGroupId > -1 ? positionOfEditingGroupId : groupIds.length;
for (let index = 0; index < endIndex; index++) {
copy[index] = mapper(copy[index]);
}
return copy;
};
export const addToGroup = ( export const addToGroup = (
prevGroupIds: ExcalidrawElement["groupIds"], prevGroupIds: ExcalidrawElement["groupIds"],
newGroupId: GroupId, newGroupId: GroupId,
@ -401,3 +384,21 @@ export const elementsAreInSameGroup = (
export const isInGroup = (element: NonDeletedExcalidrawElement) => { export const isInGroup = (element: NonDeletedExcalidrawElement) => {
return element.groupIds.length > 0; return element.groupIds.length > 0;
}; };
export const getNewGroupIdsForDuplication = (
groupIds: ExcalidrawElement["groupIds"],
editingGroupId: AppState["editingGroupId"],
mapper: (groupId: GroupId) => GroupId,
) => {
const copy = [...groupIds];
const positionOfEditingGroupId = editingGroupId
? groupIds.indexOf(editingGroupId)
: -1;
const endIndex =
positionOfEditingGroupId > -1 ? positionOfEditingGroupId : groupIds.length;
for (let index = 0; index < endIndex; index++) {
copy[index] = mapper(copy[index]);
}
return copy;
};

View file

@ -2,11 +2,16 @@
// ExcalidrawImageElement & related helpers // ExcalidrawImageElement & related helpers
// ----------------------------------------------------------------------------- // -----------------------------------------------------------------------------
import { MIME_TYPES, SVG_NS } from "../constants"; import { MIME_TYPES, SVG_NS } from "@excalidraw/common";
import type {
AppClassProperties,
DataURL,
BinaryFiles,
} from "@excalidraw/excalidraw/types";
import { isInitializedImageElement } from "./typeChecks"; import { isInitializedImageElement } from "./typeChecks";
import type { AppClassProperties, DataURL, BinaryFiles } from "../types";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
FileId, FileId,

View file

@ -7,56 +7,6 @@ import type {
NonDeleted, NonDeleted,
} from "./types"; } from "./types";
export {
newElement,
newTextElement,
refreshTextDimensions,
newLinearElement,
newArrowElement,
newImageElement,
} from "./newElement";
export { duplicateElement } from "./duplicate";
export {
getElementAbsoluteCoords,
getElementBounds,
getCommonBounds,
getDiamondPoints,
getArrowheadPoints,
getClosestElementBounds,
} from "./bounds";
export {
OMIT_SIDES_FOR_MULTIPLE_ELEMENTS,
getTransformHandlesFromCoords,
getTransformHandles,
} from "./transformHandles";
export {
resizeTest,
getCursorForResizingElement,
getElementWithTransformHandleType,
getTransformHandleTypeFromCoords,
} from "./resizeTest";
export {
transformElements,
getResizeOffsetXY,
getResizeArrowDirection,
} from "./resizeElements";
export {
dragSelectedElements,
getDragOffsetXY,
dragNewElement,
} from "./dragElements";
export { isTextElement, isExcalidrawElement } from "./typeChecks";
export { redrawTextBoundingBox, getTextFromElements } from "./textElement";
export {
getPerfectElementSize,
getLockedLinearCursorAlignSize,
isInvisiblySmallElement,
resizePerfectLineForNWHandler,
getNormalizedDimensions,
} from "./sizeHelpers";
export { showSelectedShapeActions } from "./showSelectedShapeActions";
/** /**
* @deprecated unsafe, use hashElementsVersion instead * @deprecated unsafe, use hashElementsVersion instead
*/ */

View file

@ -8,34 +8,50 @@ import {
pointDistance, pointDistance,
vectorFromPoint, vectorFromPoint,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { getCurvePathOps } from "@excalidraw/utils/geometry/shape";
import { getCurvePathOps } from "@excalidraw/utils/shape";
import {
DRAGGING_THRESHOLD,
KEYS,
shouldRotateWithDiscreteAngle,
getGridPoint,
invariant,
tupleToCoors,
} from "@excalidraw/common";
// TODO: remove direct dependency on the scene, should be passed in or injected instead
// eslint-disable-next-line @typescript-eslint/no-restricted-imports
import Scene from "@excalidraw/excalidraw/scene/Scene";
import type { Store } from "@excalidraw/excalidraw/store";
import type { Radians } from "@excalidraw/math"; import type { Radians } from "@excalidraw/math";
import { DRAGGING_THRESHOLD } from "../constants"; import type {
import { KEYS, shouldRotateWithDiscreteAngle } from "../keys"; AppState,
import { ShapeCache } from "../scene/ShapeCache"; PointerCoords,
import { InteractiveCanvasAppState,
getBezierCurveLength, AppClassProperties,
getBezierXY, NullableGridSize,
getControlPointsForBezierCurve, Zoom,
isPathALoop, } from "@excalidraw/excalidraw/types";
mapIntervalToBezierT,
} from "../shapes";
import { getGridPoint } from "../snapping";
import { invariant, tupleToCoors } from "../utils";
import Scene from "../scene/Scene"; import type { Mutable } from "@excalidraw/common/utility-types";
import { import {
bindOrUnbindLinearElement, bindOrUnbindLinearElement,
getHoveredElementForBinding, getHoveredElementForBinding,
isBindingEnabled, isBindingEnabled,
} from "./binding"; } from "./binding";
import {
getElementAbsoluteCoords,
getElementPointsCoords,
getMinMaxXYFromCurvePathOps,
} from "./bounds";
import { updateElbowArrowPoints } from "./elbowArrow"; import { updateElbowArrowPoints } from "./elbowArrow";
import { getElementPointsCoords, getMinMaxXYFromCurvePathOps } from "./bounds";
import { headingIsHorizontal, vectorToHeading } from "./heading"; import { headingIsHorizontal, vectorToHeading } from "./heading";
import { bumpVersion, mutateElement } from "./mutateElement"; import { bumpVersion, mutateElement } from "./mutateElement";
import { getBoundTextElement, handleBindTextResize } from "./textElement"; import { getBoundTextElement, handleBindTextResize } from "./textElement";
@ -45,7 +61,17 @@ import {
isFixedPointBinding, isFixedPointBinding,
} from "./typeChecks"; } from "./typeChecks";
import { getElementAbsoluteCoords, getLockedLinearCursorAlignSize } from "."; import { ShapeCache } from "./ShapeCache";
import {
isPathALoop,
getBezierCurveLength,
getControlPointsForBezierCurve,
mapIntervalToBezierT,
getBezierXY,
} from "./shapes";
import { getLockedLinearCursorAlignSize } from "./sizeHelpers";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { import type {
@ -62,17 +88,6 @@ import type {
FixedSegment, FixedSegment,
ExcalidrawElbowArrowElement, ExcalidrawElbowArrowElement,
} from "./types"; } from "./types";
import type { Store } from "../store";
import type {
AppState,
PointerCoords,
InteractiveCanvasAppState,
AppClassProperties,
NullableGridSize,
Zoom,
} from "../types";
import type { Mutable } from "../utility-types";
const editorMidPointsCache: { const editorMidPointsCache: {
version: number | null; version: number | null;

View file

@ -1,16 +1,24 @@
import {
getSizeFromPoints,
randomInteger,
getUpdatedTimestamp,
toBrandedType,
} from "@excalidraw/common";
// TODO: remove direct dependency on the scene, should be passed in or injected instead
// eslint-disable-next-line @typescript-eslint/no-restricted-imports
import Scene from "@excalidraw/excalidraw/scene/Scene";
import type { Radians } from "@excalidraw/math"; import type { Radians } from "@excalidraw/math";
import { getSizeFromPoints } from "../points"; import type { Mutable } from "@excalidraw/common/utility-types";
import { randomInteger } from "../random";
import Scene from "../scene/Scene"; import { ShapeCache } from "./ShapeCache";
import { ShapeCache } from "../scene/ShapeCache";
import { getUpdatedTimestamp, toBrandedType } from "../utils";
import { updateElbowArrowPoints } from "./elbowArrow"; import { updateElbowArrowPoints } from "./elbowArrow";
import { isElbowArrow } from "./typeChecks"; import { isElbowArrow } from "./typeChecks";
import type { ExcalidrawElement, NonDeletedSceneElementsMap } from "./types"; import type { ExcalidrawElement, NonDeletedSceneElementsMap } from "./types";
import type { Mutable } from "../utility-types";
export type ElementUpdate<TElement extends ExcalidrawElement> = Omit< export type ElementUpdate<TElement extends ExcalidrawElement> = Omit<
Partial<TElement>, Partial<TElement>,

View file

@ -1,5 +1,3 @@
import type { Radians } from "@excalidraw/math";
import { import {
DEFAULT_ELEMENT_PROPS, DEFAULT_ELEMENT_PROPS,
DEFAULT_FONT_FAMILY, DEFAULT_FONT_FAMILY,
@ -7,20 +5,26 @@ import {
DEFAULT_TEXT_ALIGN, DEFAULT_TEXT_ALIGN,
DEFAULT_VERTICAL_ALIGN, DEFAULT_VERTICAL_ALIGN,
VERTICAL_ALIGN, VERTICAL_ALIGN,
} from "../constants"; randomInteger,
import { getLineHeight } from "../fonts"; randomId,
import { randomInteger, randomId } from "../random"; getFontString,
getUpdatedTimestamp,
getLineHeight,
} from "@excalidraw/common";
import { getFontString, getUpdatedTimestamp } from "../utils"; import type { Radians } from "@excalidraw/math";
import { getResizedElementAbsoluteCoords } from "./bounds"; import type { MarkOptional, Merge } from "@excalidraw/common/utility-types";
import {
getElementAbsoluteCoords,
getResizedElementAbsoluteCoords,
} from "./bounds";
import { newElementWith } from "./mutateElement"; import { newElementWith } from "./mutateElement";
import { getBoundTextMaxWidth } from "./textElement"; import { getBoundTextMaxWidth } from "./textElement";
import { normalizeText, measureText } from "./textMeasurements"; import { normalizeText, measureText } from "./textMeasurements";
import { wrapText } from "./textWrapping"; import { wrapText } from "./textWrapping";
import { getElementAbsoluteCoords } from ".";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
ExcalidrawImageElement, ExcalidrawImageElement,
@ -43,7 +47,6 @@ import type {
FixedSegment, FixedSegment,
ExcalidrawElbowArrowElement, ExcalidrawElbowArrowElement,
} from "./types"; } from "./types";
import type { MarkOptional, Merge } from "../utility-types";
export type ElementConstructorOpts = MarkOptional< export type ElementConstructorOpts = MarkOptional<
Omit<ExcalidrawGenericElement, "id" | "type" | "isDeleted" | "updated">, Omit<ExcalidrawGenericElement, "id" | "type" | "isDeleted" | "updated">,

View file

@ -1,8 +1,8 @@
import { isRightAngleRads } from "@excalidraw/math";
import { getStroke } from "perfect-freehand";
import rough from "roughjs/bin/rough"; import rough from "roughjs/bin/rough";
import { getStroke } from "perfect-freehand";
import { isRightAngleRads } from "@excalidraw/math";
import { getDefaultAppState } from "../appState";
import { import {
BOUND_TEXT_PADDING, BOUND_TEXT_PADDING,
DEFAULT_REDUCED_GLOBAL_ALPHA, DEFAULT_REDUCED_GLOBAL_ALPHA,
@ -10,18 +10,39 @@ import {
FRAME_STYLE, FRAME_STYLE,
MIME_TYPES, MIME_TYPES,
THEME, THEME,
} from "../constants"; distance,
import { getElementAbsoluteCoords } from "../element/bounds"; getFontString,
import { getUncroppedImageElement } from "../element/cropElement"; isRTL,
import { LinearElementEditor } from "../element/linearElementEditor"; getVerticalOffset,
} from "@excalidraw/common";
import type {
AppState,
StaticCanvasAppState,
Zoom,
InteractiveCanvasAppState,
ElementsPendingErasure,
PendingExcalidrawElements,
NormalizedZoomValue,
} from "@excalidraw/excalidraw/types";
import type {
StaticCanvasRenderConfig,
RenderableElementsMap,
InteractiveCanvasRenderConfig,
} from "@excalidraw/excalidraw/scene/types";
import { getElementAbsoluteCoords } from "./bounds";
import { getUncroppedImageElement } from "./cropElement";
import { LinearElementEditor } from "./linearElementEditor";
import { import {
getBoundTextElement, getBoundTextElement,
getContainerCoords, getContainerCoords,
getContainerElement, getContainerElement,
getBoundTextMaxHeight, getBoundTextMaxHeight,
getBoundTextMaxWidth, getBoundTextMaxWidth,
} from "../element/textElement"; } from "./textElement";
import { getLineHeightInPx } from "../element/textMeasurements"; import { getLineHeightInPx } from "./textMeasurements";
import { import {
isTextElement, isTextElement,
isLinearElement, isLinearElement,
@ -31,12 +52,11 @@ import {
hasBoundTextElement, hasBoundTextElement,
isMagicFrameElement, isMagicFrameElement,
isImageElement, isImageElement,
} from "../element/typeChecks"; } from "./typeChecks";
import { getVerticalOffset } from "../fonts"; import { getContainingFrame } from "./frame";
import { getContainingFrame } from "../frame"; import { getCornerRadius } from "./shapes";
import { ShapeCache } from "../scene/ShapeCache";
import { getCornerRadius } from "../shapes"; import { ShapeCache } from "./ShapeCache";
import { distance, getFontString, isRTL } from "../utils";
import type { import type {
ExcalidrawElement, ExcalidrawElement,
@ -48,20 +68,8 @@ import type {
ExcalidrawFrameLikeElement, ExcalidrawFrameLikeElement,
NonDeletedSceneElementsMap, NonDeletedSceneElementsMap,
ElementsMap, ElementsMap,
} from "../element/types"; } from "./types";
import type {
StaticCanvasRenderConfig,
RenderableElementsMap,
InteractiveCanvasRenderConfig,
} from "../scene/types";
import type {
AppState,
StaticCanvasAppState,
Zoom,
InteractiveCanvasAppState,
ElementsPendingErasure,
PendingExcalidrawElements,
} from "../types";
import type { StrokeOptions } from "perfect-freehand"; import type { StrokeOptions } from "perfect-freehand";
import type { RoughCanvas } from "roughjs/bin/canvas"; import type { RoughCanvas } from "roughjs/bin/canvas";
@ -72,8 +80,6 @@ import type { RoughCanvas } from "roughjs/bin/canvas";
export const IMAGE_INVERT_FILTER = export const IMAGE_INVERT_FILTER =
"invert(100%) hue-rotate(180deg) saturate(1.25)"; "invert(100%) hue-rotate(180deg) saturate(1.25)";
const defaultAppState = getDefaultAppState();
const isPendingImageElement = ( const isPendingImageElement = (
element: ExcalidrawElement, element: ExcalidrawElement,
renderConfig: StaticCanvasRenderConfig, renderConfig: StaticCanvasRenderConfig,
@ -533,7 +539,11 @@ const generateElementWithCanvas = (
renderConfig: StaticCanvasRenderConfig, renderConfig: StaticCanvasRenderConfig,
appState: StaticCanvasAppState, appState: StaticCanvasAppState,
) => { ) => {
const zoom: Zoom = renderConfig ? appState.zoom : defaultAppState.zoom; const zoom: Zoom = renderConfig
? appState.zoom
: {
value: 1 as NormalizedZoomValue,
};
const prevElementWithCanvas = elementWithCanvasCache.get(element); const prevElementWithCanvas = elementWithCanvasCache.get(element);
const shouldRegenerateBecauseZoom = const shouldRegenerateBecauseZoom =
prevElementWithCanvas && prevElementWithCanvas &&

View file

@ -8,12 +8,20 @@ import {
type LocalPoint, type LocalPoint,
} from "@excalidraw/math"; } from "@excalidraw/math";
import {
MIN_FONT_SIZE,
SHIFT_LOCKING_ANGLE,
rescalePoints,
getFontString,
} from "@excalidraw/common";
import type { GlobalPoint } from "@excalidraw/math"; import type { GlobalPoint } from "@excalidraw/math";
import { MIN_FONT_SIZE, SHIFT_LOCKING_ANGLE } from "../constants"; import type Scene from "@excalidraw/excalidraw/scene/Scene";
import { isInGroup } from "../groups";
import { rescalePoints } from "../points"; import type { PointerDownState } from "@excalidraw/excalidraw/types";
import { getFontString } from "../utils";
import type { Mutable } from "@excalidraw/common/utility-types";
import { getArrowLocalFixedPoints, updateBoundElements } from "./binding"; import { getArrowLocalFixedPoints, updateBoundElements } from "./binding";
import { import {
@ -50,6 +58,8 @@ import {
isTextElement, isTextElement,
} from "./typeChecks"; } from "./typeChecks";
import { isInGroup } from "./groups";
import type { BoundingBox } from "./bounds"; import type { BoundingBox } from "./bounds";
import type { import type {
MaybeTransformHandleType, MaybeTransformHandleType,
@ -67,9 +77,6 @@ import type {
SceneElementsMap, SceneElementsMap,
ExcalidrawElbowArrowElement, ExcalidrawElbowArrowElement,
} from "./types"; } from "./types";
import type Scene from "../scene/Scene";
import type { PointerDownState } from "../types";
import type { Mutable } from "../utility-types";
// Returns true when transform (resizing/rotation) happened // Returns true when transform (resizing/rotation) happened
export const transformElements = ( export const transformElements = (

View file

@ -5,9 +5,11 @@ import {
type Radians, type Radians,
} from "@excalidraw/math"; } from "@excalidraw/math";
import { SIDE_RESIZING_THRESHOLD } from "@excalidraw/common";
import type { GlobalPoint, LineSegment, LocalPoint } from "@excalidraw/math"; import type { GlobalPoint, LineSegment, LocalPoint } from "@excalidraw/math";
import { SIDE_RESIZING_THRESHOLD } from "../constants"; import type { AppState, Device, Zoom } from "@excalidraw/excalidraw/types";
import { getElementAbsoluteCoords } from "./bounds"; import { getElementAbsoluteCoords } from "./bounds";
import { import {
@ -18,7 +20,6 @@ import {
} from "./transformHandles"; } from "./transformHandles";
import { isImageElement, isLinearElement } from "./typeChecks"; import { isImageElement, isLinearElement } from "./typeChecks";
import type { AppState, Device, Zoom } from "../types";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { import type {
TransformHandleType, TransformHandleType,

View file

@ -1,20 +1,25 @@
import { getElementAbsoluteCoords, getElementBounds } from "../element"; import { isShallowEqual } from "@excalidraw/common";
import { isElementInViewport } from "../element/sizeHelpers";
import { isBoundToContainer, isFrameLikeElement } from "../element/typeChecks"; import type {
AppState,
InteractiveCanvasAppState,
} from "@excalidraw/excalidraw/types";
import { getElementAbsoluteCoords, getElementBounds } from "./bounds";
import { isElementInViewport } from "./sizeHelpers";
import { isBoundToContainer, isFrameLikeElement } from "./typeChecks";
import { import {
elementOverlapsWithFrame, elementOverlapsWithFrame,
getContainingFrame, getContainingFrame,
getFrameChildren, getFrameChildren,
} from "../frame"; } from "./frame";
import { isShallowEqual } from "../utils";
import type { import type {
ElementsMap, ElementsMap,
ElementsMapOrArray, ElementsMapOrArray,
ExcalidrawElement, ExcalidrawElement,
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
} from "../element/types"; } from "./types";
import type { AppState, InteractiveCanvasAppState } from "../types";
/** /**
* Frames and their containing elements are not to be selected at the same time. * Frames and their containing elements are not to be selected at the same time.

View file

@ -1,3 +1,10 @@
import {
DEFAULT_ADAPTIVE_RADIUS,
DEFAULT_PROPORTIONAL_RADIUS,
LINE_CONFIRM_THRESHOLD,
ROUNDNESS,
invariant,
} from "@excalidraw/common";
import { import {
isPoint, isPoint,
pointFrom, pointFrom,
@ -16,131 +23,26 @@ import {
getFreedrawShape, getFreedrawShape,
getPolygonShape, getPolygonShape,
type GeometricShape, type GeometricShape,
} from "@excalidraw/utils/geometry/shape"; } from "@excalidraw/utils/shape";
import { import type { NormalizedZoomValue, Zoom } from "@excalidraw/excalidraw/types";
ArrowIcon,
DiamondIcon, import { shouldTestInside } from "./collision";
EllipseIcon, import { LinearElementEditor } from "./linearElementEditor";
EraserIcon, import { getBoundTextElement } from "./textElement";
FreedrawIcon, import { ShapeCache } from "./ShapeCache";
ImageIcon,
LineIcon, import { getElementAbsoluteCoords, type Bounds } from "./bounds";
RectangleIcon,
SelectionIcon,
TextIcon,
} from "./components/icons";
import {
DEFAULT_ADAPTIVE_RADIUS,
DEFAULT_PROPORTIONAL_RADIUS,
LINE_CONFIRM_THRESHOLD,
ROUNDNESS,
} from "./constants";
import { getElementAbsoluteCoords } from "./element";
import { shouldTestInside } from "./element/collision";
import { LinearElementEditor } from "./element/linearElementEditor";
import { getBoundTextElement } from "./element/textElement";
import { KEYS } from "./keys";
import { ShapeCache } from "./scene/ShapeCache";
import { invariant } from "./utils";
import type { Bounds } from "./element/bounds";
import type { import type {
ElementsMap, ElementsMap,
ExcalidrawElement, ExcalidrawElement,
ExcalidrawLinearElement, ExcalidrawLinearElement,
NonDeleted, NonDeleted,
} from "./element/types"; } from "./types";
import type { NormalizedZoomValue, Zoom } from "./types";
export const SHAPES = [
{
icon: SelectionIcon,
value: "selection",
key: KEYS.V,
numericKey: KEYS["1"],
fillable: true,
},
{
icon: RectangleIcon,
value: "rectangle",
key: KEYS.R,
numericKey: KEYS["2"],
fillable: true,
},
{
icon: DiamondIcon,
value: "diamond",
key: KEYS.D,
numericKey: KEYS["3"],
fillable: true,
},
{
icon: EllipseIcon,
value: "ellipse",
key: KEYS.O,
numericKey: KEYS["4"],
fillable: true,
},
{
icon: ArrowIcon,
value: "arrow",
key: KEYS.A,
numericKey: KEYS["5"],
fillable: true,
},
{
icon: LineIcon,
value: "line",
key: KEYS.L,
numericKey: KEYS["6"],
fillable: true,
},
{
icon: FreedrawIcon,
value: "freedraw",
key: [KEYS.P, KEYS.X],
numericKey: KEYS["7"],
fillable: false,
},
{
icon: TextIcon,
value: "text",
key: KEYS.T,
numericKey: KEYS["8"],
fillable: false,
},
{
icon: ImageIcon,
value: "image",
key: null,
numericKey: KEYS["9"],
fillable: false,
},
{
icon: EraserIcon,
value: "eraser",
key: KEYS.E,
numericKey: KEYS["0"],
fillable: false,
},
] as const;
export const findShapeByKey = (key: string) => {
const shape = SHAPES.find((shape, index) => {
return (
(shape.numericKey != null && key === shape.numericKey.toString()) ||
(shape.key &&
(typeof shape.key === "string"
? shape.key === key
: (shape.key as readonly string[]).includes(key)))
);
});
return shape?.value || null;
};
/** /**
* get the pure geometric shape of an excalidraw element * get the pure geometric shape of an excalidraw elementw
* which is then used for hit detection * which is then used for hit detection
*/ */
export const getElementShape = <Point extends GlobalPoint | LocalPoint>( export const getElementShape = <Point extends GlobalPoint | LocalPoint>(

View file

@ -1,6 +1,7 @@
import { getSelectedElements } from "../scene"; import type { UIAppState } from "@excalidraw/excalidraw/types";
import { getSelectedElements } from "./selection";
import type { UIAppState } from "../types";
import type { NonDeletedExcalidrawElement } from "./types"; import type { NonDeletedExcalidrawElement } from "./types";
export const showSelectedShapeActions = ( export const showSelectedShapeActions = (

View file

@ -1,12 +1,15 @@
import { SHIFT_LOCKING_ANGLE } from "../constants"; import {
import { viewportCoordsToSceneCoords } from "../utils"; SHIFT_LOCKING_ANGLE,
viewportCoordsToSceneCoords,
} from "@excalidraw/common";
import type { AppState, Offsets, Zoom } from "@excalidraw/excalidraw/types";
import { getCommonBounds, getElementBounds } from "./bounds"; import { getCommonBounds, getElementBounds } from "./bounds";
import { mutateElement } from "./mutateElement"; import { mutateElement } from "./mutateElement";
import { isFreeDrawElement, isLinearElement } from "./typeChecks"; import { isFreeDrawElement, isLinearElement } from "./typeChecks";
import type { ElementsMap, ExcalidrawElement } from "./types"; import type { ElementsMap, ExcalidrawElement } from "./types";
import type { AppState, Offsets, Zoom } from "../types";
// TODO: remove invisible elements consistently actions, so that invisible elements are not recorded by the store, exported, broadcasted or persisted // TODO: remove invisible elements consistently actions, so that invisible elements are not recorded by the store, exported, broadcasted or persisted
// - perhaps could be as part of a standalone 'cleanup' action, in addition to 'finalize' // - perhaps could be as part of a standalone 'cleanup' action, in addition to 'finalize'

View file

@ -1,4 +1,4 @@
import { arrayToMapWithIndex } from "../utils"; import { arrayToMapWithIndex } from "@excalidraw/common";
import type { ExcalidrawElement } from "./types"; import type { ExcalidrawElement } from "./types";

View file

@ -5,8 +5,12 @@ import {
DEFAULT_FONT_SIZE, DEFAULT_FONT_SIZE,
TEXT_ALIGN, TEXT_ALIGN,
VERTICAL_ALIGN, VERTICAL_ALIGN,
} from "../constants"; getFontString,
import { getFontString } from "../utils"; } from "@excalidraw/common";
import type { AppState } from "@excalidraw/excalidraw/types";
import type { ExtractSetType } from "@excalidraw/common/utility-types";
import { import {
resetOriginalContainerCache, resetOriginalContainerCache,
@ -16,9 +20,11 @@ import { LinearElementEditor } from "./linearElementEditor";
import { mutateElement } from "./mutateElement"; import { mutateElement } from "./mutateElement";
import { measureText } from "./textMeasurements"; import { measureText } from "./textMeasurements";
import { wrapText } from "./textWrapping"; import { wrapText } from "./textWrapping";
import { isBoundToContainer, isArrowElement } from "./typeChecks"; import {
isBoundToContainer,
import { isTextElement } from "."; isArrowElement,
isTextElement,
} from "./typeChecks";
import type { MaybeTransformHandleType } from "./transformHandles"; import type { MaybeTransformHandleType } from "./transformHandles";
import type { import type {
@ -30,8 +36,6 @@ import type {
ExcalidrawTextElementWithContainer, ExcalidrawTextElementWithContainer,
NonDeletedExcalidrawElement, NonDeletedExcalidrawElement,
} from "./types"; } from "./types";
import type { AppState } from "../types";
import type { ExtractSetType } from "../utility-types";
export const redrawTextBoundingBox = ( export const redrawTextBoundingBox = (
textElement: ExcalidrawTextElement, textElement: ExcalidrawTextElement,

View file

@ -2,8 +2,10 @@ import {
BOUND_TEXT_PADDING, BOUND_TEXT_PADDING,
DEFAULT_FONT_SIZE, DEFAULT_FONT_SIZE,
DEFAULT_FONT_FAMILY, DEFAULT_FONT_FAMILY,
} from "../constants"; getFontString,
import { getFontString, isTestEnv, normalizeEOL } from "../utils"; isTestEnv,
normalizeEOL,
} from "@excalidraw/common";
import type { FontString, ExcalidrawTextElement } from "./types"; import type { FontString, ExcalidrawTextElement } from "./types";

View file

@ -1,4 +1,4 @@
import { isDevEnv, isTestEnv } from "../utils"; import { isDevEnv, isTestEnv } from "@excalidraw/common";
import { charWidth, getLineWidth } from "./textMeasurements"; import { charWidth, getLineWidth } from "./textMeasurements";

View file

@ -1,12 +1,18 @@
import { pointFrom, pointRotateRads } from "@excalidraw/math";
import type { Radians } from "@excalidraw/math";
import { import {
DEFAULT_TRANSFORM_HANDLE_SPACING, DEFAULT_TRANSFORM_HANDLE_SPACING,
isAndroid, isAndroid,
isIOS, isIOS,
} from "../constants"; } from "@excalidraw/common";
import { pointFrom, pointRotateRads } from "@excalidraw/math";
import type { Radians } from "@excalidraw/math";
import type {
Device,
InteractiveCanvasAppState,
Zoom,
} from "@excalidraw/excalidraw/types";
import { getElementAbsoluteCoords } from "./bounds"; import { getElementAbsoluteCoords } from "./bounds";
import { import {
@ -16,7 +22,6 @@ import {
isLinearElement, isLinearElement,
} from "./typeChecks"; } from "./typeChecks";
import type { Device, InteractiveCanvasAppState, Zoom } from "../types";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { import type {
ElementsMap, ElementsMap,

View file

@ -1,8 +1,9 @@
import { ROUNDNESS } from "../constants"; import { ROUNDNESS, assertNever } from "@excalidraw/common";
import { assertNever } from "../utils";
import type { ElementOrToolType } from "@excalidraw/excalidraw/types";
import type { MarkNonNullable } from "@excalidraw/common/utility-types";
import type { ElementOrToolType } from "../types";
import type { MarkNonNullable } from "../utility-types";
import type { Bounds } from "./bounds"; import type { Bounds } from "./bounds";
import type { import type {
ExcalidrawElement, ExcalidrawElement,

View file

@ -6,13 +6,14 @@ import type {
TEXT_ALIGN, TEXT_ALIGN,
THEME, THEME,
VERTICAL_ALIGN, VERTICAL_ALIGN,
} from "../constants"; } from "@excalidraw/common";
import type { import type {
MakeBrand, MakeBrand,
MarkNonNullable, MarkNonNullable,
Merge, Merge,
ValueOf, ValueOf,
} from "../utility-types"; } from "@excalidraw/common/utility-types";
export type ChartType = "bar" | "line"; export type ChartType = "bar" | "line";
export type FillStyle = "hachure" | "cross-hatch" | "solid" | "zigzag"; export type FillStyle = "hachure" | "cross-hatch" | "solid" | "zigzag";

View file

@ -12,9 +12,9 @@ import {
import type { Curve, LineSegment } from "@excalidraw/math"; import type { Curve, LineSegment } from "@excalidraw/math";
import { getCornerRadius } from "../shapes"; import { getCornerRadius } from "./shapes";
import { getDiamondPoints } from "."; import { getDiamondPoints } from "./bounds";
import type { import type {
ExcalidrawDiamondElement, ExcalidrawDiamondElement,

View file

@ -1,15 +1,18 @@
import { isFrameLikeElement } from "./element/typeChecks"; import { arrayToMap, findIndex, findLastIndex } from "@excalidraw/common";
import { syncMovedIndices } from "./fractionalIndex";
import { getElementsInGroup } from "./groups";
import { getSelectedElements } from "./scene";
import Scene from "./scene/Scene";
import { arrayToMap, findIndex, findLastIndex } from "./utils";
import type { import type { AppState } from "@excalidraw/excalidraw/types";
ExcalidrawElement,
ExcalidrawFrameLikeElement, import type Scene from "@excalidraw/excalidraw/scene/Scene";
} from "./element/types";
import type { AppState } from "./types"; import { isFrameLikeElement } from "./typeChecks";
import { getElementsInGroup } from "./groups";
import { syncMovedIndices } from "./fractionalIndex";
import { getSelectedElements } from "./selection";
import type { ExcalidrawElement, ExcalidrawFrameLikeElement } from "./types";
const isOfTargetFrame = (element: ExcalidrawElement, frameId: string) => { const isOfTargetFrame = (element: ExcalidrawElement, frameId: string) => {
return element.frameId === frameId || element.id === frameId; return element.frameId === frameId || element.id === frameId;
@ -79,11 +82,11 @@ const getTargetIndexAccountingForBinding = (
nextElement: ExcalidrawElement, nextElement: ExcalidrawElement,
elements: readonly ExcalidrawElement[], elements: readonly ExcalidrawElement[],
direction: "left" | "right", direction: "left" | "right",
scene: Scene,
) => { ) => {
if ("containerId" in nextElement && nextElement.containerId) { if ("containerId" in nextElement && nextElement.containerId) {
const containerElement = Scene.getScene(nextElement)!.getElement( // TODO: why not to get the container from the nextElements?
nextElement.containerId, const containerElement = scene.getElement(nextElement.containerId);
);
if (containerElement) { if (containerElement) {
return direction === "left" return direction === "left"
? Math.min( ? Math.min(
@ -100,8 +103,7 @@ const getTargetIndexAccountingForBinding = (
(binding) => binding.type !== "arrow", (binding) => binding.type !== "arrow",
)?.id; )?.id;
if (boundElementId) { if (boundElementId) {
const boundTextElement = const boundTextElement = scene.getElement(boundElementId);
Scene.getScene(nextElement)!.getElement(boundElementId);
if (boundTextElement) { if (boundTextElement) {
return direction === "left" return direction === "left"
? Math.min( ? Math.min(
@ -151,6 +153,7 @@ const getTargetIndex = (
* If whole frame (including all children) is being moved, supply `null`. * If whole frame (including all children) is being moved, supply `null`.
*/ */
containingFrame: ExcalidrawFrameLikeElement["id"] | null, containingFrame: ExcalidrawFrameLikeElement["id"] | null,
scene: Scene,
) => { ) => {
const sourceElement = elements[boundaryIndex]; const sourceElement = elements[boundaryIndex];
@ -190,8 +193,12 @@ const getTargetIndex = (
sourceElement?.groupIds.join("") === nextElement?.groupIds.join("") sourceElement?.groupIds.join("") === nextElement?.groupIds.join("")
) { ) {
return ( return (
getTargetIndexAccountingForBinding(nextElement, elements, direction) ?? getTargetIndexAccountingForBinding(
candidateIndex nextElement,
elements,
direction,
scene,
) ?? candidateIndex
); );
} else if (!nextElement?.groupIds.includes(appState.editingGroupId)) { } else if (!nextElement?.groupIds.includes(appState.editingGroupId)) {
// candidate element is outside current editing group → prevent // candidate element is outside current editing group → prevent
@ -214,8 +221,12 @@ const getTargetIndex = (
if (!nextElement.groupIds.length) { if (!nextElement.groupIds.length) {
return ( return (
getTargetIndexAccountingForBinding(nextElement, elements, direction) ?? getTargetIndexAccountingForBinding(
candidateIndex nextElement,
elements,
direction,
scene,
) ?? candidateIndex
); );
} }
@ -255,6 +266,7 @@ const shiftElementsByOne = (
elements: readonly ExcalidrawElement[], elements: readonly ExcalidrawElement[],
appState: AppState, appState: AppState,
direction: "left" | "right", direction: "left" | "right",
scene: Scene,
) => { ) => {
const indicesToMove = getIndicesToMove(elements, appState); const indicesToMove = getIndicesToMove(elements, appState);
const targetElementsMap = getTargetElementsMap(elements, indicesToMove); const targetElementsMap = getTargetElementsMap(elements, indicesToMove);
@ -289,6 +301,7 @@ const shiftElementsByOne = (
boundaryIndex, boundaryIndex,
direction, direction,
containingFrame, containingFrame,
scene,
); );
if (targetIndex === -1 || boundaryIndex === targetIndex) { if (targetIndex === -1 || boundaryIndex === targetIndex) {
@ -502,15 +515,17 @@ function shiftElementsAccountingForFrames(
export const moveOneLeft = ( export const moveOneLeft = (
allElements: readonly ExcalidrawElement[], allElements: readonly ExcalidrawElement[],
appState: AppState, appState: AppState,
scene: Scene,
) => { ) => {
return shiftElementsByOne(allElements, appState, "left"); return shiftElementsByOne(allElements, appState, "left", scene);
}; };
export const moveOneRight = ( export const moveOneRight = (
allElements: readonly ExcalidrawElement[], allElements: readonly ExcalidrawElement[],
appState: AppState, appState: AppState,
scene: Scene,
) => { ) => {
return shiftElementsByOne(allElements, appState, "right"); return shiftElementsByOne(allElements, appState, "right", scene);
}; };
export const moveAllLeft = ( export const moveAllLeft = (

View file

@ -1,4 +1,4 @@
import React from "react"; import { KEYS } from "@excalidraw/common";
import { import {
actionAlignVerticallyCentered, actionAlignVerticallyCentered,
@ -8,14 +8,17 @@ import {
actionAlignBottom, actionAlignBottom,
actionAlignLeft, actionAlignLeft,
actionAlignRight, actionAlignRight,
} from "../actions"; } from "@excalidraw/excalidraw/actions";
import { defaultLang, setLanguage } from "../i18n"; import { defaultLang, setLanguage } from "@excalidraw/excalidraw/i18n";
import { Excalidraw } from "../index"; import { Excalidraw } from "@excalidraw/excalidraw";
import { KEYS } from "../keys";
import { API } from "./helpers/api"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { UI, Pointer, Keyboard } from "./helpers/ui"; import { UI, Pointer, Keyboard } from "@excalidraw/excalidraw/tests/helpers/ui";
import { act, unmountComponent, render } from "./test-utils"; import {
act,
unmountComponent,
render,
} from "@excalidraw/excalidraw/tests/test-utils";
const mouse = new Pointer("mouse"); const mouse = new Pointer("mouse");

View file

@ -1,15 +1,16 @@
import { KEYS, arrayToMap } from "@excalidraw/common";
import { pointFrom } from "@excalidraw/math"; import { pointFrom } from "@excalidraw/math";
import React from "react";
import { actionWrapTextInContainer } from "../actions/actionBoundText"; import { actionWrapTextInContainer } from "@excalidraw/excalidraw/actions/actionBoundText";
import { getTransformHandles } from "../element/transformHandles";
import { Excalidraw, isLinearElement } from "../index";
import { KEYS } from "../keys";
import { arrayToMap } from "../utils";
import { API } from "./helpers/api"; import { Excalidraw, isLinearElement } from "@excalidraw/excalidraw";
import { UI, Pointer, Keyboard } from "./helpers/ui";
import { fireEvent, render } from "./test-utils"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { UI, Pointer, Keyboard } from "@excalidraw/excalidraw/tests/helpers/ui";
import { fireEvent, render } from "@excalidraw/excalidraw/tests/test-utils";
import { getTransformHandles } from "../src/transformHandles";
const { h } = window; const { h } = window;

View file

@ -1,13 +1,12 @@
import { pointFrom } from "@excalidraw/math"; import { pointFrom } from "@excalidraw/math";
import { arrayToMap, ROUNDNESS } from "@excalidraw/common";
import type { LocalPoint } from "@excalidraw/math"; import type { LocalPoint } from "@excalidraw/math";
import { ROUNDNESS } from "../constants"; import { getElementAbsoluteCoords, getElementBounds } from "../src/bounds";
import { arrayToMap } from "../utils";
import { getElementAbsoluteCoords, getElementBounds } from "./bounds"; import type { ExcalidrawElement, ExcalidrawLinearElement } from "../src/types";
import type { ExcalidrawElement, ExcalidrawLinearElement } from "./types";
const _ce = ({ const _ce = ({
x, x,

View file

@ -1,28 +1,34 @@
import React from "react"; import React from "react";
import { pointFrom } from "@excalidraw/math"; import { pointFrom } from "@excalidraw/math";
import type { LocalPoint } from "@excalidraw/math"; import {
FONT_FAMILY,
ORIG_ID,
ROUNDNESS,
isPrimitive,
} from "@excalidraw/common";
import { FONT_FAMILY, ORIG_ID, ROUNDNESS } from "../constants"; import { Excalidraw } from "@excalidraw/excalidraw";
import { API } from "../tests/helpers/api";
import { isPrimitive } from "../utils"; import { actionDuplicateSelection } from "@excalidraw/excalidraw/actions";
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
import { import {
act, act,
assertElements, assertElements,
getCloneByOrigId, getCloneByOrigId,
render, render,
} from "../tests/test-utils"; } from "@excalidraw/excalidraw/tests/test-utils";
import { Excalidraw } from "..";
import { actionDuplicateSelection } from "../actions";
import { Keyboard, Pointer } from "../tests/helpers/ui"; import type { LocalPoint } from "@excalidraw/math";
import { mutateElement } from "./mutateElement"; import { mutateElement } from "../src/mutateElement";
import { duplicateElement, duplicateElements } from "../src/duplicate";
import { duplicateElement, duplicateElements } from "./duplicate"; import type { ExcalidrawLinearElement } from "../src/types";
import type { ExcalidrawLinearElement } from "./types";
const { h } = window; const { h } = window;
const mouse = new Pointer("mouse"); const mouse = new Pointer("mouse");

View file

@ -1,31 +1,33 @@
import { ARROW_TYPE } from "@excalidraw/common";
import { pointFrom } from "@excalidraw/math"; import { pointFrom } from "@excalidraw/math";
import React from "react"; import { Excalidraw, mutateElement } from "@excalidraw/excalidraw";
import type { LocalPoint } from "@excalidraw/math"; import Scene from "@excalidraw/excalidraw/scene/Scene";
import { actionSelectAll } from "@excalidraw/excalidraw/actions";
import { actionDuplicateSelection } from "@excalidraw/excalidraw/actions/actionDuplicateSelection";
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { Pointer, UI } from "@excalidraw/excalidraw/tests/helpers/ui";
import "../../utils/test-utils";
import { actionSelectAll } from "../actions";
import { actionDuplicateSelection } from "../actions/actionDuplicateSelection";
import { ARROW_TYPE } from "../constants";
import { Excalidraw, mutateElement } from "../index";
import Scene from "../scene/Scene";
import { API } from "../tests/helpers/api";
import { Pointer, UI } from "../tests/helpers/ui";
import { import {
act, act,
fireEvent, fireEvent,
GlobalTestState, GlobalTestState,
queryByTestId, queryByTestId,
render, render,
} from "../tests/test-utils"; } from "@excalidraw/excalidraw/tests/test-utils";
import { bindLinearElement } from "./binding"; import "@excalidraw/utils/test-utils";
import type { LocalPoint } from "@excalidraw/math";
import { bindLinearElement } from "../src/binding";
import type { import type {
ExcalidrawArrowElement, ExcalidrawArrowElement,
ExcalidrawBindableElement, ExcalidrawBindableElement,
ExcalidrawElbowArrowElement, ExcalidrawElbowArrowElement,
} from "./types"; } from "../src/types";
const { h } = window; const { h } = window;

View file

@ -1,9 +1,13 @@
import { Excalidraw } from "../index"; import { KEYS, reseed } from "@excalidraw/common";
import { KEYS } from "../keys";
import { reseed } from "../random"; import { Excalidraw } from "@excalidraw/excalidraw";
import { API } from "../tests/helpers/api";
import { UI, Keyboard, Pointer } from "../tests/helpers/ui"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { render, unmountComponent } from "../tests/test-utils"; import { UI, Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
import {
render,
unmountComponent,
} from "@excalidraw/excalidraw/tests/test-utils";
unmountComponent(); unmountComponent();

View file

@ -1,19 +1,24 @@
/* eslint-disable no-lone-blocks */ /* eslint-disable no-lone-blocks */
import { generateKeyBetween } from "fractional-indexing"; import { generateKeyBetween } from "fractional-indexing";
import { InvalidFractionalIndexError } from "../errors"; import { arrayToMap } from "@excalidraw/common";
import { import {
syncInvalidIndices, syncInvalidIndices,
syncMovedIndices, syncMovedIndices,
validateFractionalIndices, validateFractionalIndices,
} from "../fractionalIndex"; } from "@excalidraw/element/fractionalIndex";
import { arrayToMap } from "../utils";
import { deepCopyElement } from "../element/duplicate"; import { deepCopyElement } from "@excalidraw/element/duplicate";
import { API } from "./helpers/api"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import type { ExcalidrawElement, FractionalIndex } from "../element/types"; import type {
ExcalidrawElement,
FractionalIndex,
} from "@excalidraw/element/types";
import { InvalidFractionalIndexError } from "../src/fractionalIndex";
describe("sync invalid indices with array order", () => { describe("sync invalid indices with array order", () => {
describe("should NOT sync empty array", () => { describe("should NOT sync empty array", () => {

View file

@ -1,10 +1,16 @@
import { API } from "./tests/helpers/api"; import {
import { Keyboard, Pointer } from "./tests/helpers/ui"; convertToExcalidrawElements,
import { getCloneByOrigId, render } from "./tests/test-utils"; Excalidraw,
} from "@excalidraw/excalidraw";
import { convertToExcalidrawElements, Excalidraw } from "./index"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
import {
getCloneByOrigId,
render,
} from "@excalidraw/excalidraw/tests/test-utils";
import type { ExcalidrawElement } from "./element/types"; import type { ExcalidrawElement } from "../src/types";
const { h } = window; const { h } = window;
const mouse = new Pointer("mouse"); const mouse = new Pointer("mouse");

View file

@ -1,28 +1,33 @@
import { pointFrom } from "@excalidraw/math"; import { pointFrom } from "@excalidraw/math";
import React from "react";
import { Excalidraw } from "@excalidraw/excalidraw";
import {
KEYS,
getSizeFromPoints,
reseed,
arrayToMap,
} from "@excalidraw/common";
import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { UI, Keyboard, Pointer } from "@excalidraw/excalidraw/tests/helpers/ui";
import {
render,
unmountComponent,
} from "@excalidraw/excalidraw/tests/test-utils";
import type { LocalPoint } from "@excalidraw/math"; import type { LocalPoint } from "@excalidraw/math";
import { getElementPointsCoords } from "../element/bounds"; import { isLinearElement } from "../src/typeChecks";
import { LinearElementEditor } from "../element/linearElementEditor"; import { resizeSingleElement } from "../src/resizeElements";
import { resizeSingleElement } from "../element/resizeElements"; import { LinearElementEditor } from "../src/linearElementEditor";
import { isLinearElement } from "../element/typeChecks"; import { getElementPointsCoords } from "../src/bounds";
import { Excalidraw } from "../index";
import { KEYS } from "../keys";
import { getSizeFromPoints } from "../points";
import { reseed } from "../random";
import { arrayToMap } from "../utils";
import { API } from "./helpers/api"; import type { Bounds } from "../src/bounds";
import { UI, Keyboard, Pointer } from "./helpers/ui";
import { render, unmountComponent } from "./test-utils";
import type { Bounds } from "../element/bounds";
import type { import type {
ExcalidrawElbowArrowElement, ExcalidrawElbowArrowElement,
ExcalidrawFreeDrawElement, ExcalidrawFreeDrawElement,
ExcalidrawLinearElement, ExcalidrawLinearElement,
} from "../element/types"; } from "../src/types";
unmountComponent(); unmountComponent();

View file

@ -1,4 +1,4 @@
import { makeNextSelectedElementIds } from "./selection"; import { makeNextSelectedElementIds } from "../src/selection";
describe("makeNextSelectedElementIds", () => { describe("makeNextSelectedElementIds", () => {
const _makeNextSelectedElementIds = ( const _makeNextSelectedElementIds = (

View file

@ -1,15 +1,15 @@
import { vi } from "vitest"; import { vi } from "vitest";
import * as constants from "../constants"; import * as constants from "@excalidraw/common";
import { getPerfectElementSize } from "./sizeHelpers"; import { getPerfectElementSize } from "../src/sizeHelpers";
const EPSILON_DIGITS = 3; const EPSILON_DIGITS = 3;
// Needed so that we can mock the value of constants which is done in // Needed so that we can mock the value of constants which is done in
// below tests. In Jest this wasn't needed as global override was possible // below tests. In Jest this wasn't needed as global override was possible
// but vite doesn't allow that hence we need to mock // but vite doesn't allow that hence we need to mock
vi.mock( vi.mock(
"../constants.ts", "@excalidraw/common",
//@ts-ignore //@ts-ignore
async (importOriginal) => { async (importOriginal) => {
const module: any = await importOriginal(); const module: any = await importOriginal();

View file

@ -1,9 +1,9 @@
import { API } from "../tests/helpers/api"; import { API } from "@excalidraw/excalidraw/tests/helpers/api";
import { mutateElement } from "./mutateElement"; import { mutateElement } from "../src/mutateElement";
import { normalizeElementOrder } from "./sortElements"; import { normalizeElementOrder } from "../src/sortElements";
import type { ExcalidrawElement } from "./types"; import type { ExcalidrawElement } from "../src/types";
const assertOrder = ( const assertOrder = (
elements: readonly ExcalidrawElement[], elements: readonly ExcalidrawElement[],

Some files were not shown because too many files have changed in this diff Show more