smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: split gridSize from enabled state & support custom gridStep (#8364)

Browse source
This commit is contained in:
David Luzar 2024-08-14 14:59:14 +02:00 • committed by GitHub
parent 4320a3cf41
commit 3cfcc7b489
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
31 changed files with 737 additions and 278 deletions
Download patch file Download diff file Expand all files Collapse all files

68
packages/excalidraw/tests/__snapshots__/contextmenu.test.tsx.snap
View file

@ -831,7 +831,9 @@ exports[`contextMenu element > right-clicking on a group should select whole gro
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -1034,7 +1036,9 @@ exports[`contextMenu element > selecting 'Add to library' in context menu adds e
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -1247,7 +1251,9 @@ exports[`contextMenu element > selecting 'Bring forward' in context menu brings
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -1575,7 +1581,9 @@ exports[`contextMenu element > selecting 'Bring to front' in context menu brings
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -1903,7 +1911,9 @@ exports[`contextMenu element > selecting 'Copy styles' in context menu copies st
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -2116,7 +2126,9 @@ exports[`contextMenu element > selecting 'Delete' in context menu deletes elemen
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -2353,7 +2365,9 @@ exports[`contextMenu element > selecting 'Duplicate' in context menu duplicates
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -2651,7 +2665,9 @@ exports[`contextMenu element > selecting 'Group selection' in context menu group
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -3017,7 +3033,9 @@ exports[`contextMenu element > selecting 'Paste styles' in context menu pastes s
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -3489,7 +3507,9 @@ exports[`contextMenu element > selecting 'Send backward' in context menu sends e
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -3809,7 +3829,9 @@ exports[`contextMenu element > selecting 'Send to back' in context menu sends el
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -4129,7 +4151,9 @@ exports[`contextMenu element > selecting 'Ungroup selection' in context menu ung
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -5312,7 +5336,9 @@ exports[`contextMenu element > shows 'Group selection' in context menu for multi
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -6436,7 +6462,9 @@ exports[`contextMenu element > shows 'Ungroup selection' in context menu for gro
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -7368,7 +7396,9 @@ exports[`contextMenu element > shows context menu for canvas > [end of test] app
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -8277,7 +8307,9 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,
@ -9168,7 +9200,9 @@ exports[`contextMenu element > shows context menu for element > [end of test] ap
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 100,
"isBindingEnabled": true,
"isLoading": false,

232
packages/excalidraw/tests/__snapshots__/history.test.tsx.snap
View file

@ -48,7 +48,9 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -647,7 +649,9 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -1150,7 +1154,9 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -1515,7 +1521,9 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -1881,7 +1889,9 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -2145,7 +2155,9 @@ exports[`history > multiplayer undo/redo > conflicts in arrows and their bindabl
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -2582,7 +2594,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -2878,7 +2892,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -3159,7 +3175,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -3450,7 +3468,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -3733,7 +3753,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -3965,7 +3987,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -4221,7 +4245,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -4491,7 +4517,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -4719,7 +4747,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -4947,7 +4977,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -5173,7 +5205,9 @@ exports[`history > multiplayer undo/redo > conflicts in bound text elements and
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -5399,7 +5433,9 @@ exports[`history > multiplayer undo/redo > conflicts in frames and their childre
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -5655,7 +5691,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -5983,7 +6021,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -6405,7 +6445,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -6780,7 +6822,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -7096,7 +7140,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -7391,7 +7437,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -7617,7 +7665,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -7969,7 +8019,9 @@ exports[`history > multiplayer undo/redo > should iterate through the history wh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -8321,7 +8373,9 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -8722,7 +8776,9 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -9006,7 +9062,9 @@ exports[`history > multiplayer undo/redo > should not let remote changes to inte
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -9268,7 +9326,9 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -9529,7 +9589,9 @@ exports[`history > multiplayer undo/redo > should not override remote changes on
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -9757,7 +9819,9 @@ exports[`history > multiplayer undo/redo > should override remotely added groups
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -10055,7 +10119,9 @@ exports[`history > multiplayer undo/redo > should override remotely added points
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -10392,7 +10458,9 @@ exports[`history > multiplayer undo/redo > should redistribute deltas when eleme
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -10624,7 +10692,9 @@ exports[`history > multiplayer undo/redo > should redraw arrows on undo > [end o
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -11074,7 +11144,9 @@ exports[`history > multiplayer undo/redo > should update history entries after r
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -11325,7 +11397,9 @@ exports[`history > singleplayer undo/redo > remounting undo/redo buttons should
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -11561,7 +11635,9 @@ exports[`history > singleplayer undo/redo > should clear the redo stack on eleme
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -11799,7 +11875,9 @@ exports[`history > singleplayer undo/redo > should create entry when selecting f
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -12197,7 +12275,9 @@ exports[`history > singleplayer undo/redo > should create new history entry on s
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -12441,7 +12521,9 @@ exports[`history > singleplayer undo/redo > should disable undo/redo buttons whe
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -12679,7 +12761,9 @@ exports[`history > singleplayer undo/redo > should end up with no history entry
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -12917,7 +13001,9 @@ exports[`history > singleplayer undo/redo > should iterate through the history w
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -13161,7 +13247,9 @@ exports[`history > singleplayer undo/redo > should not clear the redo stack on s
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -13490,7 +13578,9 @@ exports[`history > singleplayer undo/redo > should not collapse when applying co
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -13659,7 +13749,9 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -13944,7 +14036,9 @@ exports[`history > singleplayer undo/redo > should not end up with history entry
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -14208,7 +14302,9 @@ exports[`history > singleplayer undo/redo > should not override appstate changes
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -14480,7 +14576,9 @@ exports[`history > singleplayer undo/redo > should support appstate name or view
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -14638,7 +14736,9 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -15331,7 +15431,9 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -15948,7 +16050,9 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -16565,7 +16669,9 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -17274,7 +17380,9 @@ exports[`history > singleplayer undo/redo > should support bidirectional binding
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -18021,7 +18129,9 @@ exports[`history > singleplayer undo/redo > should support changes in elements'
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -18492,7 +18602,9 @@ exports[`history > singleplayer undo/redo > should support duplication of groups
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -19011,7 +19123,9 @@ exports[`history > singleplayer undo/redo > should support element creation, del
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,
@ -19464,7 +19578,9 @@ exports[`history > singleplayer undo/redo > should support linear element creati
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 0,
"isBindingEnabled": true,
"isLoading": false,

208
packages/excalidraw/tests/__snapshots__/regressionTests.test.tsx.snap
View file

@ -48,7 +48,9 @@ exports[`given element A and group of elements B and given both are selected whe
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -457,7 +459,9 @@ exports[`given element A and group of elements B and given both are selected whe
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -857,7 +861,9 @@ exports[`regression tests > Cmd/Ctrl-click exclusively select element under poin
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": false,
"isLoading": false,
@ -1396,7 +1402,9 @@ exports[`regression tests > Drags selected element when hitting only bounding bo
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -1594,7 +1602,9 @@ exports[`regression tests > adjusts z order when grouping > [end of test] appSta
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -1963,7 +1973,9 @@ exports[`regression tests > alt-drag duplicates an element > [end of test] appSt
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -2197,7 +2209,9 @@ exports[`regression tests > arrow keys > [end of test] appState 1`] = `
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -2371,7 +2385,9 @@ exports[`regression tests > can drag element that covers another element, while
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -2685,7 +2701,9 @@ exports[`regression tests > change the properties of a shape > [end of test] app
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -2925,7 +2943,9 @@ exports[`regression tests > click on an element and drag it > [dragged] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -3162,7 +3182,9 @@ exports[`regression tests > click on an element and drag it > [end of test] appS
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -3386,7 +3408,9 @@ exports[`regression tests > click to select a shape > [end of test] appState 1`]
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -3636,7 +3660,9 @@ exports[`regression tests > click-drag to select a group > [end of test] appStat
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -3941,7 +3967,9 @@ exports[`regression tests > deleting last but one element in editing group shoul
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -4349,7 +4377,9 @@ exports[`regression tests > deselects group of selected elements on pointer down
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -4626,7 +4656,9 @@ exports[`regression tests > deselects group of selected elements on pointer up w
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -4873,7 +4905,9 @@ exports[`regression tests > deselects selected element on pointer down when poin
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -5077,7 +5111,9 @@ exports[`regression tests > deselects selected element, on pointer up, when clic
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -5270,7 +5306,9 @@ exports[`regression tests > double click to edit a group > [end of test] appStat
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -5646,7 +5684,9 @@ exports[`regression tests > drags selected elements from point inside common bou
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -5930,7 +5970,9 @@ exports[`regression tests > draw every type of shape > [end of test] appState 1`
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -6732,7 +6774,9 @@ exports[`regression tests > given a group of selected elements with an element t
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -7056,7 +7100,9 @@ exports[`regression tests > given a selected element A and a not selected elemen
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -7326,7 +7372,9 @@ exports[`regression tests > given selected element A with lower z-index than uns
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -7554,7 +7602,9 @@ exports[`regression tests > given selected element A with lower z-index than uns
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -7785,7 +7835,9 @@ exports[`regression tests > key 2 selects rectangle tool > [end of test] appStat
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -7959,7 +8011,9 @@ exports[`regression tests > key 3 selects diamond tool > [end of test] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -8133,7 +8187,9 @@ exports[`regression tests > key 4 selects ellipse tool > [end of test] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -8307,7 +8363,9 @@ exports[`regression tests > key 5 selects arrow tool > [end of test] appState 1`
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -8523,7 +8581,9 @@ exports[`regression tests > key 6 selects line tool > [end of test] appState 1`]
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -8738,7 +8798,9 @@ exports[`regression tests > key 7 selects freedraw tool > [end of test] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -8926,7 +8988,9 @@ exports[`regression tests > key a selects arrow tool > [end of test] appState 1`
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -9142,7 +9206,9 @@ exports[`regression tests > key d selects diamond tool > [end of test] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -9316,7 +9382,9 @@ exports[`regression tests > key l selects line tool > [end of test] appState 1`]
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -9531,7 +9599,9 @@ exports[`regression tests > key o selects ellipse tool > [end of test] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -9705,7 +9775,9 @@ exports[`regression tests > key p selects freedraw tool > [end of test] appState
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -9893,7 +9965,9 @@ exports[`regression tests > key r selects rectangle tool > [end of test] appStat
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -10067,7 +10141,9 @@ exports[`regression tests > make a group and duplicate it > [end of test] appSta
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -10575,7 +10651,9 @@ exports[`regression tests > noop interaction after undo shouldn't create history
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -10846,7 +10924,9 @@ exports[`regression tests > pinch-to-zoom works > [end of test] appState 1`] = `
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -10966,7 +11046,9 @@ exports[`regression tests > shift click on selected element should deselect it o
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -11159,7 +11241,9 @@ exports[`regression tests > shift-click to multiselect, then drag > [end of test
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -11464,7 +11548,9 @@ exports[`regression tests > should group elements and ungroup them > [end of tes
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -11870,7 +11956,9 @@ exports[`regression tests > single-clicking on a subgroup of a selected group sh
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -12477,7 +12565,9 @@ exports[`regression tests > spacebar + drag scrolls the canvas > [end of test] a
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -12600,7 +12690,9 @@ exports[`regression tests > supports nested groups > [end of test] appState 1`]
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -13178,7 +13270,9 @@ exports[`regression tests > switches from group of selected elements to another
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -13510,7 +13604,9 @@ exports[`regression tests > switches selected element on pointer down > [end of
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -13769,7 +13865,9 @@ exports[`regression tests > two-finger scroll works > [end of test] appState 1`]
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -13889,7 +13987,9 @@ exports[`regression tests > undo/redo drawing an element > [end of test] appStat
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -14262,7 +14362,9 @@ exports[`regression tests > updates fontSize & fontFamily appState > [end of tes
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,
@ -14382,7 +14484,9 @@ exports[`regression tests > zoom hotkeys > [end of test] appState 1`] = `
"outline": true,
},
"frameToHighlight": null,
"gridSize": null,
"gridModeEnabled": false,
"gridSize": 20,
"gridStep": 5,
"height": 768,
"isBindingEnabled": true,
"isLoading": false,

10
packages/excalidraw/tests/excalidraw.test.tsx
View file

@ -2,7 +2,7 @@ import React from "react";
import { fireEvent, GlobalTestState, toggleMenu, render } from "./test-utils";
import { Excalidraw, Footer, MainMenu } from "../index";
import { queryByText, queryByTestId } from "@testing-library/react";
import { GRID_SIZE, THEME } from "../constants";
import { THEME } from "../constants";
import { t } from "../i18n";
import { useMemo } from "react";
@ -91,7 +91,7 @@ describe("<Excalidraw/>", () => {
describe("Test gridModeEnabled prop", () => {
it('should show grid mode in context menu when gridModeEnabled is "undefined"', async () => {
const { container } = await render(<Excalidraw />);
expect(h.state.gridSize).toBe(null);
expect(h.state.gridModeEnabled).toBe(false);
expect(
container.getElementsByClassName("disable-zen-mode--visible").length,
@ -103,14 +103,14 @@ describe("<Excalidraw/>", () => {
});
const contextMenu = document.querySelector(".context-menu");
fireEvent.click(queryByText(contextMenu as HTMLElement, "Toggle grid")!);
expect(h.state.gridSize).toBe(GRID_SIZE);
expect(h.state.gridModeEnabled).toBe(true);
});
it('should not show grid mode in context menu when gridModeEnabled is not "undefined"', async () => {
const { container } = await render(
<Excalidraw gridModeEnabled={false} />,
);
expect(h.state.gridSize).toBe(null);
expect(h.state.gridModeEnabled).toBe(false);
expect(
container.getElementsByClassName("disable-zen-mode--visible").length,
@ -122,7 +122,7 @@ describe("<Excalidraw/>", () => {
});
const contextMenu = document.querySelector(".context-menu");
expect(queryByText(contextMenu as HTMLElement, "Show grid")).toBe(null);
expect(h.state.gridSize).toBe(null);
expect(h.state.gridModeEnabled).toBe(false);
});
});

2
packages/excalidraw/tests/fixtures/diagramFixture.ts vendored
View file

@ -12,7 +12,7 @@ export const diagramFixture = {
elements: [diamondFixture, ellipseFixture, rectangleFixture],
appState: {
viewBackgroundColor: "#ffffff",
gridSize: null,
gridModeEnabled: false,
},
files: {},
};