smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix: remove scene hack from export.ts & remove pass elementsMap to getContainingFrame (#7713)

Browse source 
* fix: remove scene hack from export.ts as its not needed anymore

* remove

* pass elementsMap to getContainingFrame

* remove unused `mapElementIds` param

---------

Co-authored-by: dwelle <5153846+dwelle@users.noreply.github.com>
This commit is contained in:
Aakansha Doshi 2024-02-21 16:34:20 +05:30 • committed by GitHub
parent 2e719ff671
commit 361a9449bb
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
7 changed files with 38 additions and 92 deletions
Download patch file Download diff file Expand all files Collapse all files

20
packages/excalidraw/renderer/renderElement.ts
View file

@ -257,7 +257,8 @@ const generateElementCanvas = (
canvasOffsetY,
boundTextElementVersion:
getBoundTextElement(element, elementsMap)?.version || null,
containingFrameOpacity: getContainingFrame(element)?.opacity || 100,
containingFrameOpacity:
getContainingFrame(element, elementsMap)?.opacity || 100,
};
};
@ -440,7 +441,8 @@ const generateElementWithCanvas = (
const boundTextElementVersion =
getBoundTextElement(element, elementsMap)?.version || null;
const containingFrameOpacity = getContainingFrame(element)?.opacity || 100;
const containingFrameOpacity =
getContainingFrame(element, elementsMap)?.opacity || 100;
if (
!prevElementWithCanvas ||
@ -652,7 +654,7 @@ export const renderElement = (
) => {
context.globalAlpha = getRenderOpacity(
element,
getContainingFrame(element),
getContainingFrame(element, elementsMap),
renderConfig.elementsPendingErasure,
);
@ -924,11 +926,12 @@ const maybeWrapNodesInFrameClipPath = (
root: SVGElement,
nodes: SVGElement[],
frameRendering: AppState["frameRendering"],
elementsMap: RenderableElementsMap,
) => {
if (!frameRendering.enabled || !frameRendering.clip) {
return null;
}
const frame = getContainingFrame(element);
const frame = getContainingFrame(element, elementsMap);
if (frame) {
const g = root.ownerDocument!.createElementNS(SVG_NS, "g");
g.setAttributeNS(SVG_NS, "clip-path", `url(#${frame.id})`);
@ -990,7 +993,9 @@ export const renderElementToSvg = (
};
const opacity =
((getContainingFrame(element)?.opacity ?? 100) * element.opacity) / 10000;
((getContainingFrame(element, elementsMap)?.opacity ?? 100) *
element.opacity) /
10000;
switch (element.type) {
case "selection": {
@ -1024,6 +1029,7 @@ export const renderElementToSvg = (
root,
[node],
renderConfig.frameRendering,
elementsMap,
);
addToRoot(g || node, element);
@ -1215,6 +1221,7 @@ export const renderElementToSvg = (
root,
[group, maskPath],
renderConfig.frameRendering,
elementsMap,
);
if (g) {
addToRoot(g, element);
@ -1258,6 +1265,7 @@ export const renderElementToSvg = (
root,
[node],
renderConfig.frameRendering,
elementsMap,
);
addToRoot(g || node, element);
@ -1355,6 +1363,7 @@ export const renderElementToSvg = (
root,
[g],
renderConfig.frameRendering,
elementsMap,
);
addToRoot(clipG || g, element);
}
@ -1442,6 +1451,7 @@ export const renderElementToSvg = (
root,
[node],
renderConfig.frameRendering,
elementsMap,
);
addToRoot(g || node, element);