smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Bound text ordering fix

Browse source 
Signed-off-by: Mark Tolmacs <mark@lazycat.hu>
This commit is contained in:
Mark Tolmacs 2025-03-19 18:44:44 +01:00
parent f9566b04a5
commit 351abdb70a
No known key found for this signature in database
2 changed files with 15 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

14
packages/excalidraw/element/duplicate.ts
View file

@ -193,8 +193,18 @@ export const duplicateElements = (
return; return;
} }
if (opts?.reverseOrder && index < 1) {
elementsWithClones.unshift(...castArray(elements));
return;
}
if (!opts?.reverseOrder && index > elementsWithClones.length - 1) {
elementsWithClones.push(...castArray(elements));
return;
}
elementsWithClones.splice( elementsWithClones.splice(
Math.max(index + (!!opts?.reverseOrder ? -1 : 1), 0), index + (!!opts?.reverseOrder ? 0 : 1),
0, 0,
...castArray(elements), ...castArray(elements),
); );
@ -278,7 +288,7 @@ export const duplicateElements = (
if (boundTextElement) { if (boundTextElement) {
insertAfterIndex( insertAfterIndex(
targetIndex, targetIndex + (!!opts?.reverseOrder ? -1 : 0),
copyElements([element, boundTextElement]), copyElements([element, boundTextElement]),
); );
} else { } else {

6
packages/excalidraw/tests/__snapshots__/regressionTests.test.tsx.snap
View file

@ -10629,7 +10629,7 @@ History {
"id7", "id7",
], ],
"height": 10, "height": 10,
"index": "a0G", "index": "a1G",
"isDeleted": false, "isDeleted": false,
"link": null, "link": null,
"locked": false, "locked": false,
@ -10662,7 +10662,7 @@ History {
"id7", "id7",
], ],
"height": 10, "height": 10,
"index": "a0V", "index": "a1V",
"isDeleted": false, "isDeleted": false,
"link": null, "link": null,
"locked": false, "locked": false,
@ -10695,7 +10695,7 @@ History {
"id7", "id7",
], ],
"height": 10, "height": 10,
"index": "a0l", "index": "a1l",
"isDeleted": false, "isDeleted": false,
"link": null, "link": null,
"locked": false, "locked": false,