mirror of
https://github.com/excalidraw/excalidraw.git
synced 2025-05-03 10:00:07 -04:00
Fix issues related to history (#701)
* Separate UI from Canvas * Explicitly define history recording * ActionManager: Set syncActionState during construction instead of in every call * Add commit to history flag to necessary actions * Disable undoing during multiElement * Write custom equality function for UI component to render it only when specific props and elements change * Remove stale comments about history skipping * Stop undo/redoing when in resizing element mode * wip * correctly reset resizingElement & add undo check * Separate selection element from the rest of the array and stop redrawing the UI when dragging the selection * Remove selectionElement from local storage * Remove unnecessary readonly type casting in actionFinalize * Fix undo / redo for multi points * Fix an issue that did not update history when elements were locked * Disable committing to history for noops - deleteSelected without deleting anything - Basic selection * Use generateEntry only inside history and pass elements and appstate to history * Update component after every history resume * Remove last item from the history only if in multi mode * Resume recording when element type is not selection * ensure we prevent hotkeys only on writable elements * Remove selection clearing from history * Remove one point arrows as they are invisibly small * Remove shape of elements from local storage * Fix removing invisible element from the array * add missing history resuming cases & simplify slice * fix lint * don't regenerate elements if no elements deselected * regenerate elements array on selection * reset state.selectionElement unconditionally * Use getter instead of passing appState and scene data through functions to actions * fix import Co-authored-by: David Luzar <luzar.david@gmail.com>
This commit is contained in:
parent
972d69da6c
commit
33016bf6bf
18 changed files with 450 additions and 413 deletions
|
@ -47,6 +47,7 @@ export const actionChangeStrokeColor: Action = {
|
|||
appState: { ...appState, currentItemStrokeColor: value },
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<>
|
||||
<h3 aria-hidden="true">{t("labels.stroke")}</h3>
|
||||
|
@ -77,6 +78,7 @@ export const actionChangeBackgroundColor: Action = {
|
|||
appState: { ...appState, currentItemBackgroundColor: value },
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<>
|
||||
<h3 aria-hidden="true">{t("labels.background")}</h3>
|
||||
|
@ -107,6 +109,7 @@ export const actionChangeFillStyle: Action = {
|
|||
appState: { ...appState, currentItemFillStyle: value },
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<fieldset>
|
||||
<legend>{t("labels.fill")}</legend>
|
||||
|
@ -143,6 +146,7 @@ export const actionChangeStrokeWidth: Action = {
|
|||
appState: { ...appState, currentItemStrokeWidth: value },
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<fieldset>
|
||||
<legend>{t("labels.strokeWidth")}</legend>
|
||||
|
@ -177,6 +181,7 @@ export const actionChangeSloppiness: Action = {
|
|||
appState: { ...appState, currentItemRoughness: value },
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<fieldset>
|
||||
<legend>{t("labels.sloppiness")}</legend>
|
||||
|
@ -211,6 +216,7 @@ export const actionChangeOpacity: Action = {
|
|||
appState: { ...appState, currentItemOpacity: value },
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<label className="control-label">
|
||||
{t("labels.opacity")}
|
||||
|
@ -272,6 +278,7 @@ export const actionChangeFontSize: Action = {
|
|||
},
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<fieldset>
|
||||
<legend>{t("labels.fontSize")}</legend>
|
||||
|
@ -320,6 +327,7 @@ export const actionChangeFontFamily: Action = {
|
|||
},
|
||||
};
|
||||
},
|
||||
commitToHistory: () => true,
|
||||
PanelComponent: ({ elements, appState, updateData }) => (
|
||||
<fieldset>
|
||||
<legend>{t("labels.fontFamily")}</legend>
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue