smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Remove last get/setTransform (#964)

Browse source 
My original hack to put the scale when we create the canvas element doesn't make much sense. It should be done when we are rendering the scene. I moved it there in this PR.

The rest was all about forwarding the scale to where it's needed.
This commit is contained in:
Christopher Chedeau 2020-03-15 12:25:18 -07:00 • committed by GitHub
parent 79ea76b48b
commit 2937efacde
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
6 changed files with 31 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/utils.ts
View file

@ -157,8 +157,9 @@ export function viewportCoordsToSceneCoords(
zoom: number;
},
canvas: HTMLCanvasElement | null,
scale: number,
) {
const zoomOrigin = getZoomOrigin(canvas);
const zoomOrigin = getZoomOrigin(canvas, scale);
const clientXWithZoom = zoomOrigin.x + (clientX - zoomOrigin.x) / zoom;
const clientYWithZoom = zoomOrigin.y + (clientY - zoomOrigin.y) / zoom;
@ -180,8 +181,9 @@ export function sceneCoordsToViewportCoords(
zoom: number;
},
canvas: HTMLCanvasElement | null,
scale: number,
) {
const zoomOrigin = getZoomOrigin(canvas);
const zoomOrigin = getZoomOrigin(canvas, scale);
const sceneXWithZoomAndScroll =
zoomOrigin.x - (zoomOrigin.x - sceneX - scrollX) * zoom;
const sceneYWithZoomAndScroll =