smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

feat: Don't add midpoint until dragged beyond a threshold (#5927)

Browse source 
* Don't add midpoint until dragged beyond a threshold

* remove unnecessary code

* fix tests

* fix

* add spec

* remove isMidpoint

* cleanup

* fix threshold for zoom

* split into shouldAddMidpoint and addMidpoint

* wrap in flushSync for synchronous updates

* remove threshold for line editor and add spec

* [unrelated] fix stack overflow state update

* fix tests

* don't drag arrow when dragging to add mid point

* add specs

Co-authored-by: dwelle <luzar.david@gmail.com>
This commit is contained in:
Aakansha Doshi 2022-11-29 00:01:53 +05:30 • committed by GitHub
parent baf9651d34
commit 25c6056b03
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 258 additions and 63 deletions
Download patch file Download diff file Expand all files Collapse all files

16
src/tests/__snapshots__/selection.test.tsx.snap
View file

@ -21,10 +21,6 @@ Object {
0,
0,
],
Array [
15,
25,
],
Array [
30,
50,
@ -40,8 +36,8 @@ Object {
"strokeWidth": 1,
"type": "arrow",
"updated": 1,
"version": 4,
"versionNonce": 453191,
"version": 3,
"versionNonce": 449462985,
"width": 30,
"x": 10,
"y": 10,
@ -69,10 +65,6 @@ Object {
0,
0,
],
Array [
15,
25,
],
Array [
30,
50,
@ -88,8 +80,8 @@ Object {
"strokeWidth": 1,
"type": "line",
"updated": 1,
"version": 4,
"versionNonce": 453191,
"version": 3,
"versionNonce": 449462985,
"width": 30,
"x": 10,
"y": 10,