smig/excalidraw
1
0
Fork 0
mirror of https://github.com/excalidraw/excalidraw.git synced 2025-05-03 10:00:07 -04:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix #9292

Browse source
This commit is contained in:
Mark Tolmacs 2025-04-05 19:58:53 +02:00
parent c79e892e55
commit 1ef51d6b33
3 changed files with 51 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

78
packages/excalidraw/data/__snapshots__/transform.test.ts.snap
View file

@ -104,12 +104,12 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to existing s
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0.5, 0,
], ],
[ [
394.5, 394,
34.5, 34,
], ],
], ],
"roughness": 1, "roughness": 1,
@ -129,8 +129,8 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to existing s
"version": 4, "version": 4,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 395, "width": 395,
"x": 247, "x": 247.5,
"y": 420, "y": 420.5,
} }
`; `;
@ -160,11 +160,11 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to existing s
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
399.5, 399,
0, 0,
], ],
], ],
@ -185,7 +185,7 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to existing s
"version": 4, "version": 4,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 400, "width": 400,
"x": 227, "x": 227.5,
"y": 450, "y": 450,
} }
`; `;
@ -350,11 +350,11 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to existing t
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -375,7 +375,7 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to existing t
"version": 4, "version": 4,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 255, "x": 255.5,
"y": 239, "y": 239,
} }
`; `;
@ -452,11 +452,11 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to shapes whe
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -477,7 +477,7 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to shapes whe
"version": 4, "version": 4,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 255, "x": 255.5,
"y": 239, "y": 239,
} }
`; `;
@ -628,11 +628,11 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to text when
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -653,7 +653,7 @@ exports[`Test Transform > Test arrow bindings > should bind arrows to text when
"version": 4, "version": 4,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 255, "x": 255.5,
"y": 239, "y": 239,
} }
`; `;
@ -845,11 +845,11 @@ exports[`Test Transform > should transform linear elements 1`] = `
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -866,7 +866,7 @@ exports[`Test Transform > should transform linear elements 1`] = `
"version": 2, "version": 2,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 100, "x": 100.5,
"y": 20, "y": 20,
} }
`; `;
@ -893,11 +893,11 @@ exports[`Test Transform > should transform linear elements 2`] = `
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -914,7 +914,7 @@ exports[`Test Transform > should transform linear elements 2`] = `
"version": 2, "version": 2,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 450, "x": 450.5,
"y": 20, "y": 20,
} }
`; `;
@ -1490,11 +1490,11 @@ exports[`Test Transform > should transform the elements correctly when linear el
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
272.485, 271.985,
0, 0,
], ],
], ],
@ -1517,7 +1517,7 @@ exports[`Test Transform > should transform the elements correctly when linear el
"version": 4, "version": 4,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 272.985, "width": 272.985,
"x": 111.262, "x": 111.762,
"y": 57, "y": 57,
} }
`; `;
@ -1862,11 +1862,11 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -1883,7 +1883,7 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"version": 2, "version": 2,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 100, "x": 100.5,
"y": 100, "y": 100,
} }
`; `;
@ -1915,11 +1915,11 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -1936,7 +1936,7 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"version": 2, "version": 2,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 100, "x": 100.5,
"y": 200, "y": 200,
} }
`; `;
@ -1968,11 +1968,11 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -1989,7 +1989,7 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"version": 2, "version": 2,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 100, "x": 100.5,
"y": 300, "y": 300,
} }
`; `;
@ -2021,11 +2021,11 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"opacity": 100, "opacity": 100,
"points": [ "points": [
[ [
0.5, 0,
0, 0,
], ],
[ [
99.5, 99,
0, 0,
], ],
], ],
@ -2042,7 +2042,7 @@ exports[`Test Transform > should transform to labelled arrows when label provide
"version": 2, "version": 2,
"versionNonce": Any<Number>, "versionNonce": Any<Number>,
"width": 100, "width": 100,
"x": 100, "x": 100.5,
"y": 400, "y": 400,
} }
`; `;

6
packages/excalidraw/data/transform.test.ts
View file

@ -427,7 +427,7 @@ describe("Test Transform", () => {
const [arrow, text, rectangle, ellipse] = excalidrawElements; const [arrow, text, rectangle, ellipse] = excalidrawElements;
expect(arrow).toMatchObject({ expect(arrow).toMatchObject({
type: "arrow", type: "arrow",
x: 255, x: 255.5,
y: 239, y: 239,
boundElements: [{ id: text.id, type: "text" }], boundElements: [{ id: text.id, type: "text" }],
startBinding: { startBinding: {
@ -512,7 +512,7 @@ describe("Test Transform", () => {
expect(arrow).toMatchObject({ expect(arrow).toMatchObject({
type: "arrow", type: "arrow",
x: 255, x: 255.5,
y: 239, y: 239,
boundElements: [{ id: text1.id, type: "text" }], boundElements: [{ id: text1.id, type: "text" }],
startBinding: { startBinding: {
@ -730,7 +730,7 @@ describe("Test Transform", () => {
const [, , arrow, text] = excalidrawElements; const [, , arrow, text] = excalidrawElements;
expect(arrow).toMatchObject({ expect(arrow).toMatchObject({
type: "arrow", type: "arrow",
x: 255, x: 255.5,
y: 239, y: 239,
boundElements: [ boundElements: [
{ {

10
packages/excalidraw/data/transform.ts
View file

@ -36,6 +36,8 @@ import { syncInvalidIndices } from "@excalidraw/element/fractionalIndex";
import { redrawTextBoundingBox } from "@excalidraw/element/textElement"; import { redrawTextBoundingBox } from "@excalidraw/element/textElement";
import { LinearElementEditor } from "@excalidraw/element/linearElementEditor";
import type { ElementConstructorOpts } from "@excalidraw/element/newElement"; import type { ElementConstructorOpts } from "@excalidraw/element/newElement";
import type { import type {
@ -463,7 +465,13 @@ const bindLinearElementToElement = (
newPoints[endPointIndex][1] += delta; newPoints[endPointIndex][1] += delta;
} }
Object.assign(linearElement, { points: newPoints }); Object.assign(
linearElement,
LinearElementEditor.getNormalizedPoints({
...linearElement,
points: newPoints,
}),
);
return { return {
linearElement, linearElement,