mirror of
https://github.com/excalidraw/excalidraw.git
synced 2025-05-03 10:00:07 -04:00
fixed behaviour for top menu
This commit is contained in:
parent
d92384b77d
commit
0a72ebb65e
2 changed files with 44 additions and 3 deletions
|
@ -17,7 +17,11 @@ import {
|
|||
THEME,
|
||||
ZOOM_STEP,
|
||||
} from "../constants";
|
||||
import { getCommonBounds, getNonDeletedElements } from "../element";
|
||||
import {
|
||||
getCommonBounds,
|
||||
getNonDeletedElements,
|
||||
isInvisiblySmallElement,
|
||||
} from "../element";
|
||||
import type { ExcalidrawElement } from "../element/types";
|
||||
import { t } from "../i18n";
|
||||
import { CODES, KEYS } from "../keys";
|
||||
|
@ -28,7 +32,7 @@ import type { AppState, Offsets } from "../types";
|
|||
import { getShortcutKey, updateActiveTool } from "../utils";
|
||||
import { register } from "./register";
|
||||
import { Tooltip } from "../components/Tooltip";
|
||||
import { newElementWith } from "../element/mutateElement";
|
||||
import { mutateElement, newElementWith } from "../element/mutateElement";
|
||||
import {
|
||||
getDefaultAppState,
|
||||
isEraserActive,
|
||||
|
@ -39,6 +43,7 @@ import type { SceneBounds } from "../element/bounds";
|
|||
import { setCursor } from "../cursor";
|
||||
import { CaptureUpdateAction } from "../store";
|
||||
import { clamp, roundToStep } from "@excalidraw/math";
|
||||
import { isLinearElement } from "../element/typeChecks";
|
||||
|
||||
export const actionChangeViewBackgroundColor = register({
|
||||
name: "changeViewBackgroundColor",
|
||||
|
@ -541,13 +546,44 @@ export const actionToggleHandTool = register({
|
|||
setCursor(app.interactiveCanvas, CURSOR_TYPE.GRAB);
|
||||
}
|
||||
|
||||
let newElements = elements;
|
||||
|
||||
const multiPointElement =
|
||||
appState.multiElement && isLinearElement(appState.multiElement)
|
||||
? appState.multiElement
|
||||
: null;
|
||||
|
||||
if (multiPointElement) {
|
||||
// pen and mouse have hover
|
||||
if (appState.lastPointerDownWith !== "touch") {
|
||||
const { points, lastCommittedPoint } = multiPointElement;
|
||||
if (
|
||||
!lastCommittedPoint ||
|
||||
points[points.length - 1] !== lastCommittedPoint
|
||||
) {
|
||||
mutateElement(multiPointElement, {
|
||||
points: multiPointElement.points.slice(0, -1),
|
||||
});
|
||||
}
|
||||
}
|
||||
if (isInvisiblySmallElement(multiPointElement)) {
|
||||
// TODO: #7348 in theory this gets recorded by the store, so the invisible elements could be restored by the undo/redo, which might be not what we would want
|
||||
newElements = newElements.filter(
|
||||
(el) => el.id !== multiPointElement.id,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
return {
|
||||
elements: newElements,
|
||||
appState: {
|
||||
...appState,
|
||||
selectedElementIds: {},
|
||||
selectedGroupIds: {},
|
||||
activeEmbeddable: null,
|
||||
activeTool,
|
||||
newElement: null,
|
||||
multiElement: null,
|
||||
},
|
||||
captureUpdate: CaptureUpdateAction.IMMEDIATELY,
|
||||
};
|
||||
|
|
|
@ -3576,7 +3576,7 @@ class App extends React.Component<AppProps, AppState> {
|
|||
...prevState.activeTool,
|
||||
...updateActiveTool(
|
||||
this.state,
|
||||
prevState.activeTool.locked
|
||||
prevState.activeTool.locked && !prevState.newElement
|
||||
? { type: "selection" }
|
||||
: prevState.activeTool,
|
||||
),
|
||||
|
@ -4692,6 +4692,11 @@ class App extends React.Component<AppProps, AppState> {
|
|||
return;
|
||||
}
|
||||
|
||||
//cancel adding linearElement if tool is switched
|
||||
if (this.state.newElement && isLinearElement(this.state.newElement)) {
|
||||
this.actionManager.executeAction(actionFinalize);
|
||||
}
|
||||
|
||||
const nextActiveTool = updateActiveTool(this.state, tool);
|
||||
if (nextActiveTool.type === "hand") {
|
||||
setCursor(this.interactiveCanvas, CURSOR_TYPE.GRAB);
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue